synchronously register embeddables and actions to fix race condition causing flaky add panel test by nreese · Pull Request #268218 · elastic/kibana

nreese · 2026-05-07T15:03:36Z

Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/12180

The reason for flaky tests is that plugins are registering actions asynchronously. This introduces a race condition where ADD_PANEL_TRIGGER actions may not be registered before Dashboard's "add panel" menu is rendered.

PR resolves the race condition by registering embeddables and actions synchronously.

PR tries to prevent issue like this from being re-introduced by throwing on embeddable registration after start method is run.

…dd panel test

nreese · 2026-05-07T15:05:53Z

/ci

nreese · 2026-05-07T15:45:35Z

/ci

nreese · 2026-05-07T15:46:34Z

        'annotation-and-navigationGroup',
-        'mlGroup',
        'logs-aiopsGroup',
+        'mlGroup',


Updated expects because aiops is rendered before ml once race condition is resolved. These 2 groups both specify order of 0

nreese · 2026-05-07T16:39:04Z

/ci

kibanamachine · 2026-05-07T17:31:36Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#12168

[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch stateful --domain classic): 0/50 tests passed.
[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain search): 0/50 tests passed.
[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain security_complete): 0/50 tests passed.
[❌] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain observability_complete): 0/50 tests passed.
[✅] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain observability_logs_essentials): 50/50 tests passed.

see run history

nreese · 2026-05-07T18:21:22Z

/ci

nreese · 2026-05-07T18:44:59Z

/ci

This reverts commit f39a253.

This reverts commit 8a479dc.

nreese · 2026-05-07T19:31:53Z

/ci

nreese · 2026-05-07T20:22:01Z

    loadTestFile(require.resolve('./dashboard_settings'));
    loadTestFile(require.resolve('./data_shared_attributes'));
    loadTestFile(require.resolve('./dashboard_back_button'));
-    loadTestFile(require.resolve('./dashboard_panel_listing'));


removed dashboard_panel_listing because it tests the same features covered by src/platform/plugins/shared/dashboard/test/scout/ui/parallel_tests/dashboard_add_panel_flyout.spec.ts

nreese · 2026-05-07T20:35:18Z

/ci

kibanamachine · 2026-05-08T03:30:54Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#12180

[✅] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch stateful --domain classic): 25/25 tests passed.
[✅] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain search): 25/25 tests passed.
[✅] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain security_complete): 25/25 tests passed.
[✅] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain observability_complete): 25/25 tests passed.
[✅] src/platform/plugins/shared/dashboard/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain observability_logs_essentials): 25/25 tests passed.

see run history

infra-vault-gh-plugin-prod · 2026-05-08T03:30:57Z

Pinging @elastic/kibana-presentation (Team:Presentation)

baileycash-elastic

actionable obs changes lgtm, tested locally

infra-vault-gh-plugin-prod · 2026-05-08T04:06:37Z

Pinging @elastic/obs-presentation-team (Team:obs-presentation)

iblancof

obs-exploration code changesLGTM

jgowdyelastic · 2026-05-08T09:13:46Z

I had already created a very similar PR for ML's AIOps plugin earlier this week which has now been merged.
Apologies for conflicts. I believe all of the AIOps changes in this PR can be removed.

nreese · 2026-05-08T14:17:13Z

I had already created a very similar #268001 for ML's AIOps plugin earlier this week which has now been merged.
Apologies for conflicts. I believe all of the AIOps changes in this PR can be removed.

Thanks for the heads up. I have removed all aiops changes

nreese · 2026-05-08T14:31:16Z

  alerting: 22371
  alertingVTwo: 76778
-  apm: 27979
+  apm: 28027


Increase expected because plugin was async importing ./embeddable/register_embeddables during setup method. This PR replaced the async import with a sync import to better reflect the actual page load metrics

rmyz

obs-presentation changes LGTM

ThomThomson

Presentation team Changes LGTM! Code only review

ThomThomson · 2026-05-08T17:46:42Z

  constructor() {}

  public setup(core: CoreSetup<LinksStartDependencies>, plugins: LinksSetupDependencies) {
-    core.getStartServices().then(([_, deps]) => {


Great to see this removed. No reason to get start contracts when they aren't used.

dmlemeshko

kbn/scout changes LGTM

TamerlanG · 2026-05-10T01:19:02Z

Approved, but you would need to have to update the RSPack limits.yml too

nreese · 2026-05-11T13:10:50Z

Approved, but you would need to have to update the RSPack limits.yml too

Asked in slack about how to determine RSPack limits and received the answer

"However, I would probably not require those updates, because that’s currently out of band, it’s an alternative, so we can’t keep prompting devs to update it"

With this prompt, I will leave RSPack limits unchanged

kibanamachine · 2026-05-11T14:00:41Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 4b7ab2b

Failed CI Steps

Test Failures

[job] [logs] Scout Lane #10 - stateful-classic / default / local-stateful-classic - Observability Landing Page (discover.isEsqlDefault enabled) - redirects to onboarding when no logs data exists
[job] [logs] Scout Lane #3 - stateful-classic / default / local-stateful-classic - Tags management — accessibility - tags management page a11y
[job] [logs] Jest Integration Tests #7 / workflow with wait step when duration is short should have correct workflow duration

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`slo`	1344	1346	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.8MB	2.7MB	-2.3KB
`slo`	1.2MB	1.2MB	+631.0B
total			-1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`apm`	25.3KB	27.4KB	+2.1KB
`embeddable`	17.7KB	17.9KB	+231.0B
`links`	8.1KB	8.0KB	-79.0B
`presentationUtil`	8.0KB	8.0KB	+32.0B
`slo`	37.0KB	37.1KB	+108.0B
total			+2.4KB

Unknown metric groups

API count

id	before	after	diff
`presentationUtil`	87	91	+4

async chunk count

id	before	after	diff
`apm`	87	86	-1

ESLint disabled line counts

id	before	after	diff
`presentationUtil`	7	6	-1

References to deprecated APIs

id	before	after	diff
`controls`	1	4	+3
`slo`	19	20	+1
`synthetics`	44	46	+2
total			+6

Total ESLint disabled count

id	before	after	diff
`presentationUtil`	7	6	-1

Unreferenced deprecated APIs

id	before	after	diff
`controls`	1	4	+3
`slo`	19	20	+1
`synthetics`	44	46	+2
total			+6

History

💛 Build #440125 was flaky 818c480
💔 Build #440111 failed 00fa8ea
💛 Build #439802 was flaky 2931dd1
💔 Build #439799 failed a047691
💔 Build #439779 failed df58b19
💔 Build #439757 failed 32990f8

…causing flaky add panel test (#268218) Closes #268101 Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/12180 The reason for flaky tests is that plugins are registering actions asynchronously. This introduces a race condition where `ADD_PANEL_TRIGGER` actions may not be registered before Dashboard's "add panel" menu is rendered. PR resolves the race condition by registering embeddables and actions synchronously. PR tries to prevent issue like this from being re-introduced by throwing on embeddable registration after start method is run. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…causing flaky add panel test (elastic#268218) Closes elastic#268101 Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/12180 The reason for flaky tests is that plugins are registering actions asynchronously. This introduces a race condition where `ADD_PANEL_TRIGGER` actions may not be registered before Dashboard's "add panel" menu is rendered. PR resolves the race condition by registering embeddables and actions synchronously. PR tries to prevent issue like this from being re-introduced by throwing on embeddable registration after start method is run. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

nreese added 2 commits May 7, 2026 09:00

[aiops] synchronously register embeddables and actions to fix flaky a…

69ccde4

…dd panel test

unskip test

b8afc16

nreese mentioned this pull request May 7, 2026

unskip add panel flyout tests #267973

Merged

nreese added 2 commits May 7, 2026 09:43

update expects

336c9f5

cleanu

54ba095

nreese commented May 7, 2026

View reviewed changes

log actions

b007923

slo

570d2bb

nreese and others added 4 commits May 7, 2026 12:24

clean up

fd9fae8

Changes from node scripts/eslint_all_files --no-cache --fix

fec79a1

Merge branch 'main' into aiops_sync_registration

66f97b3

revert embeddable check

f39a253

nreese added 4 commits May 7, 2026 13:23

Revert "revert embeddable check"

4e85d9b

This reverts commit f39a253.

registerPanelPlacementSettings

8a479dc

Revert "registerPanelPlacementSettings"

d0ea6b6

This reverts commit 8a479dc.

setup.registerPanelPlacementSettings

4382745

nreese changed the title ~~[aiops] synchronously register embeddables and actions to fix flaky add panel test~~ [aiops][slo] synchronously register embeddables and actions to fix flaky add panel test May 7, 2026

kibanamachine and others added 2 commits May 7, 2026 20:13

Changes from node scripts/eslint_all_files --no-cache --fix

529cd33

remove FTR dashboard_panel_listing.ts

6479db8

nreese commented May 7, 2026

View reviewed changes

sync register links embeddable

2e644a4

async import apm

ab04951

nreese added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.5.0 labels May 8, 2026

baileycash-elastic approved these changes May 8, 2026

View reviewed changes

botelastic Bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation labels May 8, 2026

iblancof approved these changes May 8, 2026

View reviewed changes

nreese added 2 commits May 8, 2026 08:15

merge with main

55e7b81

clean up test

00fa8ea

limits

818c480

nreese requested a review from a team as a code owner May 8, 2026 14:30

nreese commented May 8, 2026

View reviewed changes

rmyz approved these changes May 8, 2026

View reviewed changes

ThomThomson approved these changes May 8, 2026

View reviewed changes

dmlemeshko approved these changes May 8, 2026

View reviewed changes

TamerlanG approved these changes May 10, 2026

View reviewed changes

jgowdyelastic removed the request for review from a team May 11, 2026 08:21

Merge branch 'main' into aiops_sync_registration

4b7ab2b

nreese merged commit dac65d8 into elastic:main May 11, 2026
31 checks passed

Conversation

nreese commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented May 7, 2026

Uh oh!

nreese commented May 7, 2026

Uh oh!

nreese May 7, 2026

Choose a reason for hiding this comment

Uh oh!

nreese commented May 7, 2026

Uh oh!

kibanamachine commented May 7, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#12168

Uh oh!

nreese commented May 7, 2026

Uh oh!

nreese commented May 7, 2026

Uh oh!

nreese commented May 7, 2026

Uh oh!

nreese May 7, 2026

Choose a reason for hiding this comment

Uh oh!

nreese commented May 7, 2026

Uh oh!

kibanamachine commented May 8, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#12180

Uh oh!

infra-vault-gh-plugin-prod Bot commented May 8, 2026

Uh oh!

baileycash-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

infra-vault-gh-plugin-prod Bot commented May 8, 2026

Uh oh!

iblancof left a comment

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic commented May 8, 2026

Uh oh!

nreese commented May 8, 2026

Uh oh!

nreese May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rmyz left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson May 8, 2026

Choose a reason for hiding this comment

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

TamerlanG commented May 10, 2026

Uh oh!

nreese commented May 11, 2026

Uh oh!

kibanamachine commented May 11, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

API count

async chunk count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

Unreferenced deprecated APIs

nreese commented May 7, 2026 •

edited

Loading

nreese May 8, 2026 •

edited

Loading