Fix @elastic/eui/icon-accessibility-rules lint violations across @elastic/ml-ui files#267698
Merged
Merged
Conversation
50 tasks
Add aria-hidden={true} to decorative EuiIcon components that appear next
to text labels or inside cards with titles, making them purely decorative
for screen readers.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Add aria-hidden={true} to decorative EuiIcon components that appear
next to text or serve as visual markers. Add aria-label to the
standalone EuiIcon in job_message_icon.tsx that conveys status meaning
without accompanying text.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
…gin (batch 3)
Add aria-hidden={true} to decorative EuiIcon components that appear
next to text in the ML plugin files.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix eslint violations for @elastic_eui_icon-accessibility-rules
Fix May 5, 2026
@elastic/eui/icon-accessibility-rules lint violations across @elastic/ml-ui files
Contributor
|
/ci |
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
alexwizp
added
a11y:agent-pr
alexwizp
approved these changes
May 5, 2026
peteharverson
approved these changes
May 5, 2026
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
LGTM (code review only).
Contributor
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
alexwizp
approved these changes
May 5, 2026
Contributor
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
auto-merge was automatically disabled
May 5, 2026 18:06
Head branch was pushed to by a user without write access
Contributor
Author
Resolved in Note: The CI failures in the previous build were all in unrelated |
Contributor
|
/ci |
Contributor
|
@elasticmachine run docs-build |
Contributor
|
/ci |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @alexwizp @Copilot |
Contributor
|
Starting backport for target branches: 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/25428106677 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced May 6, 2026
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
that referenced
this pull request
May 8, 2026
…oss `@elastic/ml-ui` files (#267698) (#268430) # Backport This will backport the following commits from `main` to `9.3`: - [Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files (#267698)](#267698) <!--- Backport version: 11.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-05-06T09:47:06Z","message":"Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files (#267698)\n\nResolves 74 ESLint `@elastic/eui/icon-accessibility-rules` violations\nacross 47 files owned by `@elastic/ml-ui`.\n\n## Changes\n\n- Added `aria-hidden={true}` to decorative `EuiIcon` components (icons\nadjacent to text labels)\n- Added `aria-label` where icons convey meaning independently (e.g.,\nstatus indicators)\n\nAffected packages/plugins: `@kbn/aiops-components`, `@kbn/file-upload`,\n`data_visualizer`, `aiops`, `ml`\n\n**Example:**\n```tsx\n// Before\n<EuiIcon type=\"checkCircleFill\" color={euiTheme.colors.success} />\n\n// After\n<EuiIcon aria-hidden={true} type=\"checkCircleFill\" color={euiTheme.colors.success} />\n```\n\n## Checklist\n- [x] Added label `a11y:agent-pr`\n- [x] Fixed all 47 files listed in the issue\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f31bd6dd505e404abfbafbf64a79eac18f8c7896","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport missing","💝community","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.5"],"title":"Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files","number":267698,"url":"https://github.com/elastic/kibana/pull/267698","mergeCommit":{"message":"Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files (#267698)\n\nResolves 74 ESLint `@elastic/eui/icon-accessibility-rules` violations\nacross 47 files owned by `@elastic/ml-ui`.\n\n## Changes\n\n- Added `aria-hidden={true}` to decorative `EuiIcon` components (icons\nadjacent to text labels)\n- Added `aria-label` where icons convey meaning independently (e.g.,\nstatus indicators)\n\nAffected packages/plugins: `@kbn/aiops-components`, `@kbn/file-upload`,\n`data_visualizer`, `aiops`, `ml`\n\n**Example:**\n```tsx\n// Before\n<EuiIcon type=\"checkCircleFill\" color={euiTheme.colors.success} />\n\n// After\n<EuiIcon aria-hidden={true} type=\"checkCircleFill\" color={euiTheme.colors.success} />\n```\n\n## Checklist\n- [x] Added label `a11y:agent-pr`\n- [x] Fixed all 47 files listed in the issue\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f31bd6dd505e404abfbafbf64a79eac18f8c7896"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/267698","number":267698,"mergeCommit":{"message":"Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files (#267698)\n\nResolves 74 ESLint `@elastic/eui/icon-accessibility-rules` violations\nacross 47 files owned by `@elastic/ml-ui`.\n\n## Changes\n\n- Added `aria-hidden={true}` to decorative `EuiIcon` components (icons\nadjacent to text labels)\n- Added `aria-label` where icons convey meaning independently (e.g.,\nstatus indicators)\n\nAffected packages/plugins: `@kbn/aiops-components`, `@kbn/file-upload`,\n`data_visualizer`, `aiops`, `ml`\n\n**Example:**\n```tsx\n// Before\n<EuiIcon type=\"checkCircleFill\" color={euiTheme.colors.success} />\n\n// After\n<EuiIcon aria-hidden={true} type=\"checkCircleFill\" color={euiTheme.colors.success} />\n```\n\n## Checklist\n- [x] Added label `a11y:agent-pr`\n- [x] Fixed all 47 files listed in the issue\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f31bd6dd505e404abfbafbf64a79eac18f8c7896"}},{"branch":"9.3","label":"v9.3.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
May 8, 2026
…oss `@elastic/ml-ui` files (#267698) (#268429) # Backport This will backport the following commits from `main` to `9.4`: - [Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files (#267698)](#267698) <!--- Backport version: 11.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-05-06T09:47:06Z","message":"Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files (#267698)\n\nResolves 74 ESLint `@elastic/eui/icon-accessibility-rules` violations\nacross 47 files owned by `@elastic/ml-ui`.\n\n## Changes\n\n- Added `aria-hidden={true}` to decorative `EuiIcon` components (icons\nadjacent to text labels)\n- Added `aria-label` where icons convey meaning independently (e.g.,\nstatus indicators)\n\nAffected packages/plugins: `@kbn/aiops-components`, `@kbn/file-upload`,\n`data_visualizer`, `aiops`, `ml`\n\n**Example:**\n```tsx\n// Before\n<EuiIcon type=\"checkCircleFill\" color={euiTheme.colors.success} />\n\n// After\n<EuiIcon aria-hidden={true} type=\"checkCircleFill\" color={euiTheme.colors.success} />\n```\n\n## Checklist\n- [x] Added label `a11y:agent-pr`\n- [x] Fixed all 47 files listed in the issue\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f31bd6dd505e404abfbafbf64a79eac18f8c7896","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport missing","💝community","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.5"],"title":"Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files","number":267698,"url":"https://github.com/elastic/kibana/pull/267698","mergeCommit":{"message":"Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files (#267698)\n\nResolves 74 ESLint `@elastic/eui/icon-accessibility-rules` violations\nacross 47 files owned by `@elastic/ml-ui`.\n\n## Changes\n\n- Added `aria-hidden={true}` to decorative `EuiIcon` components (icons\nadjacent to text labels)\n- Added `aria-label` where icons convey meaning independently (e.g.,\nstatus indicators)\n\nAffected packages/plugins: `@kbn/aiops-components`, `@kbn/file-upload`,\n`data_visualizer`, `aiops`, `ml`\n\n**Example:**\n```tsx\n// Before\n<EuiIcon type=\"checkCircleFill\" color={euiTheme.colors.success} />\n\n// After\n<EuiIcon aria-hidden={true} type=\"checkCircleFill\" color={euiTheme.colors.success} />\n```\n\n## Checklist\n- [x] Added label `a11y:agent-pr`\n- [x] Fixed all 47 files listed in the issue\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f31bd6dd505e404abfbafbf64a79eac18f8c7896"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/267698","number":267698,"mergeCommit":{"message":"Fix `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/ml-ui` files (#267698)\n\nResolves 74 ESLint `@elastic/eui/icon-accessibility-rules` violations\nacross 47 files owned by `@elastic/ml-ui`.\n\n## Changes\n\n- Added `aria-hidden={true}` to decorative `EuiIcon` components (icons\nadjacent to text labels)\n- Added `aria-label` where icons convey meaning independently (e.g.,\nstatus indicators)\n\nAffected packages/plugins: `@kbn/aiops-components`, `@kbn/file-upload`,\n`data_visualizer`, `aiops`, `ml`\n\n**Example:**\n```tsx\n// Before\n<EuiIcon type=\"checkCircleFill\" color={euiTheme.colors.success} />\n\n// After\n<EuiIcon aria-hidden={true} type=\"checkCircleFill\" color={euiTheme.colors.success} />\n```\n\n## Checklist\n- [x] Added label `a11y:agent-pr`\n- [x] Fixed all 47 files listed in the issue\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f31bd6dd505e404abfbafbf64a79eac18f8c7896"}},{"branch":"9.3","label":"v9.3.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
kibanamachine
added
v9.4.1
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 74 ESLint
@elastic/eui/icon-accessibility-rulesviolations across 47 files owned by@elastic/ml-ui.Changes
aria-hidden={true}to decorativeEuiIconcomponents (icons adjacent to text labels)aria-labelwhere icons convey meaning independently (e.g., status indicators)Affected packages/plugins:
@kbn/aiops-components,@kbn/file-upload,data_visualizer,aiops,mlExample:
Checklist
a11y:agent-pr