Skip to content

Add accessible name to model selection popover (WCAG 4.1.2)#267622

Merged
bhavyarm merged 4 commits into
mainfrom
copilot/fix-model-selection-dialog-announcement
May 6, 2026
Merged

Add accessible name to model selection popover (WCAG 4.1.2)#267622
bhavyarm merged 4 commits into
mainfrom
copilot/fix-model-selection-dialog-announcement

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026 •
edited by kibanamachine
Loading

Screen readers announce the model selection popover on Feature settings as generic "dialog" rather than identifying its purpose.

Changes

  • Add aria-label="Model selection" to EuiPopover in AddModelPopover component
  • Add test verifying dialog has accessible name
<EuiPopover
  aria-label={i18n.translate('xpack.searchInferenceEndpoints.settings.addModel.ariaLabel', {
    defaultMessage: 'Model selection',
  })}
  button={...}
>

Addresses WCAG 4.1.2 (Name, Role, Value - Level A).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • ci-stats.kibana.dev
    • Triggering command: /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2 &gt; b[i]) exit(0) (dns block)
    • Triggering command: /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node scripts/kbn bootstrap --no-force-install (dns block)
  • clients3.google.com
    • Triggering command: /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2 if (a[i] &lt; (dns block)
  • detectportal.firefox.com
    • Triggering command: /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2 if (a[i] &lt; (dns block)
  • google.com
    • Triggering command: /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.8.2 if (a[i] &lt; (dns block)
  • googlechromelabs.github.io
    • Triggering command: /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node /home/REDACTED/.nvm/versions/node/v24.14.1/bin/node install.js dd ldd b/li�� nibrowser-gtk/sys/lib/libbrotlienc.so.1.0.7 (dns block)
  • iojs.org
    • Triggering command: /usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o - (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 4, 2026 that may be closed by this pull request
[Platform:Management:StackManagement:ModelManagement:FeatureSettings] Model selection input is announced as generic dialog after user clicks on Add a model on Feature settings page #267621
Closed
@bhavyarm
Add aria-label to model selection popover for accessibility
6c9acbb 
Agent-Logs-Url: https://github.com/elastic/kibana/sessions/dc2f02e8-9fb4-4c22-ae93-f3f160faaa2b

Co-authored-by: bhavyarm <7074629+bhavyarm@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix model selection input announcement for screen readers Add accessible name to model selection popover (WCAG 4.1.2) May 4, 2026
Copilot AI requested a review from bhavyarm May 4, 2026 22:44
@bhavyarm
Copy link
Copy Markdown
Contributor

bhavyarm commented May 5, 2026

/ci

@bhavyarm
Copy link
Copy Markdown
Contributor

bhavyarm commented May 5, 2026

@elasticmachine run docs-build

@bhavyarm bhavyarm added Project:Accessibility a11y:agent-pr PR has been created by the agent release_note:skip Skip the PR/issue when compiling release notes v9.5.0 backport:all-open Backport to all branches that could still receive a release labels May 5, 2026
@bhavyarm bhavyarm marked this pull request as ready for review May 6, 2026 14:41
@bhavyarm bhavyarm requested a review from a team as a code owner May 6, 2026 14:41
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

infra-vault-gh-plugin-prod Bot commented May 6, 2026

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm
Copy link
Copy Markdown
Contributor

bhavyarm commented May 6, 2026

/ci

@bhavyarm
Copy link
Copy Markdown
Contributor

bhavyarm commented May 6, 2026

@elasticmachine run docs-build

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 6, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchInferenceEndpoints 222.5KB 222.6KB +127.0B

History

cc @bhavyarm @Copilot

@bhavyarm bhavyarm added v9.3.5 v9.4.1 and removed backport:all-open Backport to all branches that could still receive a release labels May 6, 2026
@bhavyarm bhavyarm added the backport:version Backport to applied version labels label May 6, 2026
@bhavyarm bhavyarm merged commit e100b2c into main May 6, 2026
79 checks passed
@bhavyarm bhavyarm deleted the copilot/fix-model-selection-dialog-announcement branch May 6, 2026 16:38
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 6, 2026

Starting backport for target branches: 9.3, 9.4

https://github.com/elastic/kibana/actions/runs/25448322104

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 6, 2026

💔 All backports failed

Status Branch Result
❌ 9.3 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.3:
- Speed up telemetry check by sharing a single TS program across roots !! (#267651)
- test: Fix flaky service map Scout accessibility test (#267960)
- Fix @elastic/eui/icon-accessibility-rules lint violations across @elastic/ml-ui files (#267698)
❌ 9.4 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

node scripts/backport --pr 267622

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request May 6, 2026
Merged
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request May 6, 2026
@ersin-erdal
Add accessible name to model selection popover (WCAG 4.1.2) (elastic#…
3f33b79 
…267622)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 8, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 8, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 267622 locally
cc: @bhavyarm

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 11, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 267622 locally
cc: @bhavyarm

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 12, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 267622 locally
cc: @bhavyarm

@alexwizp alexwizp mentioned this pull request May 13, 2026
Merged
@alexwizp alexwizp removed the v9.3.5 label May 13, 2026
@alexwizp
Copy link
Copy Markdown
Contributor

alexwizp commented May 13, 2026

💔 Some backports could not be created

Status Branch Result
✅ 9.4
❌ 9.3 Conflict resolution was aborted by the user

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 267622

Questions ?

Please refer to the Backport tool documentation

alexwizp added a commit that referenced this pull request May 13, 2026
@alexwizp
[9.4] Add accessible name to model selection popover (WCAG 4.1.2) (#2…
dd7ef47 
…67622) (#269044)

# Backport

This will backport the following commits from `main` to `9.4`:
- [Add accessible name to model selection popover (WCAG 4.1.2)
(#267622)](#267622)

<!--- Backport version: 11.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-05-06T16:38:14Z","message":"Add
accessible name to model selection popover (WCAG 4.1.2)
(#267622)","sha":"e100b2ca63c119367b8ac39029e8a5db340d558d","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport
missing","💝community","backport:version","a11y:agent-pr","v9.5.0","v9.3.5","v9.4.1"],"title":"Add
accessible name to model selection popover (WCAG
4.1.2)","number":267622,"url":"https://github.com/elastic/kibana/pull/267622","mergeCommit":{"message":"Add
accessible name to model selection popover (WCAG 4.1.2)
(#267622)","sha":"e100b2ca63c119367b8ac39029e8a5db340d558d"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.4"],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/267622","number":267622,"mergeCommit":{"message":"Add
accessible name to model selection popover (WCAG 4.1.2)
(#267622)","sha":"e100b2ca63c119367b8ac39029e8a5db340d558d"}},{"branch":"9.3","label":"v9.3.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.4","label":"v9.4.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
@kibanamachine kibanamachine added v9.4.2 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tutelaris tutelaris tutelaris approved these changes

+1 more reviewer

@bhavyarm bhavyarm bhavyarm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bhavyarm bhavyarm

Copilot code review Copilot

Labels

a11y:agent-pr PR has been created by the agent backport:version Backport to applied version labels 💝community Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v9.4.1 v9.4.2 v9.5.0

Projects

None yet

Milestone

No milestone

5 participants

@bhavyarm @kibanamachine @alexwizp @tutelaris