[9.4] Fix @elastic/eui/icon-accessibility-rules lint violations across @elastic/ml-ui files (#267698)#268429
Merged
Merged
Conversation
…elastic/ml-ui` files (elastic#267698) Resolves 74 ESLint `@elastic/eui/icon-accessibility-rules` violations across 47 files owned by `@elastic/ml-ui`. ## Changes - Added `aria-hidden={true}` to decorative `EuiIcon` components (icons adjacent to text labels) - Added `aria-label` where icons convey meaning independently (e.g., status indicators) Affected packages/plugins: `@kbn/aiops-components`, `@kbn/file-upload`, `data_visualizer`, `aiops`, `ml` **Example:** ```tsx // Before <EuiIcon type="checkCircleFill" color={euiTheme.colors.success} /> // After <EuiIcon aria-hidden={true} type="checkCircleFill" color={euiTheme.colors.success} /> ``` ## Checklist - [x] Added label `a11y:agent-pr` - [x] Fixed all 47 files listed in the issue --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit f31bd6d) # Conflicts: # x-pack/platform/plugins/shared/ml/public/application/components/job_message_icon/job_message_icon.tsx
Merged
2 tasks
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:@elastic/eui/icon-accessibility-ruleslint violations across@elastic/ml-uifiles (#267698)Questions ?
Please refer to the Backport tool documentation