test: Fix flaky service map Scout accessibility test by jennypavlova · Pull Request #267960 · elastic/kibana

jennypavlova · 2026-05-06T12:16:03Z

Summary

Fixes the Scout failure tracked in #262609: service_map_a11y.spec.ts expected toBeFocused() on the service circle after typing in find-in-page. Focusing the node blurs the find field; search highlights are intentionally cleared when the find input loses focus (isFocused), which led to unstable focus/DOM during the assertion.
Separates node focus + focus ring from find-in-page: focus the circle without opening find first; cover find in its own step (focusBodyForMapShortcuts, ⌃K, fill, match summary, Enter to center, settle).
expect(locator).toBeVisible() on serviceMapNodeSearchHighlightFrame failed even when the counter showed 1/1 because highlight context only updates when React treats the field as focused. fill() on data-test-subj="serviceMapControlsSearch" targets the layout wrapper; the native input may receive keystrokes without reliably firing EuiFieldSearch onFocus, so isFocused stayed false and serviceMapNodeSearchHighlightFrame never rendered. The test now fills and sends Enter via #serviceMapFindInPageInput (same element as focusServiceMapFindInput()).
Resolves the highlight frame from the service node root with an XPath ancestor to [data-test-subj="serviceMapNodeSearchHighlightFrame"].
Asserts the highlight before Enter where possible: map centering can steal focus and clear highlights per existing product behavior.

References

Made with Cursor

Split focus checks from find-in-page flow; drive fill and Enter via `#serviceMapFindInPageInput` so React `isFocused` updates highlight context. Assert `serviceMapNodeSearchHighlightFrame` before Enter while the find field stays focused. Closes elastic#262609 Co-authored-by: Cursor <cursoragent@cursor.com>

infra-vault-gh-plugin-prod · 2026-05-06T12:16:07Z

Pinging @elastic/obs-presentation-team (Team:obs-presentation)

jennypavlova · 2026-05-06T12:19:14Z

Catch flakiness early (recommended): this PR changes APM Scout UI specs and page objects for the service map; running the flaky test runner validates timing/focus paths beyond a single CI pass.

Trigger via Flaky Test Runner UI or:

/flaky scoutConfig:x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts:30

kibanamachine · 2026-05-06T13:13:18Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 5a872a8

Failed CI Steps

x-pack/platform/test/serverless/functional/configs/observability/config.group1.ts

Metrics [docs]

✅ unchanged

jennypavlova · 2026-05-06T14:14:24Z

/flaky scoutConfig:x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts:30

kibanamachine · 2026-05-06T14:14:50Z

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#12138

x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts x30

sbelastic

LGTM

kibanamachine · 2026-05-06T14:44:47Z

Starting backport for target branches: 9.3, 9.4

https://github.com/elastic/kibana/actions/runs/25442414603

kibanamachine · 2026-05-06T14:54:09Z

💔 All backports failed

Status	Branch	Result
❌	9.3	Backport failed because of merge conflicts
❌	9.4	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 267960

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2026-05-06T15:24:37Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#12138

[✅] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts (--arch stateful --domain classic): 30/30 tests passed.
[✅] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain observability_complete): 30/30 tests passed.

see run history

## Summary - Fixes the Scout failure tracked in [elastic#262609](elastic#262609): `service_map_a11y.spec.ts` expected `toBeFocused()` on the service circle **after** typing in find-in-page. Focusing the node blurs the find field; search highlights are intentionally cleared when the find input loses focus (`isFocused`), which led to unstable focus/DOM during the assertion. - Separates **node focus + focus ring** from **find-in-page**: focus the circle without opening find first; cover find in its own step (`focusBodyForMapShortcuts`, ⌃K, fill, match summary, Enter to center, settle). - **`expect(locator).toBeVisible()` on `serviceMapNodeSearchHighlightFrame` failed** even when the counter showed `1/1` because highlight context only updates when React treats the field as focused. `fill()` on `data-test-subj="serviceMapControlsSearch"` targets the **layout wrapper**; the native input may receive keystrokes without reliably firing `EuiFieldSearch` `onFocus`, so `isFocused` stayed false and **`serviceMapNodeSearchHighlightFrame` never rendered**. The test now fills and sends Enter via **`#serviceMapFindInPageInput`** (same element as `focusServiceMapFindInput()`). - Resolves the highlight frame from the service node root with an XPath ancestor to `[data-test-subj="serviceMapNodeSearchHighlightFrame"]`. - Asserts the highlight **before** Enter where possible: map centering can steal focus and clear highlights per existing product behavior. ## References Closes elastic#262609 Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <cursoragent@cursor.com>

kibanamachine · 2026-05-07T14:48:58Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 267960 locally
cc: @jennypavlova

kibanamachine · 2026-05-08T14:49:14Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 267960 locally
cc: @jennypavlova

jennypavlova · 2026-05-11T12:06:12Z

💚 All backports created successfully

Status	Branch	Result
✅	9.4
✅	9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2026-05-12T12:48:50Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @jennypavlova

kibanamachine · 2026-05-13T12:49:11Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @jennypavlova

kibanamachine · 2026-05-14T12:49:40Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @jennypavlova

kibanamachine · 2026-05-15T13:49:27Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @jennypavlova

jennypavlova requested a review from a team as a code owner May 6, 2026 12:16

jennypavlova added the release_note:skip Skip the PR/issue when compiling release notes label May 6, 2026

jennypavlova requested a review from a team as a code owner May 6, 2026 12:16

jennypavlova added backport:version Backport to applied version labels v9.3.0 v9.4.0 Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation release_note:skip Skip the PR/issue when compiling release notes labels May 6, 2026

sbelastic approved these changes May 6, 2026

View reviewed changes

jennypavlova merged commit 7dfcaed into elastic:main May 6, 2026
174 of 187 checks passed

kibanamachine added the v9.5.0 label May 6, 2026

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 7, 2026

github-actions Bot mentioned this pull request May 8, 2026

Failing test: Service map - accessibility - focus management and visible indicators work correctly #262609

Open

This was referenced May 11, 2026

[9.4] test: Fix flaky service map Scout accessibility test (#267960) #268667

Open

[9.3] test: Fix flaky service map Scout accessibility test (#267960) #268668

Closed

jennypavlova removed the v9.3.0 label May 11, 2026

Conversation

jennypavlova commented May 6, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

References

Uh oh!

infra-vault-gh-plugin-prod Bot commented May 6, 2026

Uh oh!

jennypavlova commented May 6, 2026

Uh oh!

kibanamachine commented May 6, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Uh oh!

jennypavlova commented May 6, 2026

Uh oh!

kibanamachine commented May 6, 2026

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#12138

Uh oh!

sbelastic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented May 6, 2026

Uh oh!

kibanamachine commented May 6, 2026

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented May 6, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#12138

Uh oh!

kibanamachine commented May 7, 2026

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

jennypavlova commented May 11, 2026

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented May 12, 2026

Uh oh!

kibanamachine commented May 13, 2026

Uh oh!

kibanamachine commented May 14, 2026

Uh oh!

kibanamachine commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jennypavlova commented May 6, 2026 •

edited by kibanamachine

Loading