Closed
Conversation
lukasolson
added
review
Feature:Discover
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
Contributor
|
Closing in favour of #26609 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26571.
Fixes the Discover histogram so that clicking on bars/brushing works again, and adds functional tests for this behavior.
This behavior was (I believe) introduced in #25280. Since Discover doesn't use the
EmbeddedVisualizeHandlerwhich is currently responsible for creating theeventsSubjectthat gets used in the event handlers, this caused problems in Discover since we weren't manually creating this variable.This is probably a hacky solution for now which is why I'd like to get feedback particularly from @timroes and @ppisljar on the appropriate solution after #25280.