changing vis.API.events

[ppisljar]

Summary

Moves filtering functions out of Vis.

preparation for #23185

QA: no functional canges

Dev-Docs

filtering inside your visualization will need to be updated

vis.API.events.addFilter no longer exists, instead you should rather call vis.API.events.filter({ table, column, row, value })

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• [ ] This was checked for cross-browser compatibility, including a check against IE11
• [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
• [ ] Documentation was added for features that require explanation or tutorials
• [ ] Unit or functional tests were updated or added to match the most common scenarios
• [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

Pinging @elastic/kibana-app

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[markov00]

Code LGTM. Some minor comments.
Tested on chrome/osx using brushes and filters

[markov00]

nit: Can we remove this visualization default? We already have a check on opts thats trows an exception if visualization is a falsy value.

What about checking if the visualization object has the required methods?

[ppisljar]

no idea why this shows as added code .... it was just indented

[markov00]

nit: What about having the stage default as lab, so we don't accidentally create a production vis?

[ppisljar]

no idea why this shows as added code .... it was just indented

[markov00]

nit: What about move these strings to an enum similar to:

const STAGE_TYPES = {
  LAB: 'lab',
  EXPERIMENTAL: 'experimental',
  PRODUCTION: 'production',
}

[ppisljar]

no idea why this shows as added code .... it was just indented

[markov00]

q: do we enforce actions to be functions somewhere?

[ppisljar]

we don't, we need to better type this

[markov00]

I'm a bit confused what is the right one, this:

vis.API.events.addFilter no longer exists, instead you should rather call vis.API.events.filter({ table, column, row, value })

or

the filter method will be removed in the near feature you should rather use addFilter method below

[ppisljar]

ha :) i need to remove that comment

[markov00]

nit: Is there a reason to use arrow function here? can't we use named functions?

[ppisljar]

is there a reason not to use arrow functions ?

[markov00]

touché

[markov00]

nit: can we get rid of lodash here? Object.keys(this.vis.type.events).forEach

[markov00]

To naming this consistently it's better to rewrite this as:

filter: data => this.eventsSubject.next({ name: 'filterBucket', data }),
brush: data => this.eventsSubject.next({ name: 'brush', data }),

So your event is an object with {name, data} as it's used on the subscriptions

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[lukeelmers]

Code LGTM. Pulled down and tested, no apparent functional issues.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request