Merged
Conversation
ppisljar
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
Contributor
|
This looks like it's already fixed via #26600. So maybe sync up with @lukasolson which would be the better solution. |
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
fix/discoverHistogram
branch
from
01a4f88 to
b5e2e71
Compare
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
fix/discoverHistogram
branch
from
fbd82ba to
e54de2f
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
markov00
approved these changes
Dec 4, 2018
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Code LGTM. Tested on chrome and how brushing works correctly.
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Dec 4, 2018
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Dec 4, 2018
# Conflicts: # src/legacy/core_plugins/kibana/public/discover/controllers/discover.js # src/legacy/core_plugins/kibana/public/discover/index.html # src/ui/public/visualize/loader/embedded_visualize_handler.ts
ppisljar
added a commit
that referenced
this pull request
Dec 4, 2018
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Dec 4, 2018
# Conflicts: # src/legacy/core_plugins/kibana/public/discover/controllers/discover.js # src/legacy/core_plugins/kibana/public/discover/index.html # src/ui/public/visualize/loader/embedded_visualize_handler.ts
ppisljar
added a commit
that referenced
this pull request
Dec 4, 2018
|
Nice tests! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26571.
Fixes the Discover histogram so that clicking on bars/brushing works again, and adds functional tests for this behavior.
uses visualizeLoader in discover to load visualization:
autoFetchwas added to visualizeLoader params, setting it to true won't auto fetch the dataChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately