Skip to content

[Search][Telemetry] Add data-test-subj eslint check missing Search plugins#265004

Merged
efegurkan merged 3 commits intoelastic:mainfrom
efegurkan:telemetry-plugin-config-connectors-inference
Apr 28, 2026
Merged

[Search][Telemetry] Add data-test-subj eslint check missing Search plugins#265004
efegurkan merged 3 commits intoelastic:mainfrom
efegurkan:telemetry-plugin-config-connectors-inference

Conversation

@efegurkan
Copy link
Copy Markdown
Member

@efegurkan efegurkan commented Apr 22, 2026

Summary

Adds ESLint config for telemetry check in missing Search plugins.

Checklist

Check the PR satisfies following conditions.

Created with Claude Code instructed by @efegurkan

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@efegurkan efegurkan requested review from a team as code owners April 22, 2026 11:24
@efegurkan efegurkan added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Apr 22, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
contentConnectors 473.8KB 475.4KB +1.6KB
searchInferenceEndpoints 214.9KB 215.5KB +617.0B
total +2.2KB

@efegurkan
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@efegurkan
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
contentConnectors 473.8KB 475.4KB +1.6KB
searchInferenceEndpoints 215.8KB 216.4KB +617.0B
total +2.2KB

Copy link
Copy Markdown
Contributor

@seialkali seialkali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be nitpicky, but some of these names are quite long (e.g., searchInferenceEndpointsElasticInferenceServiceModelsHeaderViewCloudUsageButton at 79 characters) and become difficult to parse at a glance.

Is the general consensus that readability for these IDs isn't a concern as long as they're unique? If so, I'm happy to approve.

@sphilipse
Copy link
Copy Markdown
Member

This may be nitpicky, but some of these names are quite long (e.g., searchInferenceEndpointsElasticInferenceServiceModelsHeaderViewCloudUsageButton at 79 characters) and become difficult to parse at a glance.

Is the general consensus that readability for these IDs isn't a concern as long as they're unique? If so, I'm happy to approve.

Yup, readability doesn't matter :)

Copy link
Copy Markdown
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efegurkan
Copy link
Copy Markdown
Member Author

Names are autogenerated most of the time, and readability is not important as long as they are unique they are fine.

@efegurkan efegurkan merged commit e4bc92e into elastic:main Apr 28, 2026
19 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19, 9.2, 9.3, 9.4

https://github.com/elastic/kibana/actions/runs/25046244045

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.2 Backport failed because of merge conflicts
9.3 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.3:
- Add announceOnMount to conditionally rendered EuiCallOut components (#265724)
- [Security GenAI] Use stable IDs for Security AI Prompt saved object filenames (#265301)
- Fix to the jest test - FilterLabel should render properly (#265750)
9.4 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.4:
- auto-implement: Labels in model endpoints table of the model details flyout look misaligned (#263770)

Manual backport

To create the backport manually run:

node scripts/backport --pr 265004

Questions ?

Please refer to the Backport tool documentation

smith pushed a commit to smith/kibana that referenced this pull request Apr 28, 2026
…ugins (elastic#265004)

## Summary
Adds ESLint config for telemetry check in missing Search plugins.

### Checklist

Check the PR satisfies following conditions. 

Created with Claude Code instructed by @efegurkan

Reviewers should verify this PR satisfies this list as well.

- [ ] ~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] ~[Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed~
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 29, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265004 locally
cc: @efegurkan

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265004 locally
cc: @efegurkan

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265004 locally
cc: @efegurkan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release backport missing Added to PRs automatically when the are determined to be missing a backport. release_note:skip Skip the PR/issue when compiling release notes v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants