Fix to the jest test - FilterLabel should render properly#265750
Fix to the jest test - FilterLabel should render properly#265750ana-davydova merged 1 commit intoelastic:mainfrom
Conversation
ApprovabilityVerdict: Would Approve Test-only changes that re-enable a previously skipped test and refactor assertions to use idiomatic testing-library patterns. No runtime code is affected, and the author is the designated code owner of the modified file. Macroscope would have approved this PR. A repo admin can enable approvability here. |
💚 Build Succeeded
Metrics [docs]
|
|
I was working on a failing test for this same plugin and component a few weeks ago. I couldn't make it fail locally nor in the CI: #253605 I also tried increasing the timeout but that didn't work either. Just a heads-up that this one may fail too when merged to main (hope not!), so we should keep an eye on it once it's merged @ana-davydova |
miguelmartin-elastic
left a comment
There was a problem hiding this comment.
See comment above 😃
|
Starting backport for target branches: 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/25001083411 |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
4 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Resolves #253320
This is a follow-up to #262207.
Fix
Three changes to filter_label.test.tsx:
jest.setTimeout(10 * 1000)→jest.setTimeout(30 * 1000)— gives enough headroom on stressed CI agents.waitFor(() => getByText(...))withawait screen.findByText(...)— copies the pattern used by the non-flakyshould display invert filtersibling test.Verification
Buildkite flaky-test-runner doesn't cover jest tests, so local runs are the only option.
Made with Claude.