Skip to content

Fix to the jest test - FilterLabel should render properly#265750

Merged
ana-davydova merged 1 commit intoelastic:mainfrom
ana-davydova:fix-failing-jest-filterlabel-253320
Apr 27, 2026
Merged

Fix to the jest test - FilterLabel should render properly#265750
ana-davydova merged 1 commit intoelastic:mainfrom
ana-davydova:fix-failing-jest-filterlabel-253320

Conversation

@ana-davydova
Copy link
Copy Markdown
Contributor

@ana-davydova ana-davydova commented Apr 27, 2026

Resolves #253320

This is a follow-up to #262207.

Fix

Three changes to filter_label.test.tsx:

  1. jest.setTimeout(10 * 1000)jest.setTimeout(30 * 1000) — gives enough headroom on stressed CI agents.
  2. Replaced waitFor(() => getByText(...)) with await screen.findByText(...) — copies the pattern used by the non-flaky should display invert filter sibling test.
  3. Re-enabled the suite.

Verification

  • 155/155 consecutive local runs pass, 0 failures.
    Buildkite flaky-test-runner doesn't cover jest tests, so local runs are the only option.

Made with Claude.

@ana-davydova ana-davydova requested a review from a team as a code owner April 27, 2026 11:46
@github-actions github-actions Bot added the author:actionable-obs PRs authored by the actionable obs team label Apr 27, 2026
@ana-davydova ana-davydova added backport:version Backport to applied version labels v9.3.0 v9.4.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 27, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 27, 2026

Approvability

Verdict: Would Approve

Test-only changes that re-enable a previously skipped test and refactor assertions to use idiomatic testing-library patterns. No runtime code is affected, and the author is the designated code owner of the modified file.

Macroscope would have approved this PR. A repo admin can enable approvability here.

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@miguelmartin-elastic
Copy link
Copy Markdown
Contributor

I was working on a failing test for this same plugin and component a few weeks ago. I couldn't make it fail locally nor in the CI: #253605

I also tried increasing the timeout but that didn't work either. Just a heads-up that this one may fail too when merged to main (hope not!), so we should keep an eye on it once it's merged @ana-davydova

Copy link
Copy Markdown
Contributor

@miguelmartin-elastic miguelmartin-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above 😃

@ana-davydova ana-davydova merged commit 45c4cd9 into elastic:main Apr 27, 2026
33 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.3, 9.4

https://github.com/elastic/kibana/actions/runs/25001083411

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
9.3
9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 28, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @ana-davydova

4 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @ana-davydova

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @ana-davydova

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @ana-davydova

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @ana-davydova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:actionable-obs PRs authored by the actionable obs team backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.3.0 v9.4.0 v9.5.0

Projects

None yet

3 participants