[Sig Events] Per-step connector overrides for onboarding and insights discovery by cesco-f · Pull Request #261588 · elastic/kibana

cesco-f · 2026-04-07T15:14:52Z

Summary

Replaces the single "Onboard Streams" button with a unified split button that supports configurable onboarding: users can select which steps to run (KI Features, KI Queries, or both) and pick different connectors for each step via a popover.
Adds a connector override popover to the "Discover Significant Events" button, allowing users to temporarily override the LLM connector used for insights discovery (sticky for the session, not persisted).
Restores the 12-hour features identification recency check (removed in [Sig Events] Unified KIs table in Stream details UI [Sig Events] Unified KIs table in Stream details UI #259553), conditionally bypassed when the user explicitly runs only the features identification step.
Adds per-step connector overrides end-to-end: the onboarding and insights discovery routes, task params, and task runners now accept optional connector overrides, falling back to resolveConnectorForFeature() when no override is provided.
Disables table row selection for streams that have an onboarding task in progress, preventing duplicate scheduling.
Renames "Knowledge Indicators" / "Queries" column headers to "KI Features" / "KI Queries" for consistency across all UI strings.

Screen.Recording.2026-04-08.at.14.26.20.mov

.../components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx

...ig_events/significant_events_discovery/components/streams_view/onboarding_config_popover.tsx

cesco-f · 2026-04-07T15:47:56Z

@coderabbitai full review

cesco-f · 2026-04-07T15:48:00Z

/ci

coderabbitai · 2026-04-07T15:48:03Z

✅ Actions performed

Full review triggered.

coderabbitai · 2026-04-07T16:18:04Z

✅ Actions performed

Full review triggered.

coderabbitai · 2026-04-07T16:34:09Z

Caution

Review failed

The head commit changed during the review from d41dadb to 486bf5d.

📝 Walkthrough

Walkthrough

Extended task definitions (significant_events_queries_generation, features_identification, onboarding) and the onboarding route to accept optional connectorId or connectors parameters. Task runners use these overrides when provided, otherwise fall back to connector resolution. Task completion and failure payloads now include connector IDs. Added a new OnboardingConfigPopover React component for managing onboarding steps and connector selection. Introduced useInferenceFeatureConnectors hook to fetch connectors by feature ID. Updated the onboarding API hook to accept optional steps and connectors in scheduling options.

Possibly related PRs

[SigEvents] Add model setting tab #257678 — Modifies connector handling in the same significant-events task and route files, but removes connectorId from params and replaces it with runtime resolution via modelSettingsClient instead.

Suggested labels

v9.4.0

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@x-pack/platform/plugins/shared/streams_app/public/components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx`:
- Around line 92-110: The effect currently backfills onboardingConfig.connectors
with resolved defaults (via setOnboardingConfig in the useEffect), which removes
the ability to represent "no override"; remove this automatic write so
connectors remains empty unless the user explicitly chooses one. Specifically,
stop updating onboardingConfig.connectors inside the useEffect that watches
featuresConnectors.resolvedConnector and queriesConnectors.resolvedConnector (or
change it to update a separate transient defaults object rather than calling
setOnboardingConfig), and ensure any request/serialization logic reads resolved
defaults at request time when onboardingConfig.connectors.features/queries is
undefined rather than writing those defaults into onboardingConfig; keep the
initial connectors = {} and only call setOnboardingConfig to set connectors when
a user action selects an override.

In
`@x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts`:
- Around line 118-142: The current freshness check around areFeaturesUpToDate
allows reusing a recent features-identification task even when the current run
passed a different connectors.features override; update the logic so the reuse
is disabled whenever a connector override is present or make areFeaturesUpToDate
consider connector identity. Concretely, modify the branch around
areFeaturesUpToDate(...) to either (a) call areFeaturesUpToDate with an
additional connectorId argument (connectors?.features) and have that function
verify the stored task used the same connector, or (b) add an explicit guard
that if connectors?.features is set then skip reuse and always call
scheduleFeaturesIdentificationTask(...) and waitForSubtask(...); reference
functions: areFeaturesUpToDate, scheduleFeaturesIdentificationTask,
waitForSubtask and symbol connectors.features and featuresTaskId.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4ef04eae-80f4-40b3-9342-2781634367e8

📥 Commits

Reviewing files that changed from the base of the PR and between aa68f24 and d41dadb.

📒 Files selected for processing (9)

x-pack/platform/plugins/shared/streams/server/lib/sig_events/tasks/significant_events_queries_generation.ts
x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/features_identification/index.ts
x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts
x-pack/platform/plugins/shared/streams/server/routes/internal/streams/onboarding/route.ts
x-pack/platform/plugins/shared/streams_app/public/components/sig_events/significant_events_discovery/components/streams_view/onboarding_config_popover.tsx
x-pack/platform/plugins/shared/streams_app/public/components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx
x-pack/platform/plugins/shared/streams_app/public/components/sig_events/significant_events_discovery/components/streams_view/translations.ts
x-pack/platform/plugins/shared/streams_app/public/hooks/sig_events/use_inference_feature_connectors.ts
x-pack/platform/plugins/shared/streams_app/public/hooks/use_onboarding_api.ts

.../components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx

x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts

coderabbitai · 2026-04-07T16:48:03Z

✅ Actions performed

Full review triggered.

coderabbitai · 2026-04-07T17:04:17Z

📝 Walkthrough

Walkthrough

This change introduces optional per-step connector override capabilities to the streams onboarding workflow. On the server side, three task types—SignificantEventsQueriesGeneration, FeaturesIdentification, and Onboarding—now accept optional connectorId fields in their parameters. Each task resolves the connector by checking for an override first, then falling back to runtime resolution. The onboarding route endpoint now accepts optional connectors input (with features and queries identifiers), which threads through to task scheduling. On the client side, a new popover component enables users to select which onboarding steps to run and configure step-specific connectors, backed by a new hook that fetches available inference connectors. The onboarding flow also adds a 12-hour recency check to optionally reuse previously completed features identification tasks.

Possibly related PRs

[SigEvents] Add model setting tab #257678: Modifies the same task and route interfaces for connector handling in Significant Events tasks but takes the opposite approach—removing connectorId from parameters and resolving it at runtime via model settings.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts`:
- Around line 60-80: areFeaturesUpToDate currently only checks task status and
recency and must also verify the features connector matches the currently
selected connector; change the areFeaturesUpToDate signature to accept the
expected features connector (or expected connectors object), then after fetching
featuresTask read the persisted connector from
featuresTask.params?.connectors?.features (or params.connectors) and return
false if it differs before performing the age check against
FEATURES_IDENTIFICATION_RECENCY_MS; apply the same connector-matching check to
the analogous function/usage later in the file (the block around the other
features recency check).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e54f79dc-26dd-4c80-b85d-195d0431140c

📥 Commits

Reviewing files that changed from the base of the PR and between aa68f24 and d41dadb.

📒 Files selected for processing (9)

x-pack/platform/plugins/shared/streams/server/lib/sig_events/tasks/significant_events_queries_generation.ts
x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/features_identification/index.ts
x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts
x-pack/platform/plugins/shared/streams/server/routes/internal/streams/onboarding/route.ts
x-pack/platform/plugins/shared/streams_app/public/components/sig_events/significant_events_discovery/components/streams_view/onboarding_config_popover.tsx
x-pack/platform/plugins/shared/streams_app/public/components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx
x-pack/platform/plugins/shared/streams_app/public/components/sig_events/significant_events_discovery/components/streams_view/translations.ts
x-pack/platform/plugins/shared/streams_app/public/hooks/sig_events/use_inference_feature_connectors.ts
x-pack/platform/plugins/shared/streams_app/public/hooks/use_onboarding_api.ts

x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts

cesco-f · 2026-04-07T17:12:58Z

/ci

cesco-f · 2026-04-07T20:05:06Z

@elasticmachine merge upstream

cesco-f · 2026-04-07T20:06:15Z

/ci

cesco-f · 2026-04-07T21:04:37Z

@elasticmachine merge upstream

cesco-f · 2026-04-07T21:05:00Z

/ci

achyutjhunjhunwala · 2026-04-08T09:49:12Z

@cesco-f I am still reviewing the PR, but thought of sharing this earlier. The UX for the dropdown looks different from what @boriskirov has proposed in his wireframes in the linked Figma. Is this intentional ?

cesco-f · 2026-04-08T09:52:13Z

@cesco-f I am still reviewing the PR, but thought of sharing this earlier. The UX for the dropdown looks different from what @boriskirov has proposed in his wireframes in the linked Figma. Is this intentional ?

Hey @achyutjhunjhunwala! Yes, we decided to split the functionality from the final UX experience, @boriskirov will take care of that in a separate PR.

boriskirov · 2026-04-08T10:49:17Z

@cesco-f I am still reviewing the PR, but thought of sharing this earlier. The UX for the dropdown looks different from what @boriskirov has proposed in his wireframes in the linked Figma. Is this intentional ?

Hey @achyutjhunjhunwala! Yes, we decided to split the functionality from the final UX experience, @boriskirov will take care of that in a separate PR.

Yes, I will open another one with the UX improvements, once this gets merged, as a follow up @achyutjhunjhunwala

.../components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx

…ig_events/significant_events_discovery/components/streams_view/streams_view.tsx Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@gmail.com>

...tform/plugins/shared/streams_app/public/hooks/sig_events/use_inference_feature_connectors.ts

achyutjhunjhunwala · 2026-04-08T13:36:04Z

@cesco-f Thanks for these changes, i have added couple of short comments.

1 additional UX issue i found was, lets say user open the popover and deselects both the options (KI and Rules). Closes the pop up. Now even though they have selected streams, onboard streams is not enabled and the user has no way of identifying why. One solution to this could be, at least 1 option must be enabled

cc: @boriskirov

cesco-f · 2026-04-08T14:00:48Z

@cesco-f Thanks for these changes, i have added couple of short comments.

1 additional UX issue i found was, lets say user open the popover and deselects both the options (KI and Rules). Closes the pop up. Now even though they have selected streams, onboard streams is not enabled and the user has no way of identifying why. One solution to this could be, at least 1 option must be enabled

cc: @boriskirov

Thanks for the great review @achyutjhunjhunwala, I've addressed your comments!

I'll leave the UX issue to @boriskirov.

...ig_events/significant_events_discovery/components/streams_view/onboarding_config_popover.tsx

achyutjhunjhunwala

LGTM

flash1293

All of the files in here are actually sigevents code, not sure why they trigger code review for the onboarding team

flash1293 · 2026-04-08T16:07:55Z

...rm/plugins/shared/streams/server/lib/tasks/task_definitions/features_identification/index.ts

@CoenWarmer should this file be owned by the onboarding team?

cesco-f · 2026-04-08T16:19:01Z

All of the files in here are actually sigevents code, not sure why they trigger code review for the onboarding team

I think it's because of the moon file.

elasticmachine · 2026-04-08T16:40:58Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 9bf6750

Failed CI Steps

Jest Tests #1

Test Failures

[job] [logs] Jest Tests #1 / buildEsqlFetchSubscribe changing a ES|QL query with no transformational commands should not change state when loading and finished if index pattern and columns are the same

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`streamsApp`	1758	1806	+48

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`streamsApp`	1.9MB	1.9MB	+14.1KB

History

💚 Build #423804 succeeded e008145
💛 Build #423586 was flaky ee742d2
💔 Build #423551 failed 4b998fc
💔 Build #423430 failed 486bf5d
💔 Build #423360 failed d41dadb

cesco-f added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) Team:SigEvents Project team working on Significant Events labels Apr 7, 2026

github-actions bot added the author:actionable-obs PRs authored by the actionable obs team label Apr 7, 2026

macroscopeapp bot reviewed Apr 7, 2026

View reviewed changes

.../components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx Outdated Show resolved Hide resolved

cesco-f force-pushed the selected-streams-features-identification branch from 1271b19 to 41ffb00 Compare April 7, 2026 15:27

macroscopeapp bot reviewed Apr 7, 2026

View reviewed changes

...ig_events/significant_events_discovery/components/streams_view/onboarding_config_popover.tsx Outdated Show resolved Hide resolved

cesco-f force-pushed the selected-streams-features-identification branch from 41ffb00 to b8dbfae Compare April 7, 2026 15:40

feat(onboarding): add onboarding options

d41dadb

cesco-f force-pushed the selected-streams-features-identification branch from b8dbfae to d41dadb Compare April 7, 2026 15:42

coderabbitai bot reviewed Apr 7, 2026

View reviewed changes

.../components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx Outdated Show resolved Hide resolved

x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts Show resolved Hide resolved

coderabbitai bot reviewed Apr 7, 2026

View reviewed changes

x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts Show resolved Hide resolved

Merge branch 'main' into selected-streams-features-identification

486bf5d

Merge branch 'main' into selected-streams-features-identification

4b998fc

Merge branch 'main' into selected-streams-features-identification

ee742d2

cesco-f and others added 2 commits April 8, 2026 07:53

Merge branch 'main' into selected-streams-features-identification

e578aa1

fix(cr): code review

89c4ab0

fix(style): min width for onboarding button

e008145

achyutjhunjhunwala self-requested a review April 8, 2026 09:43

feat(insights): add connector selector for insights

cfd671c

cesco-f changed the title ~~[Sig Events] Unified onboarding button with per-step connector overrides~~ [Sig Events] Per-step connector overrides for onboarding and insights discovery Apr 8, 2026

Merge branch 'main' into selected-streams-features-identification

ac66d54

achyutjhunjhunwala reviewed Apr 8, 2026

View reviewed changes

.../components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx Show resolved Hide resolved

cesco-f and others added 2 commits April 8, 2026 14:57

Update x-pack/platform/plugins/shared/streams_app/public/components/s…

2c586b9

…ig_events/significant_events_discovery/components/streams_view/streams_view.tsx Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@gmail.com>

fix(cr): code review

2bfada0

achyutjhunjhunwala reviewed Apr 8, 2026

View reviewed changes

...tform/plugins/shared/streams_app/public/hooks/sig_events/use_inference_feature_connectors.ts Show resolved Hide resolved

achyutjhunjhunwala reviewed Apr 8, 2026

View reviewed changes

...tform/plugins/shared/streams_app/public/hooks/sig_events/use_inference_feature_connectors.ts Outdated Show resolved Hide resolved

fix(cr): handle loading/error of connectors and use useLoadConnectors

aed0059

macroscopeapp bot reviewed Apr 8, 2026

View reviewed changes

...ig_events/significant_events_discovery/components/streams_view/onboarding_config_popover.tsx Outdated Show resolved Hide resolved

boriskirov mentioned this pull request Apr 8, 2026

[Significant events] Improving the UI/UX around model selection and run configuration popover #262002

Open

kibanamachine and others added 4 commits April 8, 2026 14:23

Changes from node scripts/regenerate_moon_projects.js --update

cebb40f

fix(useloadconnectors): do not use allConnectors from useLoadConnectors

24b42e2

Merge branch 'main' into selected-streams-features-identification

c7a5023

refactor(useconnectorconfig): add useConnectorConfig

9bf6750

achyutjhunjhunwala approved these changes Apr 8, 2026

View reviewed changes

flash1293 approved these changes Apr 8, 2026

View reviewed changes

cesco-f enabled auto-merge (squash) April 8, 2026 16:36

cesco-f merged commit ea3a3b4 into elastic:main Apr 8, 2026
21 checks passed

kibanamachine added the v9.4.0 label Apr 8, 2026

cesco-f deleted the selected-streams-features-identification branch April 8, 2026 21:22

Conversation

cesco-f commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Uh oh!

Uh oh!

cesco-f commented Apr 7, 2026

Uh oh!

cesco-f commented Apr 7, 2026

Uh oh!

coderabbitai bot commented Apr 7, 2026

Uh oh!

coderabbitai bot commented Apr 7, 2026

Uh oh!

coderabbitai bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Possibly related PRs

Suggested labels

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Apr 7, 2026

Uh oh!

coderabbitai bot commented Apr 7, 2026

Walkthrough

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cesco-f commented Apr 7, 2026

Uh oh!

cesco-f commented Apr 7, 2026

Uh oh!

cesco-f commented Apr 7, 2026

Uh oh!

cesco-f commented Apr 7, 2026

Uh oh!

cesco-f commented Apr 7, 2026

Uh oh!

achyutjhunjhunwala commented Apr 8, 2026

Uh oh!

cesco-f commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boriskirov commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

achyutjhunjhunwala commented Apr 8, 2026

Uh oh!

cesco-f commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

cesco-f commented Apr 8, 2026

Uh oh!

Uh oh!

elasticmachine commented Apr 8, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

cesco-f commented Apr 7, 2026 •

edited

Loading

coderabbitai bot commented Apr 7, 2026 •

edited

Loading

cesco-f commented Apr 8, 2026 •

edited

Loading

cesco-f commented Apr 8, 2026 •

edited

Loading