Skip to content

[Significant events] Improving the UI/UX around model selection and run configuration popover#262002

Merged
achyutjhunjhunwala merged 22 commits intoelastic:mainfrom
boriskirov:onboarding-streams-ux-improvements
Apr 10, 2026
Merged

[Significant events] Improving the UI/UX around model selection and run configuration popover#262002
achyutjhunjhunwala merged 22 commits intoelastic:mainfrom
boriskirov:onboarding-streams-ux-improvements

Conversation

@boriskirov
Copy link
Copy Markdown
Contributor

@boriskirov boriskirov commented Apr 8, 2026

Summary

This is UX and UI focused PR for #261588 which is focusing on improving the way how you handle configuration runs and model selection from the pop over for Generate KI and Discovery Significant events.

Screen.Recording.2026-04-08.at.15.18.09.mov

@boriskirov boriskirov force-pushed the onboarding-streams-ux-improvements branch from 5324c84 to 1fe1fad Compare April 9, 2026 08:30
@boriskirov boriskirov requested a review from cesco-f April 9, 2026 08:32
@boriskirov boriskirov added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) Team:SigEvents Project team working on Significant Events labels Apr 9, 2026
@boriskirov boriskirov marked this pull request as ready for review April 9, 2026 08:32
@boriskirov boriskirov requested a review from a team as a code owner April 9, 2026 08:32
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 9, 2026

Approvability

Verdict: Needs human review

UI/UX refactor replacing popover components with split button menus for model selection. While the changes are self-contained to the significant events feature and don't alter core business logic, all files are owned by @elastic/obs-sig-events-team and the author is not a designated owner, warranting team review.

You can customize Macroscope's approvability policy. Learn more.

Made-with: Cursor
@boriskirov boriskirov force-pushed the onboarding-streams-ux-improvements branch from 1fe1fad to 789027b Compare April 9, 2026 08:37
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner April 9, 2026 09:01
@boriskirov boriskirov changed the title Onboarding streams ux improvements [Significant events] Improving the UI/UX around model selection and run configuration popover Apr 9, 2026
@boriskirov
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@achyutjhunjhunwala achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added 2 nit's which would be great to fix. apart from that, everything else looks good. LGTM

);

return (
<EuiSelectable singleSelection options={options} onChange={handleChange}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EuiSelectable with bare singleSelection allows the user to click an already-checked item to deselect it, leaving zero connectors selected. The handleChange callback guards with if (selected?.key), so no crash occurs, but the user gets a confusing silent no-op where their click does nothing.

Using singleSelection="always" prevents deselection entirely -- this pattern is used widely across the Kibana codebase.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) April 10, 2026 13:16
@achyutjhunjhunwala achyutjhunjhunwala merged commit e3f8cfd into elastic:main Apr 10, 2026
20 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 1817 1819 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 1.9MB 1.9MB +660.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) release_note:skip Skip the PR/issue when compiling release notes Team:SigEvents Project team working on Significant Events v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants