[Significant events] Improving the UI/UX around model selection and run configuration popover#262002
Conversation
5324c84 to
1fe1fad
Compare
ApprovabilityVerdict: Needs human review UI/UX refactor replacing popover components with split button menus for model selection. While the changes are self-contained to the significant events feature and don't alter core business logic, all files are owned by @elastic/obs-sig-events-team and the author is not a designated owner, warranting team review. You can customize Macroscope's approvability policy. Learn more. |
Made-with: Cursor
1fe1fad to
789027b
Compare
.../components/sig_events/significant_events_discovery/components/streams_view/streams_view.tsx
Outdated
Show resolved
Hide resolved
...nts/sig_events/significant_events_discovery/components/streams_view/context_menu_helpers.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
achyutjhunjhunwala
left a comment
There was a problem hiding this comment.
I have added 2 nit's which would be great to fix. apart from that, everything else looks good. LGTM
| ); | ||
|
|
||
| return ( | ||
| <EuiSelectable singleSelection options={options} onChange={handleChange}> |
There was a problem hiding this comment.
nit: EuiSelectable with bare singleSelection allows the user to click an already-checked item to deselect it, leaving zero connectors selected. The handleChange callback guards with if (selected?.key), so no crash occurs, but the user gets a confusing silent no-op where their click does nothing.
Using singleSelection="always" prevents deselection entirely -- this pattern is used widely across the Kibana codebase.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
Summary
This is UX and UI focused PR for #261588 which is focusing on improving the way how you handle configuration runs and model selection from the pop over for Generate KI and Discovery Significant events.
Screen.Recording.2026-04-08.at.15.18.09.mov