Skip to content

[Lens as code] Split xyStateSchema config#261089

Merged
nickofthyme merged 5 commits into
elastic:mainfrom
nickofthyme:split-xy-esql
Apr 7, 2026
Merged

[Lens as code] Split xyStateSchema config#261089
nickofthyme merged 5 commits into
elastic:mainfrom
nickofthyme:split-xy-esql

Conversation

@nickofthyme
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme commented Apr 3, 2026

Summary

Splits xyStateSchema into unoin of xyStateSchemaNoESQL and xyStateSchemaESQL.

Closes #260965

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Apr 3, 2026
@nickofthyme nickofthyme changed the title split xy config by dsl/esql [Lens as code] Split xyStateSchema config Apr 3, 2026
@nickofthyme nickofthyme marked this pull request as ready for review April 6, 2026 19:32
@nickofthyme nickofthyme requested a review from a team as a code owner April 6, 2026 19:32
@elastic elastic deleted a comment from elasticmachine Apr 6, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] affected Scout: [ platform / alerting_v2 ] plugin / local-serverless-observability_complete - Discover Alerts menu with alerting v2 - should show Alerts menu with v2 ES|QL rule row and New badge
  • [job] [logs] affected Scout: [ platform / alerting_v2 ] plugin / local-serverless-security_complete - Discover Alerts menu with alerting v2 - should show Alerts menu with v2 ES|QL rule row and New badge
  • [job] [logs] Jest Tests #5 / TagsField shows validation error on submit when a tag exceeds 64 characters

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 2.0MB 2.0MB +308.0B

@nickofthyme nickofthyme enabled auto-merge (squash) April 7, 2026 03:45
Copy link
Copy Markdown
Contributor

@andrimal andrimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✨

}
);

const xyLayerUnionESQL = schema.oneOf([xyDataLayerSchemaESQL, referenceLineLayerSchemaESQL], {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference lines are not currently supported in ESQL right? Are we enabling them via API?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #261586

@nickofthyme nickofthyme merged commit e116694 into elastic:main Apr 7, 2026
17 checks passed
@nickofthyme nickofthyme deleted the split-xy-esql branch April 7, 2026 15:05
mbondyra added a commit to Heenawter/kibana that referenced this pull request Apr 7, 2026
* commit 'bfc2446fdbcba2b3183f4518817c9757198c95ef':
  [Cascade] make cascade layout enabled by default (elastic#260698)
  [Dashboard Agent] Extract safe dashboard attachment integration refactors (elastic#261422)
  [One Workflow] Replace workflows:aiAgent:enabled with agentBuilder:experimentalFeatures (elastic#261330)
  [EDR Workflows] Osquery: hide query code from dropdown and show Elastic for automated Run By (elastic#261394)
  [Observability Onboarding] Add data detection & loading indicators to onboarding flows  (elastic#257870)
  [Significant events] Format event count with locale-aware number separators (elastic#261570)
  [Fleet] Fix deprecated filter in browse integrations (elastic#261459)
  [Lens as code] Split `xyStateSchema` config (elastic#261089)
  [Data Views as Code] Use `ref_id` and add metadata in data views schemas (elastic#261181)

Made-with: Cursor

# Conflicts:
#	x-pack/platform/packages/shared/dashboard-agent/dashboard-agent-common/types.ts
mbondyra added a commit to mbondyra/kibana that referenced this pull request Apr 7, 2026
…r-uid-to-id

* commit '6868ae2f195462f1f6809a6a544114f54e48239e':
  [One Workflow] Replace workflows:aiAgent:enabled with agentBuilder:experimentalFeatures (elastic#261330)
  [EDR Workflows] Osquery: hide query code from dropdown and show Elastic for automated Run By (elastic#261394)
  [Observability Onboarding] Add data detection & loading indicators to onboarding flows  (elastic#257870)
  [Significant events] Format event count with locale-aware number separators (elastic#261570)
  [Fleet] Fix deprecated filter in browse integrations (elastic#261459)
  [Lens as code] Split `xyStateSchema` config (elastic#261089)
  [Data Views as Code] Use `ref_id` and add metadata in data views schemas (elastic#261181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Lens as code] Split DSL and ESQL XY charts schemas

5 participants