Skip to content

[Lens as code] Remove Reference Line from ES|QL layers#261586

Merged
nickofthyme merged 11 commits into
elastic:mainfrom
nickofthyme:rm-ref-line-esql
Apr 8, 2026
Merged

[Lens as code] Remove Reference Line from ES|QL layers#261586
nickofthyme merged 11 commits into
elastic:mainfrom
nickofthyme:rm-ref-line-esql

Conversation

@nickofthyme
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme commented Apr 7, 2026

Summary

Changes:

  • Removes reference line in schemas for ES|QL Lens charts.
  • Keeps existing logic to handle ES|QL reference lines in place.
  • Infills types to support ES|QL ref lines in logic.
  • Add @depracated to infilled types until support is added in the UI.
  • Renames referenceLines type to reference_lines.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@nickofthyme nickofthyme requested a review from a team as a code owner April 7, 2026 15:12
@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Apr 7, 2026
@nickofthyme nickofthyme changed the title [Lens as code] Remove lens ref line in esql [Lens as code] Remove Reference Line from ES|QL layers Apr 7, 2026
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@nickofthyme nickofthyme enabled auto-merge (squash) April 8, 2026 19:38
@elastic elastic deleted a comment from elasticmachine Apr 8, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout: [ security / entity_store ] plugin / local-stateful-classic - ESQL query translation - host: ESQL from doc with host.name + host.domain returns expected document(s)
  • [job] [logs] FTR Configs #61 / serverless search UI Rule details Edit rule with deleted connector should show and update deleted connectors when there are existing connectors of the same type

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
agentBuilder 815.9KB 815.9KB +46.0B
cases 2.0MB 2.0MB +39.0B
dashboard 866.8KB 866.8KB +46.0B
dashboardAgent 138.0KB 138.0KB +46.0B
discover 1.6MB 1.6MB +39.0B
infra 1.3MB 1.3MB +46.0B
lens 2.0MB 2.0MB +35.0B
observability 2.0MB 2.0MB +39.0B
observabilityAIAssistantApp 332.0KB 332.0KB +46.0B
unifiedDocViewer 424.8KB 424.9KB +46.0B
total +428.0B

@nickofthyme nickofthyme merged commit 398316a into elastic:main Apr 8, 2026
19 checks passed
@nickofthyme nickofthyme deleted the rm-ref-line-esql branch April 8, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants