[Data Views as Code] Use ref_id and add metadata in data views schemas#261181
Merged
lukasolson merged 8 commits intoApr 7, 2026
Conversation
lukasolson
added
Feature:Data Views
lukasolson
changed the title
ref_id and add metadata in data views schemas
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Historycc @lukasolson |
…n/kibana into data_views_as_code/schema_meta
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @lukasolson |
AlexGPlay
approved these changes
Apr 6, 2026
mbondyra
added a commit
to Heenawter/kibana
that referenced
this pull request
Apr 7, 2026
* commit 'bfc2446fdbcba2b3183f4518817c9757198c95ef': [Cascade] make cascade layout enabled by default (elastic#260698) [Dashboard Agent] Extract safe dashboard attachment integration refactors (elastic#261422) [One Workflow] Replace workflows:aiAgent:enabled with agentBuilder:experimentalFeatures (elastic#261330) [EDR Workflows] Osquery: hide query code from dropdown and show Elastic for automated Run By (elastic#261394) [Observability Onboarding] Add data detection & loading indicators to onboarding flows (elastic#257870) [Significant events] Format event count with locale-aware number separators (elastic#261570) [Fleet] Fix deprecated filter in browse integrations (elastic#261459) [Lens as code] Split `xyStateSchema` config (elastic#261089) [Data Views as Code] Use `ref_id` and add metadata in data views schemas (elastic#261181) Made-with: Cursor # Conflicts: # x-pack/platform/packages/shared/dashboard-agent/dashboard-agent-common/types.ts
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 7, 2026
…r-uid-to-id * commit '6868ae2f195462f1f6809a6a544114f54e48239e': [One Workflow] Replace workflows:aiAgent:enabled with agentBuilder:experimentalFeatures (elastic#261330) [EDR Workflows] Osquery: hide query code from dropdown and show Elastic for automated Run By (elastic#261394) [Observability Onboarding] Add data detection & loading indicators to onboarding flows (elastic#257870) [Significant events] Format event count with locale-aware number separators (elastic#261570) [Fleet] Fix deprecated filter in browse integrations (elastic#261459) [Lens as code] Split `xyStateSchema` config (elastic#261089) [Data Views as Code] Use `ref_id` and add metadata in data views schemas (elastic#261181)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the by-reference data view field name with other as-code patterns (
ref_idvs.id), and add stable OAS component ids and titles so generated docs/refs are consistent.This also fixes an issue with the OAS generation because we were doing
const dataViewSchema = schema.discriminatedUnion()without the underlying types havingmeta.id.Changes
Data view reference (
data_view_reference): Rename propertyid→ref_idso the serialized shape matches the “reference id” naming used elsewhere in as-code APIs.OAS generation duplication: Add
meta.id/meta.title(anddescriptionwhere helpful) on schemas so OAS generation can reuse components and labels read clearly.