Ref/canvas interpreter2 oss take5#26068
Merged
ppisljar merged 24 commits intoelastic:masterfrom Nov 23, 2018
Merged
Conversation
…s still static analyzable when isolate kbn interpreter.
…ng canvas, core_plugins/interpreter and kbn-interpreter in node 10.
7 tasks
Contributor
|
retest |
Contributor
💚 Build Succeeded |
Contributor
|
retest |
Contributor
💚 Build Succeeded |
spalger
approved these changes
Nov 22, 2018
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
LGTM, tests pass, code looks good, I'd like to submit a PR after this to cleanup the split build stuff
Contributor
💚 Build Succeeded |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Nov 23, 2018
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Nov 23, 2018
# Conflicts: # package.json # src/setup_node_env/babel_register/register.js # x-pack/package.json # x-pack/plugins/canvas/__tests__/fixtures/function_specs.js # x-pack/plugins/canvas/common/lib/index.js # x-pack/plugins/canvas/init.js # x-pack/plugins/canvas/server/routes/plugins.js # x-pack/plugins/canvas/server/routes/translate.js # x-pack/plugins/canvas/tasks/helpers/webpack.plugins.js # yarn.lock
ppisljar
added a commit
that referenced
this pull request
Nov 23, 2018
This was referenced Dec 13, 2018
| @@ -0,0 +1,4 @@ | |||
| /common | |||
There was a problem hiding this comment.
Did this file get removed? I tried looking for it in master and can't find it, but when I look at the file history, I don't see it being deleted. Maybe file history doesn't include the delete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #23096
preparation for #23185
moves some parts of canvas to kibana core:
@kbn/interpreter@kbn/interpreter@kbn/interpreter@kbn/interpreterinterpretercore_plugininterpretercore_pluginqa: nothing should change functionally
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately