Closed
Conversation
…s still static analyzable when isolate kbn interpreter.
mistic
reviewed
Nov 22, 2018
Contributor
mistic
left a comment
mistic
left a comment
There was a problem hiding this comment.
It looks almost good to me. I found 3 problems with the merges from my fix branch. Also the original PR feedback should be considered too.
| "name": "@kbn/interpreter", | ||
| "version": "1.0.0", | ||
| "license": "Apache-2.0", | ||
| "main": "./index.js", |
Contributor
There was a problem hiding this comment.
We can delete this! It was dead code left here.
| test, | ||
| include: /[\/\\]node_modules[\/\\]x-pack[\/\\]/, | ||
| exclude: /[\/\\]node_modules[\/\\]x-pack[\/\\](.+?[\/\\])*node_modules[\/\\]/, | ||
|
|
Contributor
There was a problem hiding this comment.
We can also remove this extra line here
| // ignore paths matching `/canvas/canvas_plugin/{a}/{b}` unless | ||
| // is `x-pack` and `b` is not `node_modules` | ||
| /\/canvas\/canvas_plugin\/(?!functions\/server)([^\/]+\/[^\/]+)/, | ||
| /\/node_modules\/(?!(x-pack\/|@kbn\/interpreter\/)(?!node_modules)([^\/]+))([^\/]+\/[^\/]+)/, |
Contributor
There was a problem hiding this comment.
We should change this again to /\/canvas\/canvas_plugin\/(?!functions\/server)([^\/]+\/[^\/]+)/,
mistic
reviewed
Nov 22, 2018
| /x-pack/build | ||
| /x-pack/plugins/**/__tests__/fixtures/** | ||
| /x-pack/plugins/canvas/common/lib/grammar.js | ||
| /packages/kbn-interpreter/src/common/lib/grammar.js |
Contributor
There was a problem hiding this comment.
we should ignore {common, plugin, public, server, src/common/lib/grammar.js}
Contributor
💔 Build Failed |
Contributor
Author
|
closing in favor of #26068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trying again with #25711
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers