[6.5] Ref/canvas interpreter2 oss take5 (#26068)#26108
Closed
ppisljar wants to merge 1 commit intoelastic:6.5from
Closed
[6.5] Ref/canvas interpreter2 oss take5 (#26068)#26108ppisljar wants to merge 1 commit intoelastic:6.5from
ppisljar wants to merge 1 commit intoelastic:6.5from
Conversation
# Conflicts: # package.json # src/setup_node_env/babel_register/register.js # x-pack/package.json # x-pack/plugins/canvas/__tests__/fixtures/function_specs.js # x-pack/plugins/canvas/common/lib/index.js # x-pack/plugins/canvas/init.js # x-pack/plugins/canvas/server/routes/plugins.js # x-pack/plugins/canvas/server/routes/translate.js # x-pack/plugins/canvas/tasks/helpers/webpack.plugins.js # yarn.lock
Contributor
💔 Build Failed |
Contributor
Author
Contributor
|
I'm going to try and submit this backport |
Contributor
|
There are already a lot of conflicts that seem to indicate that 6.5 isn't getting a lot backported to it from the canvas team, so I'm good with skipping 6.5 here. @rashidkpc @w33ble do you guys agree? Would you be able to help with some of the conflicts? This pr is a lot bigger than it should be, so we should probably start a fresh backport to make sure it's accurate if we're going to do it. |
Contributor
|
I don't think there's any reason to back port this to 6.5 at all. Nothing going into 6.5 depends on it and I'd rather not risk introducing regressions in a patch release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.5: