move canvas interpreter to OSS#25711
Merged
ppisljar merged 12 commits intoelastic:masterfrom Nov 20, 2018
Merged
Conversation
ppisljar
added
WIP
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
|
Pinging @elastic/kibana-app |
ppisljar
force-pushed
the
ref/canvasInterpreter2OSS
branch
5 times, most recently
from
e382cf4 to
626234a
Compare
Contributor
💚 Build Succeeded |
ppisljar
force-pushed
the
ref/canvasInterpreter2OSS
branch
from
626234a to
102ab05
Compare
Contributor
💚 Build Succeeded |
ppisljar
force-pushed
the
ref/canvasInterpreter2OSS
branch
from
422a651 to
d592e97
Compare
Contributor
💚 Build Succeeded |
markov00
approved these changes
Nov 19, 2018
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Code LGTM. Tested on chrome/OSX and works correctly.
Contributor
💚 Build Succeeded |
rashidkpc
suggested changes
Nov 19, 2018
Contributor
rashidkpc
left a comment
rashidkpc
left a comment
There was a problem hiding this comment.
Few questions and comments. Thanks for separating out the license and file moving commits!
Contributor
💚 Build Succeeded |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Nov 20, 2018
ppisljar
added a commit
that referenced
this pull request
Nov 20, 2018
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Nov 21, 2018
Contributor
w33ble
added a commit
that referenced
this pull request
Nov 21, 2018
## Summary CI was broken when enabling functional smoke tests via #25262. The problem is that the Kibana build is broken in master... I think #25711 broke it, which was merged in between #25262 passing and it being merged (and then CI breaking). So this PR reverts that PR and enabled canvas smoke tests again to see if CI will pass. - Revert #25711 - Revert 7ae0d28
7 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #23096
preparation for #23185
moves some parts of canvas to kibana core:
@kbn/interpreter@kbn/interpreter@kbn/interpreter@kbn/interpreterinterpretercore_plugininterpretercore_pluginqa: nothing should change functionally
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately