[Search] Replace aria-selected with aria-expanded on Result toggle button#260561
Merged
Conversation
… on Result toggle button
seialkali
added
release_note:skip
Contributor
ApprovabilityVerdict: Needs human review This is a straightforward accessibility fix (replacing incorrect You can customize Macroscope's approvability policy. Learn more. |
TattdCodeMonkey
approved these changes
Mar 31, 2026
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/23818333431 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 31, 2026
…tton (elastic#260561) ## Summary ## Summary Fixes a critical `aria-allowed-attr` accessibility violation in the `Result` component (`@kbn/search-index-documents`). The "Show more fields" `EuiButtonIcon` was using `aria-selected` to communicate its toggle state, but `aria-selected` is not a valid ARIA attribute for the `button` role. This was replaced with `aria-expanded`, which is the semantically correct attribute for a button that controls the visibility of related content. (cherry picked from commit 70d4f49)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 31, 2026
…tton (elastic#260561) ## Summary ## Summary Fixes a critical `aria-allowed-attr` accessibility violation in the `Result` component (`@kbn/search-index-documents`). The "Show more fields" `EuiButtonIcon` was using `aria-selected` to communicate its toggle state, but `aria-selected` is not a valid ARIA attribute for the `button` role. This was replaced with `aria-expanded`, which is the semantically correct attribute for a button that controls the visibility of related content. (cherry picked from commit 70d4f49)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 31, 2026
…gle button (#260561) (#260581) # Backport This will backport the following commits from `main` to `9.3`: - [[Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)](#260561) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brittany","email":"seialkali@gmail.com"},"sourceCommit":{"committedDate":"2026-03-31T20:39:10Z","message":"[Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)\n\n## Summary\n\n## Summary\n\nFixes a critical `aria-allowed-attr` accessibility violation in the\n`Result` component (`@kbn/search-index-documents`).\n\nThe \"Show more fields\" `EuiButtonIcon` was using `aria-selected` to\ncommunicate its toggle state, but `aria-selected` is not a valid ARIA\nattribute for the `button` role. This was replaced with `aria-expanded`,\nwhich is the semantically correct attribute for a button that controls\nthe visibility of related content.","sha":"70d4f496c01739c9ec4dbf2d82830d82e680b9fe","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Search","backport:all-open","v9.4.0"],"title":"[Search] Replace aria-selected with aria-expanded on Result toggle button","number":260561,"url":"https://github.com/elastic/kibana/pull/260561","mergeCommit":{"message":"[Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)\n\n## Summary\n\n## Summary\n\nFixes a critical `aria-allowed-attr` accessibility violation in the\n`Result` component (`@kbn/search-index-documents`).\n\nThe \"Show more fields\" `EuiButtonIcon` was using `aria-selected` to\ncommunicate its toggle state, but `aria-selected` is not a valid ARIA\nattribute for the `button` role. This was replaced with `aria-expanded`,\nwhich is the semantically correct attribute for a button that controls\nthe visibility of related content.","sha":"70d4f496c01739c9ec4dbf2d82830d82e680b9fe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/260561","number":260561,"mergeCommit":{"message":"[Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)\n\n## Summary\n\n## Summary\n\nFixes a critical `aria-allowed-attr` accessibility violation in the\n`Result` component (`@kbn/search-index-documents`).\n\nThe \"Show more fields\" `EuiButtonIcon` was using `aria-selected` to\ncommunicate its toggle state, but `aria-selected` is not a valid ARIA\nattribute for the `button` role. This was replaced with `aria-expanded`,\nwhich is the semantically correct attribute for a button that controls\nthe visibility of related content.","sha":"70d4f496c01739c9ec4dbf2d82830d82e680b9fe"}}]}] BACKPORT--> Co-authored-by: Brittany <seialkali@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 31, 2026
…gle button (#260561) (#260580) # Backport This will backport the following commits from `main` to `9.2`: - [[Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)](#260561) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Brittany","email":"seialkali@gmail.com"},"sourceCommit":{"committedDate":"2026-03-31T20:39:10Z","message":"[Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)\n\n## Summary\n\n## Summary\n\nFixes a critical `aria-allowed-attr` accessibility violation in the\n`Result` component (`@kbn/search-index-documents`).\n\nThe \"Show more fields\" `EuiButtonIcon` was using `aria-selected` to\ncommunicate its toggle state, but `aria-selected` is not a valid ARIA\nattribute for the `button` role. This was replaced with `aria-expanded`,\nwhich is the semantically correct attribute for a button that controls\nthe visibility of related content.","sha":"70d4f496c01739c9ec4dbf2d82830d82e680b9fe","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Search","backport:all-open","v9.4.0"],"title":"[Search] Replace aria-selected with aria-expanded on Result toggle button","number":260561,"url":"https://github.com/elastic/kibana/pull/260561","mergeCommit":{"message":"[Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)\n\n## Summary\n\n## Summary\n\nFixes a critical `aria-allowed-attr` accessibility violation in the\n`Result` component (`@kbn/search-index-documents`).\n\nThe \"Show more fields\" `EuiButtonIcon` was using `aria-selected` to\ncommunicate its toggle state, but `aria-selected` is not a valid ARIA\nattribute for the `button` role. This was replaced with `aria-expanded`,\nwhich is the semantically correct attribute for a button that controls\nthe visibility of related content.","sha":"70d4f496c01739c9ec4dbf2d82830d82e680b9fe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/260561","number":260561,"mergeCommit":{"message":"[Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)\n\n## Summary\n\n## Summary\n\nFixes a critical `aria-allowed-attr` accessibility violation in the\n`Result` component (`@kbn/search-index-documents`).\n\nThe \"Show more fields\" `EuiButtonIcon` was using `aria-selected` to\ncommunicate its toggle state, but `aria-selected` is not a valid ARIA\nattribute for the `button` role. This was replaced with `aria-expanded`,\nwhich is the semantically correct attribute for a button that controls\nthe visibility of related content.","sha":"70d4f496c01739c9ec4dbf2d82830d82e680b9fe"}}]}] BACKPORT--> Co-authored-by: Brittany <seialkali@gmail.com>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
…tton (elastic#260561) ## Summary ## Summary Fixes a critical `aria-allowed-attr` accessibility violation in the `Result` component (`@kbn/search-index-documents`). The "Show more fields" `EuiButtonIcon` was using `aria-selected` to communicate its toggle state, but `aria-selected` is not a valid ARIA attribute for the `button` role. This was replaced with `aria-expanded`, which is the semantically correct attribute for a button that controls the visibility of related content.
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
…tton (elastic#260561) ## Summary ## Summary Fixes a critical `aria-allowed-attr` accessibility violation in the `Result` component (`@kbn/search-index-documents`). The "Show more fields" `EuiButtonIcon` was using `aria-selected` to communicate its toggle state, but `aria-selected` is not a valid ARIA attribute for the `button` role. This was replaced with `aria-expanded`, which is the semantically correct attribute for a button that controls the visibility of related content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary
Fixes a critical
aria-allowed-attraccessibility violation in theResultcomponent (@kbn/search-index-documents).The "Show more fields"
EuiButtonIconwas usingaria-selectedto communicate its toggle state, butaria-selectedis not a valid ARIA attribute for thebuttonrole. This was replaced witharia-expanded, which is the semantically correct attribute for a button that controls the visibility of related content.