Add draft PR guidance to AGENTS.md#260536
Merged
Merged
Conversation
Contributor
💚 Build Succeeded
cc @lukeelmers |
kobelb
reviewed
Mar 31, 2026
| - Make focused changes; avoid unrelated refactors. | ||
| - Update docs and tests when behavior or usage changes. | ||
| - Never remove, skip, or comment out tests to make them pass; fix the underlying code. | ||
| - Update your branch from `main` with `git merge origin/main` (after fetching). Do not rebase or reset against `main`. |
Contributor
There was a problem hiding this comment.
I always fetch upstream and merge from main with git merge upstream/main. Is this not what others do?
Contributor
There was a problem hiding this comment.
I use rebase exclusively. For long running PRs you can accumulates hundreds of commits in between your local commits and if you want to cleanup history before presenting to the reviewers it's no a pleasant experience. The "reset against main" is definitely gonna fight with that.
kapral18
reviewed
Mar 31, 2026
tylersmalley
approved these changes
Mar 31, 2026
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/23816632913 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 31, 2026
Require agent-opened PRs to be drafts by default (cherry picked from commit d776f8a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 31, 2026
Require agent-opened PRs to be drafts by default (cherry picked from commit d776f8a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 31, 2026
Require agent-opened PRs to be drafts by default (cherry picked from commit d776f8a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 31, 2026
# Backport This will backport the following commits from `main` to `9.2`: - [Add draft PR guidance to AGENTS.md (#260536)](#260536) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Luke Elmers","email":"luke.elmers@elastic.co"},"sourceCommit":{"committedDate":"2026-03-31T19:55:34Z","message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","skip-ci","backport:all-open","v9.4.0"],"title":"Add draft PR guidance to AGENTS.md","number":260536,"url":"https://github.com/elastic/kibana/pull/260536","mergeCommit":{"message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/260536","number":260536,"mergeCommit":{"message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a"}}]}] BACKPORT--> Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 31, 2026
# Backport This will backport the following commits from `main` to `9.3`: - [Add draft PR guidance to AGENTS.md (#260536)](#260536) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Luke Elmers","email":"luke.elmers@elastic.co"},"sourceCommit":{"committedDate":"2026-03-31T19:55:34Z","message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","skip-ci","backport:all-open","v9.4.0"],"title":"Add draft PR guidance to AGENTS.md","number":260536,"url":"https://github.com/elastic/kibana/pull/260536","mergeCommit":{"message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/260536","number":260536,"mergeCommit":{"message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a"}}]}] BACKPORT--> Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
delanni
pushed a commit
that referenced
this pull request
Apr 1, 2026
# Backport This will backport the following commits from `main` to `8.19`: - [Add draft PR guidance to AGENTS.md (#260536)](#260536) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Luke Elmers","email":"luke.elmers@elastic.co"},"sourceCommit":{"committedDate":"2026-03-31T19:55:34Z","message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","skip-ci","backport:all-open","v9.4.0"],"title":"Add draft PR guidance to AGENTS.md","number":260536,"url":"https://github.com/elastic/kibana/pull/260536","mergeCommit":{"message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/260536","number":260536,"mergeCommit":{"message":"Add draft PR guidance to AGENTS.md (#260536)\n\nRequire agent-opened PRs to be drafts by default","sha":"d776f8ac8384caf11c368fc67bb1493bff349e8a"}}]}] BACKPORT--> Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
Require agent-opened PRs to be drafts by default
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
Require agent-opened PRs to be drafts by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instruct agents to usewill discuss this elsewheregit merge origin/main(not rebase/reset) to update branches