[9.3] [Search] Replace aria-selected with aria-expanded on Result toggle button (#260561)#260581
Merged
Merged
Conversation
…tton (elastic#260561) ## Summary ## Summary Fixes a critical `aria-allowed-attr` accessibility violation in the `Result` component (`@kbn/search-index-documents`). The "Show more fields" `EuiButtonIcon` was using `aria-selected` to communicate its toggle state, but `aria-selected` is not a valid ARIA attribute for the `button` role. This was replaced with `aria-expanded`, which is the semantically correct attribute for a button that controls the visibility of related content. (cherry picked from commit 70d4f49)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
cc @seialkali |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation