[9.3] Fix @elastic/eui/require-aria-label-for-modals violations across kibana-data-discovery files (#259315)#260392
Merged
alexwizp merged 2 commits intoelastic:9.3from Mar 31, 2026
Merged
Conversation
…bana-data-discovery files (elastic#259315) Closes: elastic#259304 20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover` components were missing required `aria-label` props across 18 files owned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA accessibility requirements. ## Changes - **Added `aria-label` to 16 `EuiPopover` components** across `discover`, `data_view_management`, `kbn-unified-tabs`, `kbn-unified-field-list`, `kbn-search-response-warnings`, and `data_view_editor` - **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`) - **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`) - **Added `aria-label` to 1 `EuiWrappingPopover`** (`use_row_header_components.tsx`) - **Reused existing translated strings** where available (e.g. `menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate copy; added new `i18n.translate()` calls only where no suitable string existed - **Added `i18n` imports** to the handful of files that were missing them Example of the pattern applied: ```tsx // Before <EuiPopover id={contextMenuPopoverId} isOpen={isPopoverOpen} ... > // After — reusing an already-translated nearby string <EuiPopover id={contextMenuPopoverId} aria-label={menuButtonLabel} isOpen={isPopoverOpen} ... > ``` `use_table_header_components.tsx` was listed in the issue but was already compliant; no change needed there. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Send tasks to Copilot coding agent from [Slack](https://gh.io/cca-slack-docs) and [Teams](https://gh.io/cca-teams-docs) to turn conversations into code. Copilot posts an update in your thread when it's finished. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> (cherry picked from commit e9d79de) # Conflicts: # examples/discover_customization_examples/moon.yml # examples/discover_customization_examples/tsconfig.json # src/platform/plugins/shared/discover/public/application/main/components/layout/cascaded_documents/blocks/use_row_header_components.tsx # src/platform/plugins/shared/discover/public/embeddable/components/search_embeddable_inline_edit_hover_actions.tsx
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
L1nBra
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:@elastic/eui/require-aria-label-for-modalsviolations across kibana-data-discovery files (#259315)Questions ?
Please refer to the Backport tool documentation