Conversation
…na-data-discovery files Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Agent-Logs-Url: https://github.com/elastic/kibana/sessions/91439a1c-5f64-4699-879f-934da574b785
Copilot
AI
changed the title
[WIP] Fix eslint violations for require-aria-label-for-modals rule
Fix Mar 24, 2026
@elastic/eui/require-aria-label-for-modals violations across kibana-data-discovery files
alexwizp
added
backport:version
Contributor
|
/ci |
Contributor
|
/ci |
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
alexwizp
added
the
release_note:skip
Contributor
|
/ci |
justinkambic
approved these changes
Mar 24, 2026
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
obs-exploration changes LGTM
jughosta
approved these changes
Mar 25, 2026
...latform/plugins/shared/data_view_editor/public/components/form_fields/title_docs_popover.tsx
Outdated
Show resolved
Hide resolved
...ata_view_management/public/components/field_editor/components/scripting_help/help_flyout.tsx
Outdated
Show resolved
Hide resolved
…/form_fields/title_docs_popover.tsx Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
…ents/field_editor/components/scripting_help/help_flyout.tsx Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Contributor
|
@elasticmachine run docs-build |
Contributor
|
/ci |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
cc @alexwizp @Copilot |
Contributor
|
/ci |
Contributor
|
@elasticmachine run docs-build |
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…bana-data-discovery files (elastic#259315) Closes: elastic#259304 20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover` components were missing required `aria-label` props across 18 files owned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA accessibility requirements. ## Changes - **Added `aria-label` to 16 `EuiPopover` components** across `discover`, `data_view_management`, `kbn-unified-tabs`, `kbn-unified-field-list`, `kbn-search-response-warnings`, and `data_view_editor` - **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`) - **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`) - **Added `aria-label` to 1 `EuiWrappingPopover`** (`use_row_header_components.tsx`) - **Reused existing translated strings** where available (e.g. `menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate copy; added new `i18n.translate()` calls only where no suitable string existed - **Added `i18n` imports** to the handful of files that were missing them Example of the pattern applied: ```tsx // Before <EuiPopover id={contextMenuPopoverId} isOpen={isPopoverOpen} ... > // After — reusing an already-translated nearby string <EuiPopover id={contextMenuPopoverId} aria-label={menuButtonLabel} isOpen={isPopoverOpen} ... > ``` `use_table_header_components.tsx` was listed in the issue but was already compliant; no change needed there. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Send tasks to Copilot coding agent from [Slack](https://gh.io/cca-slack-docs) and [Teams](https://gh.io/cca-teams-docs) to turn conversations into code. Copilot posts an update in your thread when it's finished. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Mar 31, 2026
…bana-data-discovery files (elastic#259315) Closes: elastic#259304 20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover` components were missing required `aria-label` props across 18 files owned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA accessibility requirements. ## Changes - **Added `aria-label` to 16 `EuiPopover` components** across `discover`, `data_view_management`, `kbn-unified-tabs`, `kbn-unified-field-list`, `kbn-search-response-warnings`, and `data_view_editor` - **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`) - **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`) - **Added `aria-label` to 1 `EuiWrappingPopover`** (`use_row_header_components.tsx`) - **Reused existing translated strings** where available (e.g. `menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate copy; added new `i18n.translate()` calls only where no suitable string existed - **Added `i18n` imports** to the handful of files that were missing them Example of the pattern applied: ```tsx // Before <EuiPopover id={contextMenuPopoverId} isOpen={isPopoverOpen} ... > // After — reusing an already-translated nearby string <EuiPopover id={contextMenuPopoverId} aria-label={menuButtonLabel} isOpen={isPopoverOpen} ... > ``` `use_table_header_components.tsx` was listed in the issue but was already compliant; no change needed there. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Send tasks to Copilot coding agent from [Slack](https://gh.io/cca-slack-docs) and [Teams](https://gh.io/cca-teams-docs) to turn conversations into code. Copilot posts an update in your thread when it's finished. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> (cherry picked from commit e9d79de) # Conflicts: # examples/discover_customization_examples/moon.yml # examples/discover_customization_examples/tsconfig.json # src/platform/plugins/shared/discover/public/application/main/components/layout/cascaded_documents/blocks/use_row_header_components.tsx # src/platform/plugins/shared/discover/public/embeddable/components/search_embeddable_inline_edit_hover_actions.tsx
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Mar 31, 2026
…bana-data-discovery files (elastic#259315) Closes: elastic#259304 20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover` components were missing required `aria-label` props across 18 files owned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA accessibility requirements. ## Changes - **Added `aria-label` to 16 `EuiPopover` components** across `discover`, `data_view_management`, `kbn-unified-tabs`, `kbn-unified-field-list`, `kbn-search-response-warnings`, and `data_view_editor` - **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`) - **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`) - **Added `aria-label` to 1 `EuiWrappingPopover`** (`use_row_header_components.tsx`) - **Reused existing translated strings** where available (e.g. `menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate copy; added new `i18n.translate()` calls only where no suitable string existed - **Added `i18n` imports** to the handful of files that were missing them Example of the pattern applied: ```tsx // Before <EuiPopover id={contextMenuPopoverId} isOpen={isPopoverOpen} ... > // After — reusing an already-translated nearby string <EuiPopover id={contextMenuPopoverId} aria-label={menuButtonLabel} isOpen={isPopoverOpen} ... > ``` `use_table_header_components.tsx` was listed in the issue but was already compliant; no change needed there. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Send tasks to Copilot coding agent from [Slack](https://gh.io/cca-slack-docs) and [Teams](https://gh.io/cca-teams-docs) to turn conversations into code. Copilot posts an update in your thread when it's finished. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> (cherry picked from commit e9d79de) # Conflicts: # examples/discover_customization_examples/moon.yml # examples/discover_customization_examples/tsconfig.json # src/platform/plugins/shared/data_view_management/public/components/edit_index_pattern/index_header/index_header.tsx # src/platform/plugins/shared/discover/public/application/main/components/layout/cascaded_documents/blocks/use_row_header_components.tsx # src/platform/plugins/shared/discover/public/application/main/components/top_nav/solutions_view_badge.tsx # src/platform/plugins/shared/discover/public/embeddable/components/search_embeddable_inline_edit_hover_actions.tsx
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
alexwizp
added a commit
that referenced
this pull request
Mar 31, 2026
…oss kibana-data-discovery files (#259315) (#260392) # Backport This will backport the following commits from `main` to `9.3`: - [Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files (#259315)](#259315) <!--- Backport version: 11.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-03-25T11:57:27Z","message":"Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files (#259315)\n\nCloses: https://github.com/elastic/kibana/issues/259304\n\n20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover`\ncomponents were missing required `aria-label` props across 18 files\nowned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA\naccessibility requirements.\n\n## Changes\n\n- **Added `aria-label` to 16 `EuiPopover` components** across\n`discover`, `data_view_management`, `kbn-unified-tabs`,\n`kbn-unified-field-list`, `kbn-search-response-warnings`, and\n`data_view_editor`\n- **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`)\n- **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`)\n- **Added `aria-label` to 1 `EuiWrappingPopover`**\n(`use_row_header_components.tsx`)\n- **Reused existing translated strings** where available (e.g.\n`menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate\ncopy; added new `i18n.translate()` calls only where no suitable string\nexisted\n- **Added `i18n` imports** to the handful of files that were missing\nthem\n\nExample of the pattern applied:\n\n```tsx\n// Before\n<EuiPopover\n id={contextMenuPopoverId}\n isOpen={isPopoverOpen}\n ...\n>\n\n// After — reusing an already-translated nearby string\n<EuiPopover\n id={contextMenuPopoverId}\n aria-label={menuButtonLabel}\n isOpen={isPopoverOpen}\n ...\n>\n```\n\n`use_table_header_components.tsx` was listed in the issue but was\nalready compliant; no change needed there.\n\n\n---\n\n💬 Send tasks to Copilot coding agent from\n[Slack](https://gh.io/cca-slack-docs) and\n[Teams](https://gh.io/cca-teams-docs) to turn conversations into code.\nCopilot posts an update in your thread when it's finished.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"e9d79de71a27d08e9e9f05529415bd9442f5b515","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport missing","💝community","backport:version","v9.4.0","v9.3.3","v9.2.8","a11y:agent-pr"],"title":"Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files","number":259315,"url":"https://github.com/elastic/kibana/pull/259315","mergeCommit":{"message":"Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files (#259315)\n\nCloses: https://github.com/elastic/kibana/issues/259304\n\n20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover`\ncomponents were missing required `aria-label` props across 18 files\nowned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA\naccessibility requirements.\n\n## Changes\n\n- **Added `aria-label` to 16 `EuiPopover` components** across\n`discover`, `data_view_management`, `kbn-unified-tabs`,\n`kbn-unified-field-list`, `kbn-search-response-warnings`, and\n`data_view_editor`\n- **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`)\n- **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`)\n- **Added `aria-label` to 1 `EuiWrappingPopover`**\n(`use_row_header_components.tsx`)\n- **Reused existing translated strings** where available (e.g.\n`menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate\ncopy; added new `i18n.translate()` calls only where no suitable string\nexisted\n- **Added `i18n` imports** to the handful of files that were missing\nthem\n\nExample of the pattern applied:\n\n```tsx\n// Before\n<EuiPopover\n id={contextMenuPopoverId}\n isOpen={isPopoverOpen}\n ...\n>\n\n// After — reusing an already-translated nearby string\n<EuiPopover\n id={contextMenuPopoverId}\n aria-label={menuButtonLabel}\n isOpen={isPopoverOpen}\n ...\n>\n```\n\n`use_table_header_components.tsx` was listed in the issue but was\nalready compliant; no change needed there.\n\n\n---\n\n💬 Send tasks to Copilot coding agent from\n[Slack](https://gh.io/cca-slack-docs) and\n[Teams](https://gh.io/cca-teams-docs) to turn conversations into code.\nCopilot posts an update in your thread when it's finished.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"e9d79de71a27d08e9e9f05529415bd9442f5b515"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/259315","number":259315,"mergeCommit":{"message":"Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files (#259315)\n\nCloses: https://github.com/elastic/kibana/issues/259304\n\n20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover`\ncomponents were missing required `aria-label` props across 18 files\nowned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA\naccessibility requirements.\n\n## Changes\n\n- **Added `aria-label` to 16 `EuiPopover` components** across\n`discover`, `data_view_management`, `kbn-unified-tabs`,\n`kbn-unified-field-list`, `kbn-search-response-warnings`, and\n`data_view_editor`\n- **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`)\n- **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`)\n- **Added `aria-label` to 1 `EuiWrappingPopover`**\n(`use_row_header_components.tsx`)\n- **Reused existing translated strings** where available (e.g.\n`menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate\ncopy; added new `i18n.translate()` calls only where no suitable string\nexisted\n- **Added `i18n` imports** to the handful of files that were missing\nthem\n\nExample of the pattern applied:\n\n```tsx\n// Before\n<EuiPopover\n id={contextMenuPopoverId}\n isOpen={isPopoverOpen}\n ...\n>\n\n// After — reusing an already-translated nearby string\n<EuiPopover\n id={contextMenuPopoverId}\n aria-label={menuButtonLabel}\n isOpen={isPopoverOpen}\n ...\n>\n```\n\n`use_table_header_components.tsx` was listed in the issue but was\nalready compliant; no change needed there.\n\n\n---\n\n💬 Send tasks to Copilot coding agent from\n[Slack](https://gh.io/cca-slack-docs) and\n[Teams](https://gh.io/cca-teams-docs) to turn conversations into code.\nCopilot posts an update in your thread when it's finished.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"e9d79de71a27d08e9e9f05529415bd9442f5b515"}},{"branch":"9.3","label":"v9.3.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Mar 31, 2026
…oss kibana-data-discovery files (#259315) (#260393) # Backport This will backport the following commits from `main` to `9.2`: - [Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files (#259315)](#259315) <!--- Backport version: 11.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-03-25T11:57:27Z","message":"Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files (#259315)\n\nCloses: https://github.com/elastic/kibana/issues/259304\n\n20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover`\ncomponents were missing required `aria-label` props across 18 files\nowned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA\naccessibility requirements.\n\n## Changes\n\n- **Added `aria-label` to 16 `EuiPopover` components** across\n`discover`, `data_view_management`, `kbn-unified-tabs`,\n`kbn-unified-field-list`, `kbn-search-response-warnings`, and\n`data_view_editor`\n- **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`)\n- **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`)\n- **Added `aria-label` to 1 `EuiWrappingPopover`**\n(`use_row_header_components.tsx`)\n- **Reused existing translated strings** where available (e.g.\n`menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate\ncopy; added new `i18n.translate()` calls only where no suitable string\nexisted\n- **Added `i18n` imports** to the handful of files that were missing\nthem\n\nExample of the pattern applied:\n\n```tsx\n// Before\n<EuiPopover\n id={contextMenuPopoverId}\n isOpen={isPopoverOpen}\n ...\n>\n\n// After — reusing an already-translated nearby string\n<EuiPopover\n id={contextMenuPopoverId}\n aria-label={menuButtonLabel}\n isOpen={isPopoverOpen}\n ...\n>\n```\n\n`use_table_header_components.tsx` was listed in the issue but was\nalready compliant; no change needed there.\n\n\n---\n\n💬 Send tasks to Copilot coding agent from\n[Slack](https://gh.io/cca-slack-docs) and\n[Teams](https://gh.io/cca-teams-docs) to turn conversations into code.\nCopilot posts an update in your thread when it's finished.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"e9d79de71a27d08e9e9f05529415bd9442f5b515","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport missing","💝community","backport:version","v9.4.0","v9.3.3","v9.2.8","a11y:agent-pr"],"title":"Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files","number":259315,"url":"https://github.com/elastic/kibana/pull/259315","mergeCommit":{"message":"Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files (#259315)\n\nCloses: https://github.com/elastic/kibana/issues/259304\n\n20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover`\ncomponents were missing required `aria-label` props across 18 files\nowned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA\naccessibility requirements.\n\n## Changes\n\n- **Added `aria-label` to 16 `EuiPopover` components** across\n`discover`, `data_view_management`, `kbn-unified-tabs`,\n`kbn-unified-field-list`, `kbn-search-response-warnings`, and\n`data_view_editor`\n- **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`)\n- **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`)\n- **Added `aria-label` to 1 `EuiWrappingPopover`**\n(`use_row_header_components.tsx`)\n- **Reused existing translated strings** where available (e.g.\n`menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate\ncopy; added new `i18n.translate()` calls only where no suitable string\nexisted\n- **Added `i18n` imports** to the handful of files that were missing\nthem\n\nExample of the pattern applied:\n\n```tsx\n// Before\n<EuiPopover\n id={contextMenuPopoverId}\n isOpen={isPopoverOpen}\n ...\n>\n\n// After — reusing an already-translated nearby string\n<EuiPopover\n id={contextMenuPopoverId}\n aria-label={menuButtonLabel}\n isOpen={isPopoverOpen}\n ...\n>\n```\n\n`use_table_header_components.tsx` was listed in the issue but was\nalready compliant; no change needed there.\n\n\n---\n\n💬 Send tasks to Copilot coding agent from\n[Slack](https://gh.io/cca-slack-docs) and\n[Teams](https://gh.io/cca-teams-docs) to turn conversations into code.\nCopilot posts an update in your thread when it's finished.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"e9d79de71a27d08e9e9f05529415bd9442f5b515"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/259315","number":259315,"mergeCommit":{"message":"Fix `@elastic/eui/require-aria-label-for-modals` violations across kibana-data-discovery files (#259315)\n\nCloses: https://github.com/elastic/kibana/issues/259304\n\n20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover`\ncomponents were missing required `aria-label` props across 18 files\nowned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA\naccessibility requirements.\n\n## Changes\n\n- **Added `aria-label` to 16 `EuiPopover` components** across\n`discover`, `data_view_management`, `kbn-unified-tabs`,\n`kbn-unified-field-list`, `kbn-search-response-warnings`, and\n`data_view_editor`\n- **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`)\n- **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`)\n- **Added `aria-label` to 1 `EuiWrappingPopover`**\n(`use_row_header_components.tsx`)\n- **Reused existing translated strings** where available (e.g.\n`menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate\ncopy; added new `i18n.translate()` calls only where no suitable string\nexisted\n- **Added `i18n` imports** to the handful of files that were missing\nthem\n\nExample of the pattern applied:\n\n```tsx\n// Before\n<EuiPopover\n id={contextMenuPopoverId}\n isOpen={isPopoverOpen}\n ...\n>\n\n// After — reusing an already-translated nearby string\n<EuiPopover\n id={contextMenuPopoverId}\n aria-label={menuButtonLabel}\n isOpen={isPopoverOpen}\n ...\n>\n```\n\n`use_table_header_components.tsx` was listed in the issue but was\nalready compliant; no change needed there.\n\n\n---\n\n💬 Send tasks to Copilot coding agent from\n[Slack](https://gh.io/cca-slack-docs) and\n[Teams](https://gh.io/cca-teams-docs) to turn conversations into code.\nCopilot posts an update in your thread when it's finished.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"e9d79de71a27d08e9e9f05529415bd9442f5b515"}},{"branch":"9.3","label":"v9.3.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
kibanamachine
removed
the
backport missing
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
…bana-data-discovery files (elastic#259315) Closes: elastic#259304 20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover` components were missing required `aria-label` props across 18 files owned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA accessibility requirements. ## Changes - **Added `aria-label` to 16 `EuiPopover` components** across `discover`, `data_view_management`, `kbn-unified-tabs`, `kbn-unified-field-list`, `kbn-search-response-warnings`, and `data_view_editor` - **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`) - **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`) - **Added `aria-label` to 1 `EuiWrappingPopover`** (`use_row_header_components.tsx`) - **Reused existing translated strings** where available (e.g. `menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate copy; added new `i18n.translate()` calls only where no suitable string existed - **Added `i18n` imports** to the handful of files that were missing them Example of the pattern applied: ```tsx // Before <EuiPopover id={contextMenuPopoverId} isOpen={isPopoverOpen} ... > // After — reusing an already-translated nearby string <EuiPopover id={contextMenuPopoverId} aria-label={menuButtonLabel} isOpen={isPopoverOpen} ... > ``` `use_table_header_components.tsx` was listed in the issue but was already compliant; no change needed there. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Send tasks to Copilot coding agent from [Slack](https://gh.io/cca-slack-docs) and [Teams](https://gh.io/cca-teams-docs) to turn conversations into code. Copilot posts an update in your thread when it's finished. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
…bana-data-discovery files (elastic#259315) Closes: elastic#259304 20 `EuiPopover`, `EuiModal`, `EuiFlyout`, and `EuiWrappingPopover` components were missing required `aria-label` props across 18 files owned by `@elastic/kibana-data-discovery`, violating WCAG 2.2 AA accessibility requirements. ## Changes - **Added `aria-label` to 16 `EuiPopover` components** across `discover`, `data_view_management`, `kbn-unified-tabs`, `kbn-unified-field-list`, `kbn-search-response-warnings`, and `data_view_editor` - **Added `aria-label` to 1 `EuiModal`** (`image_preview_modal.tsx`) - **Added `aria-label` to 1 `EuiFlyout`** (`help_flyout.tsx`) - **Added `aria-label` to 1 `EuiWrappingPopover`** (`use_row_header_components.tsx`) - **Reused existing translated strings** where available (e.g. `menuButtonLabel`, `filterAriaLabel`, `badgeText`) to avoid duplicate copy; added new `i18n.translate()` calls only where no suitable string existed - **Added `i18n` imports** to the handful of files that were missing them Example of the pattern applied: ```tsx // Before <EuiPopover id={contextMenuPopoverId} isOpen={isPopoverOpen} ... > // After — reusing an already-translated nearby string <EuiPopover id={contextMenuPopoverId} aria-label={menuButtonLabel} isOpen={isPopoverOpen} ... > ``` `use_table_header_components.tsx` was listed in the issue but was already compliant; no change needed there. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Send tasks to Copilot coding agent from [Slack](https://gh.io/cca-slack-docs) and [Teams](https://gh.io/cca-teams-docs) to turn conversations into code. Copilot posts an update in your thread when it's finished. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #259304
20
EuiPopover,EuiModal,EuiFlyout, andEuiWrappingPopovercomponents were missing requiredaria-labelprops across 18 files owned by@elastic/kibana-data-discovery, violating WCAG 2.2 AA accessibility requirements.Changes
aria-labelto 16EuiPopovercomponents acrossdiscover,data_view_management,kbn-unified-tabs,kbn-unified-field-list,kbn-search-response-warnings, anddata_view_editoraria-labelto 1EuiModal(image_preview_modal.tsx)aria-labelto 1EuiFlyout(help_flyout.tsx)aria-labelto 1EuiWrappingPopover(use_row_header_components.tsx)menuButtonLabel,filterAriaLabel,badgeText) to avoid duplicate copy; added newi18n.translate()calls only where no suitable string existedi18nimports to the handful of files that were missing themExample of the pattern applied:
use_table_header_components.tsxwas listed in the issue but was already compliant; no change needed there.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.