[Sig Events] Unified KIs table in Stream details UI #259553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

achyutjhunjhunwala merged 33 commits into elastic:main from mykolaharmash:sig-events-stream-details-unified-table

Apr 1, 2026

x-pack/platform/packages/shared/kbn-streams-schema/src/tasks/types.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -30,4 +30,5 @@ export type TaskResult<TPayload> = @@
             | TaskStatus.Canceled;
         }
       | { status: TaskStatus.Failed; error: string }
-      | ({ status: TaskStatus.Completed | TaskStatus.Acknowledged } & TPayload);
+      | ({ status: TaskStatus.Completed } & TPayload)
+      | ({ status: TaskStatus.Acknowledged } & TPayload);

x-pack/platform/plugins/shared/streams/server/lib/tasks/task_definitions/onboarding.ts

-Original file line number
+Diff line change
@@ Expand Up @@
       return saveQueries ? base : `${base}_no_save_queries`;
     }
-    const FEATURES_IDENTIFICATION_RECENCY_MS = 12 * 60 * 60 * 1000; // 12 hours
-    async function areFeaturesUpToDate({
-      taskClient,
-      featuresTaskId,
-    }: {
-      taskClient: TaskClient<StreamsTaskType>;
-      featuresTaskId: string;
-    }) {
-      const featuresTask = await taskClient.get<
-        FeaturesIdentificationTaskParams,
-        IdentifyFeaturesResult
-      >(featuresTaskId);
-      if (featuresTask.status !== TaskStatus.Completed) {
-        return false;
-      }
-      return (
-        featuresTask.last_completed_at &&
-        Date.now() - new Date(featuresTask.last_completed_at).getTime() <
-          FEATURES_IDENTIFICATION_RECENCY_MS
-      );
-    }
     export function createStreamsOnboardingTask(taskContext: TaskContext) {
       return {
         [STREAMS_ONBOARDING_TASK_TYPE]: {
@@ Expand Down Expand Up @@
                         case OnboardingStep.FeaturesIdentification: {
                           const featuresTaskId = getFeaturesIdentificationTaskId(streamName);
-                          if (
-                            await areFeaturesUpToDate({
-                              taskClient,
-                              featuresTaskId,
-                            })
-                          ) {
-                            featuresTaskResult = await taskClient.getStatus<
-                              FeaturesIdentificationTaskParams,
-                              IdentifyFeaturesResult
-                            >(featuresTaskId);
-                          } else {
-                            await scheduleFeaturesIdentificationTask(
-                              {
-                                start: from,
-                                end: to,
-                                streamName,
-                              },
-                              taskClient,
-                              runContext.fakeRequest
-                            );
-                            featuresTaskResult = await waitForSubtask<
-                              FeaturesIdentificationTaskParams,
-                              IdentifyFeaturesResult
-                            >(featuresTaskId, runContext.taskInstance.id, taskClient);
-                          }
+                          await scheduleFeaturesIdentificationTask(
+                            {
+                              start: from,
+                              end: to,
+                              streamName,
+                            },
+                            taskClient,
+                            runContext.fakeRequest
+                          );
+                          featuresTaskResult = await waitForSubtask<
+                            FeaturesIdentificationTaskParams,
+                            IdentifyFeaturesResult
+                          >(featuresTaskId, runContext.taskInstance.id, taskClient);
                           if (featuresTaskResult.status !== TaskStatus.Completed) {
                             return;
@@ Expand Down @@

x-pack/platform/plugins/shared/streams/server/routes/internal/streams/onboarding/route.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -10,10 +10,10 @@ import { BooleanFromString } from '@kbn/zod-helpers/v4'; @@
     import type { OnboardingResult, TaskResult } from '@kbn/streams-schema';
     import { OnboardingStep } from '@kbn/streams-schema';
     import { STREAMS_API_PRIVILEGES } from '../../../../../common/constants';
-    import type { OnboardingTaskParams } from '../../../../lib/tasks/task_definitions/onboarding';
     import {
       getOnboardingTaskId,
       STREAMS_ONBOARDING_TASK_TYPE,
+      type OnboardingTaskParams,
     } from '../../../../lib/tasks/task_definitions/onboarding';
     import { createServerRoute } from '../../../create_server_route';
     import { assertSignificantEventsAccess } from '../../../utils/assert_significant_events_access';
@@ Expand Down @@

x-pack/platform/plugins/shared/streams_app/moon.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -107,6 +107,7 @@ dependsOn: @@
       - '@kbn/inference-endpoint-ui-common'
       - '@kbn/stack-connectors-plugin'
       - '@kbn/std'
+      - '@kbn/streams-ai'
       - '@kbn/cps'
     tags:
       - plugin
@@ Expand Down @@

...sig_events/significant_events_discovery/components/queries_table/query_details_flyout.tsx

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -10,7 +10,6 @@ import {
  
      EuiButton,

      EuiButtonEmpty,

      EuiButtonIcon,

      EuiCodeBlock,

      EuiConfirmModal,

      EuiContextMenuItem,

      EuiContextMenuPanel,

    @@ -30,33 +29,19 @@ import {
  
      EuiText,

      EuiTextArea,

      EuiTitle,

      EuiToolTip,

      useEuiTheme,

      useGeneratedHtmlId,

    } from '@elastic/eui';

    import { css } from '@emotion/react';

    import { i18n } from '@kbn/i18n';

    import React, { useEffect, useMemo, useState } from 'react';

    import { StreamsESQLEditor } from '../../../../esql_query_editor';

    import React, { useEffect, useState } from 'react';

    import type { SignificantEventItem } from '../../../../../hooks/sig_events/use_fetch_significant_events';

    import { StreamsESQLEditor } from '../../../../esql_query_editor';

    import { InfoPanel } from '../../../../info_panel';

    import { SparkPlot } from '../../../../spark_plot';

    import { SeveritySelector } from '../../../stream_detail_significant_events_view/add_significant_event_flyout/common/severity_selector';

    import { SeveritySelector } from '../severity_selector';

    import { SeverityBadge } from '../severity_badge/severity_badge';

    import {

      BACKED_STATUS_COLUMN,

      IMPACT_COLUMN,

      LAST_OCCURRED_COLUMN,

      NOT_PROMOTED_BADGE_LABEL,

      NOT_PROMOTED_TOOLTIP_CONTENT,

      OCCURRENCES_COLUMN,

      OCCURRENCES_TOOLTIP_NAME,

      PROMOTED_BADGE_LABEL,

      PROMOTED_TOOLTIP_CONTENT,

      STREAM_COLUMN,

    } from './translations';

    import { formatLastOccurredAt } from './utils';

    import { AssetImage } from '../../../../asset_image';

    import { OCCURRENCES_COLUMN, OCCURRENCES_TOOLTIP_NAME } from './translations';

    interface QueryDetailsFlyoutProps {

      item: SignificantEventItem;

    @@ -99,14 +84,6 @@ export function QueryDetailsFlyout({
  
        setSeverityScore(item.query.severity_score);

      }, [item]);

      const lastOccurredAt = useMemo(

        () => formatLastOccurredAt(item.occurrences, DEFAULT_QUERY_PLACEHOLDER),

        [item.occurrences]

      );

      const hasDetectedOccurrences = useMemo(

        () => item.occurrences.some((occurrence) => occurrence.y > 0),

        [item.occurrences]

      );

      const isSaveDisabled = !title.trim() || !query.trim() || isSaving;

      const handleCancelEdit = () => {

    @@ -131,12 +108,14 @@ export function QueryDetailsFlyout({
  
      };

      const infoListItems = [

        {

          title: TYPE_LABEL,

          description: <EuiBadge color="hollow">{QUERY_TYPE_BADGE_LABEL}</EuiBadge>,

        },

        {

          title: QUERY_LABEL,

          description: (

            <EuiCodeBlock language="esql" paddingSize="none" transparentBackground>

              {getDisplayQueryValue(item)}

            </EuiCodeBlock>

            <EuiText size="s">{getQueryInputValue(item) || DEFAULT_QUERY_PLACEHOLDER}</EuiText>

          ),

        },

        {

    @@ -146,30 +125,9 @@ export function QueryDetailsFlyout({
  
          ),

        },

        {

          title: IMPACT_COLUMN,

          title: SEVERITY_DETAILS_LABEL,

          description: <SeverityBadge score={item.query.severity_score} />,

        },

        {

          title: LAST_OCCURRED_COLUMN,

          description: <EuiText size="s">{lastOccurredAt}</EuiText>,

        },

        {

          title: STREAM_COLUMN,

          description: <EuiBadge color="hollow">{item.stream_name}</EuiBadge>,

        },

        {

          title: BACKED_STATUS_COLUMN,

          description: (

            <EuiToolTip

              content={item.rule_backed ? PROMOTED_TOOLTIP_CONTENT : NOT_PROMOTED_TOOLTIP_CONTENT}

            >

              <span tabIndex={0}>

                {item.rule_backed && <EuiBadge color="hollow">{PROMOTED_BADGE_LABEL}</EuiBadge>}

                {!item.rule_backed && <EuiBadge color="warning">{NOT_PROMOTED_BADGE_LABEL}</EuiBadge>}

              </span>

            </EuiToolTip>

          ),

        },

      ];

      return (

    @@ -193,6 +151,7 @@ export function QueryDetailsFlyout({
  
                  <EuiFlexGroup gutterSize="xs" responsive={false}>

                    <EuiFlexItem grow={false}>

                      <EuiPopover

                        aria-label={ACTIONS_BUTTON_ARIA_LABEL}

                        button={

                          <EuiButtonIcon

                            data-test-subj="queriesTableQueryDetailsFlyoutActionsButton"

    @@ -275,29 +234,14 @@ export function QueryDetailsFlyout({
  
                  </EuiFlexItem>

                  <EuiFlexItem>

                    <InfoPanel title={OCCURRENCES_COLUMN}>

                      {hasDetectedOccurrences ? (

                        <SparkPlot

                          id={`query-details-occurrences-${item.query.id}`}

                          name={OCCURRENCES_TOOLTIP_NAME}

                          type="bar"

                          timeseries={item.occurrences}

                          annotations={[]}

                          height={160}

                        />

                      ) : (

                        <EuiFlexGroup

                          direction="column"

                          gutterSize="s"

                          alignItems="center"

                          justifyContent="center"

                          css={{ height: '100%', minHeight: '200px', padding: '30px' }}

                        >

                          <AssetImage type="barChart" size="xs" />

                          <EuiText color="subdued" size="s" textAlign="center">

                            {NO_OCCURRENCES_DESCRIPTION}

                          </EuiText>

                        </EuiFlexGroup>

                      )}

                      <SparkPlot

                        id={`query-details-occurrences-${item.query.id}`}

                        name={OCCURRENCES_TOOLTIP_NAME}

                        type="bar"

                        timeseries={item.occurrences}

                        annotations={[]}

                        height={160}

                      />

                    </InfoPanel>

                  </EuiFlexItem>

                </EuiFlexGroup>

    @@ -397,16 +341,21 @@ function getQueryInputValue(item: SignificantEventItem) {
  
      return item.query.esql?.query ?? '';

    }

    function getDisplayQueryValue(item: SignificantEventItem) {

      const queryText = getQueryInputValue(item);

      return queryText || DEFAULT_QUERY_PLACEHOLDER;

    }

    const QUERY_INFORMATION_TITLE = i18n.translate(

      'xpack.streams.significantEventsDiscovery.queryDetailsFlyout.queryInformationTitle',

      { defaultMessage: 'Query information' }

    );

    const TYPE_LABEL = i18n.translate(

      'xpack.streams.significantEventsDiscovery.queryDetailsFlyout.typeLabel',

      { defaultMessage: 'Type' }

    );

    const QUERY_TYPE_BADGE_LABEL = i18n.translate(

      'xpack.streams.significantEventsDiscovery.queryDetailsFlyout.queryTypeBadgeLabel',

      { defaultMessage: 'Query' }

    );

    const EDIT_QUERY_TITLE = i18n.translate(

      'xpack.streams.significantEventsDiscovery.queryDetailsFlyout.editQueryTitle',

      { defaultMessage: 'Edit query' }

    @@ -437,6 +386,11 @@ const SEVERITY_LABEL = i18n.translate(
  
      { defaultMessage: 'Severity' }

    );

    const SEVERITY_DETAILS_LABEL = i18n.translate(

      'xpack.streams.significantEventsDiscovery.queryDetailsFlyout.severityDetailsLabel',

      { defaultMessage: 'Severity' }

    );

    const ACTIONS_BUTTON_ARIA_LABEL = i18n.translate(

      'xpack.streams.significantEventsDiscovery.queryDetailsFlyout.actionsButtonAriaLabel',

      { defaultMessage: 'Actions' }

    @@ -483,11 +437,3 @@ const DELETE_CONFIRM_BUTTON_LABEL = i18n.translate(
  
      'xpack.streams.significantEventsDiscovery.queryDetailsFlyout.deleteConfirmButtonLabel',

      { defaultMessage: 'Delete query' }

    );

    const NO_OCCURRENCES_DESCRIPTION = i18n.translate(

      'xpack.streams.significantEventsDiscovery.queryDetailsFlyout.noOccurrencesDescription',

      {

        defaultMessage:

          "We currently don't detect any events. You can leave it, as it might happen later or modify the query.",

      }

    );

...iew/add_significant_event_flyout/types.ts → ...ery/components/severity_selector/index.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -5,10 +5,4 @@ @@
      * 2.0.
      */
-    import type { StreamQuery } from '@kbn/streams-schema';
-    export type Flow = 'manual' | 'ai';
-    export type SaveData =
-      | { type: 'single'; query: StreamQuery; isUpdating?: boolean }
-      | { type: 'multiple'; queries: StreamQuery[] };
+    export { SeveritySelector } from './severity_selector';

...event_flyout/common/severity_selector.tsx → ...s/severity_selector/severity_selector.tsx

-Original file line number
+Diff line change
@@ Expand Up / @@ -12,7 +12,7 @@ import { @@
       SeverityBadge,
       SIGNIFICANT_EVENT_SEVERITY,
       scoreSeverity,
-    } from '../../../significant_events_discovery/components/severity_badge/severity_badge';
+    } from '../severity_badge/severity_badge';
     export function SeveritySelector({
       severityScore,
@@ Expand All / @@ -36,6 +36,7 @@ export function SeveritySelector({ @@
       return (
         <EuiSuperSelect
+          aria-label={SEVERITY_SELECTOR_ARIA_LABEL}
           disabled={disabled}
           options={severityOptions}
           valueOfSelected={
@@ Expand All / @@ -53,3 +54,10 @@ export function SeveritySelector({ @@
         />
       );
     }
+    const SEVERITY_SELECTOR_ARIA_LABEL = i18n.translate(
+      'xpack.streams.significantEvents.severitySelector.ariaLabel',
+      {
+        defaultMessage: 'Select severity',
+      }
+    );

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Sig Events] Unified KIs table in Stream details UI #259553

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!