[Discover] Preserve data view references for by-value panels on dashboard save#256997
Merged
lukasolson merged 2 commits intoelastic:mainfrom Mar 11, 2026
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Bluefinger
approved these changes
Mar 11, 2026
Contributor
Bluefinger
left a comment
There was a problem hiding this comment.
Tested the changes with #256293, so I can confirm this works and solves the issue there.
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @lukasolson |
AlexGPlay
approved these changes
Mar 11, 2026
sorenlouv
pushed a commit
that referenced
this pull request
Mar 17, 2026
…oard save (#256997) ## Summary Resolves #256943. Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error: `Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index`). This was a bug introduced in #252786. ### How to verify This problem really only surfaces in the UX after the changes in #256293. 1. Create a new dashboard → Add panel → Discover Session. 2. Save a default Classic mode session and return to the dashboard. 3. Save the dashboard and reload the page. 4. The Discover session panel should load without the "Could not find reference" error. Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…oard save (elastic#256997) ## Summary Resolves elastic#256943. Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error: `Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index`). This was a bug introduced in elastic#252786. ### How to verify This problem really only surfaces in the UX after the changes in elastic#256293. 1. Create a new dashboard → Add panel → Discover Session. 2. Save a default Classic mode session and return to the dashboard. 3. Save the dashboard and reload the page. 4. The Discover session panel should load without the "Could not find reference" error. Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #256943.
Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error:
Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index). This was a bug introduced in #252786.How to verify
This problem really only surfaces in the UX after the changes in #256293.