[Discover sessions as Code] Remove internal references array#252786
Merged
lukasolson merged 9 commits intoelastic:mainfrom Feb 20, 2026
Merged
Conversation
lukasolson
added
Team:DataDiscovery
…f github.com:lukasolson/kibana into discover_sessions_as_code/remove_internal_references
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
lukasolson
added
release_note:skip
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
cc @lukasolson |
davismcphee
approved these changes
Feb 19, 2026
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Tested locally using a dashboard from main as well as a new dashboard, both with a by ref and by val panel. Opened both in dashboard, inspected SO JSON and API shape, resaved, and checked again. All looked good to me 👍
| const { state: extractedState, references } = extract({ | ||
| type: SavedSearchType, | ||
| attributes: storedState.attributes, | ||
| const tabReferences: SavedObjectReference[] = []; |
Contributor
There was a problem hiding this comment.
Could it contain duplicates if e.g. multiple tabs reference the same data view? Doesn't seem like an issue for now since we only support one tab for by val, but mentioning since it doesn't seem like refs are namespaced by tab ID or anything.
Contributor
Author
There was a problem hiding this comment.
Yeah, currently we're not adding a prefix for the tab, but we could definitely add this later.
This was referenced Mar 10, 2026
lukasolson
added a commit
that referenced
this pull request
Mar 11, 2026
…oard save (#256997) ## Summary Resolves #256943. Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error: `Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index`). This was a bug introduced in #252786. ### How to verify This problem really only surfaces in the UX after the changes in #256293. 1. Create a new dashboard → Add panel → Discover Session. 2. Save a default Classic mode session and return to the dashboard. 3. Save the dashboard and reload the page. 4. The Discover session panel should load without the "Could not find reference" error. Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
sorenlouv
pushed a commit
that referenced
this pull request
Mar 17, 2026
…oard save (#256997) ## Summary Resolves #256943. Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error: `Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index`). This was a bug introduced in #252786. ### How to verify This problem really only surfaces in the UX after the changes in #256293. 1. Create a new dashboard → Add panel → Discover Session. 2. Save a default Classic mode session and return to the dashboard. 3. Save the dashboard and reload the page. 4. The Discover session panel should load without the "Could not find reference" error. Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…oard save (elastic#256997) ## Summary Resolves elastic#256943. Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error: `Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index`). This was a bug introduced in elastic#252786. ### How to verify This problem really only surfaces in the UX after the changes in elastic#256293. 1. Create a new dashboard → Add panel → Discover Session. 2. Save a default Classic mode session and return to the dashboard. 3. Save the dashboard and reload the page. 4. The Discover session panel should load without the "Could not find reference" error. Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #239970.
Stored panel state no longer has
attributes.references. Search source refs (data view, filter indices) are in the dashboard’s top-levelreferencesand are extracted intransformInand injected intransformOutusing the same logic as inextract_references.ts/inject_references.ts