[Discover][Embeddable] Add New Discover session for Dashboards by Bluefinger · Pull Request #256293 · elastic/kibana

Bluefinger · 2026-03-05T16:49:01Z

Summary

This PR adds a new button in the New Panel options of the Dashboard to embed a Discover By-Value session directly. This opens Discover in embeddable editor mode, and creates the panel with the By-value session saved.

Screen.Recording.2026-03-06.151406.mp4

Closes #249104

How to test

Go to Dashboards and create a new Dashboard
Click on the Add button and then click New Panel
Click on Discover session and edit the session, saving it once done.
Should return to Dashboards with a Discover panel created with the same view/configuration as during the editing.

TODOs

Initial working code
Polish & refinement
Functional tests

Bluefinger · 2026-03-06T12:43:11Z

/ci

elasticmachine · 2026-03-06T15:10:09Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

nreese

kibana-presentation changes LGTM
code review only

ThomThomson · 2026-03-06T20:40:43Z

Just chiming in to say that this has been a long time coming and I'm really happy to see this change.

davismcphee

Code changes look good and it works well overall! Left a bit of minor feedback, but otherwise all good code wise. I did encounter one error case I think we should try to fix before merging.

MiloszRadzynski

LGTM 🚀, I just left a minor nit. I won't approve it because there are still pending requests from @davismcphee

kibanamachine · 2026-03-09T16:52:54Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11014

[❌] src/platform/test/functional/apps/discover/embeddable/config.ts: 0/30 tests passed.

see run history

kibanamachine · 2026-03-09T18:12:02Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#11016

[✅] src/platform/test/functional/apps/discover/embeddable/config.ts: 30/30 tests passed.

see run history

davismcphee

Thanks for the updates! Seems close overall, but I tested again and found a couple more issues to look into.

…oard save (#256997) ## Summary Resolves #256943. Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error: `Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index`). This was a bug introduced in #252786. ### How to verify This problem really only surfaces in the UX after the changes in #256293. 1. Create a new dashboard → Add panel → Discover Session. 2. Save a default Classic mode session and return to the dashboard. 3. Save the dashboard and reload the page. 4. The Discover session panel should load without the "Could not find reference" error. Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>

elasticmachine · 2026-03-11T17:28:51Z

💔 Build Failed

Buildkite Build
Commit: 0615576

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #27 / Cloud Security Posture Vulnerability Dashboard API responds with a 200 status code and matching data mock
[job] [logs] FTR Configs #27 / Cloud Security Posture Vulnerability Dashboard API responds with a 200 status code and matching data mock

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`discover`	1986	1987	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	1.6MB	1.6MB	+1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	25.5KB	25.7KB	+223.0B

History

💔 Build #406605 failed 4496413
💚 Build #405870 succeeded 5cd10ba
💔 Build #405773 failed bdbb4ae

cc @Bluefinger

Bluefinger · 2026-03-12T09:42:34Z

I tested this with the rebased main branch now that the fixes are in, and confirm this works.

davismcphee

Latest changes look good, and I tested the two remaining scenarios and both are working as expected now. Glad we were able to get the other fix merged first. Thanks!

davismcphee · 2026-03-12T20:21:29Z

+/**
+ * Specifies the action to be taken for navigating back to an editor.
+ */
+export enum TransferAction {
+  /**
+   * A Cancel operation. Returns to the editor without modifying the original state.
+   */
+  Cancel,
+  /**
+   * A Save Session operation. Updates the saved session and doesn't pass back any serialised state.
+   */
+  SaveSession,
+  /**
+   * A Save By Value operation. Sends back to the editor the serialised updated state for the embeddable.
+   */
+  SaveByValue,
+}


I like this approach 👌

davismcphee · 2026-03-12T20:21:38Z

+  public transferBackToEditor(action: TransferAction.Cancel | TransferAction.SaveSession): void;
+  public transferBackToEditor(
+    action: TransferAction.SaveByValue,
+    state: SavedSearchByValueAttributes
+  ): void;
+  public transferBackToEditor(action: TransferAction, state?: SavedSearchByValueAttributes): void;


You're one of few to make good use of function overloading in TS! 😄

All this would be unnecessary if TS had Rust-like enums and pattern-matching 😅

I'm so rust-brained...

@florent-leborgne

…257835) ## Summary Related to #256293 (comment). Synced with @florent-leborgne offline, and we agreed not to use "by-value" in the UI copy. Instead just going with "New Discover session" in the breadcrumb when adding a new Discover panel to a dashboard: <img src="https://github.com/user-attachments/assets/c051ea00-d721-47d1-a88b-063020e2a092" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.

…oard save (#256997) ## Summary Resolves #256943. Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error: `Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index`). This was a bug introduced in #252786. ### How to verify This problem really only surfaces in the UX after the changes in #256293. 1. Create a new dashboard → Add panel → Discover Session. 2. Save a default Classic mode session and return to the dashboard. 3. Save the dashboard and reload the page. 4. The Discover session panel should load without the "Could not find reference" error. Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>

## Summary This PR adds a new button in the New Panel options of the Dashboard to embed a Discover By-Value session directly. This opens Discover in embeddable editor mode, and creates the panel with the By-value session saved. https://github.com/user-attachments/assets/9efa383f-7dd5-4bd8-8112-5dd140d68635 Closes #249104 ## How to test - Go to Dashboards and create a new Dashboard - Click on the Add button and then click New Panel - Click on Discover session and edit the session, saving it once done. - Should return to Dashboards with a Discover panel created with the same view/configuration as during the editing. ## TODOs - [x] Initial working code - [x] Polish & refinement - [x] Functional tests

@florent-leborgne

…257835) ## Summary Related to #256293 (comment). Synced with @florent-leborgne offline, and we agreed not to use "by-value" in the UI copy. Instead just going with "New Discover session" in the breadcrumb when adding a new Discover panel to a dashboard: <img src="https://github.com/user-attachments/assets/c051ea00-d721-47d1-a88b-063020e2a092" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.

…oard save (elastic#256997) ## Summary Resolves elastic#256943. Fixes by-value Classic mode Discover Session panels failing to load after saving and reloading a dashboard (error: `Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index`). This was a bug introduced in elastic#252786. ### How to verify This problem really only surfaces in the UX after the changes in elastic#256293. 1. Create a new dashboard → Add panel → Discover Session. 2. Save a default Classic mode session and return to the dashboard. 3. Save the dashboard and reload the page. 4. The Discover session panel should load without the "Could not find reference" error. Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>

…ic#256293) ## Summary This PR adds a new button in the New Panel options of the Dashboard to embed a Discover By-Value session directly. This opens Discover in embeddable editor mode, and creates the panel with the By-value session saved. https://github.com/user-attachments/assets/9efa383f-7dd5-4bd8-8112-5dd140d68635 Closes elastic#249104 ## How to test - Go to Dashboards and create a new Dashboard - Click on the Add button and then click New Panel - Click on Discover session and edit the session, saving it once done. - Should return to Dashboards with a Discover panel created with the same view/configuration as during the editing. ## TODOs - [x] Initial working code - [x] Polish & refinement - [x] Functional tests

@florent-leborgne

…lastic#257835) ## Summary Related to elastic#256293 (comment). Synced with @florent-leborgne offline, and we agreed not to use "by-value" in the UI copy. Instead just going with "New Discover session" in the breadcrumb when adding a new Discover panel to a dashboard: <img src="https://github.com/user-attachments/assets/c051ea00-d721-47d1-a88b-063020e2a092" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.

[Discover][Embeddable] Add New Discover session for Dashboards

2f1630d

Bluefinger added release_note:enhancement backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.4.0 labels Mar 5, 2026

Bluefinger added 5 commits March 6, 2026 10:30

Merge branch 'main' into discover-dashboard-add-new-session

5234bd5

Add label for new session

1c12eb9

Add initial pass at functional tests

bdbb4ae

Merge branch 'main' into discover-dashboard-add-new-session

40ac12d

Update dashboard panel type count assertions

5cd10ba

Bluefinger marked this pull request as ready for review March 6, 2026 15:10

Bluefinger requested review from a team as code owners March 6, 2026 15:10

nreese approved these changes Mar 6, 2026

View reviewed changes

davismcphee reviewed Mar 8, 2026

View reviewed changes

Merge branch 'main' into discover-dashboard-add-new-session

4496413

kertal assigned Bluefinger Mar 9, 2026

MiloszRadzynski reviewed Mar 9, 2026

View reviewed changes

Comment thread src/platform/plugins/shared/discover/public/plugin_imports/ui_actions.ts Outdated

Comment thread src/platform/plugins/shared/discover/public/plugin_imports/ui_actions.ts Outdated

Refactor action, add cancel test

5406544

Bluefinger requested a review from davismcphee March 9, 2026 15:57

davismcphee reviewed Mar 9, 2026

View reviewed changes

Better transfer API

f4b142e

Bluefinger mentioned this pull request Mar 10, 2026

[Discover][Embeddable] By-Value Classic mode Discover session panels fail to load from saved dashboard #256943

Closed

lukasolson mentioned this pull request Mar 10, 2026

[Discover] Preserve data view references for by-value panels on dashboard save #256997

Merged

Don't forget resets

cad5d6f

Merge branch 'main' into discover-dashboard-add-new-session

259b249

Bluefinger added 2 commits March 11, 2026 16:39

Merge branch 'main' into discover-dashboard-add-new-session

db85bf2

Merge branch 'main' into discover-dashboard-add-new-session

0615576

Merge branch 'main' into discover-dashboard-add-new-session

e205918

Bluefinger requested a review from davismcphee March 12, 2026 14:24

davismcphee approved these changes Mar 12, 2026

View reviewed changes

Bluefinger merged commit 735035d into elastic:main Mar 13, 2026
18 checks passed

davismcphee mentioned this pull request Mar 16, 2026

[Discover] [Dashboard] Update breadcrumb copy for new Discover panel #257835

Merged

8 tasks

florent-leborgne mentioned this pull request Mar 31, 2026

Create new Discover session panels directly from the dashboard Add menu elastic/docs-content#5703

Closed

Copilot AI mentioned this pull request Apr 17, 2026

docs: Add Discover session panel creation from dashboard Add menu elastic/docs-content#5974

Merged

kertal mentioned this pull request Apr 28, 2026

[Discuss] Ability to add new saved search from a dashboard #58764

Closed

Conversation

Bluefinger commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

TODOs

Uh oh!

Bluefinger commented Mar 6, 2026

Uh oh!

elasticmachine commented Mar 6, 2026

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiloszRadzynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Mar 9, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11014

Uh oh!

kibanamachine commented Mar 9, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#11016

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Bluefinger commented Mar 12, 2026

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

davismcphee Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

davismcphee Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Bluefinger Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Bluefinger commented Mar 5, 2026 •

edited

Loading

ThomThomson commented Mar 6, 2026 •

edited

Loading

elasticmachine commented Mar 11, 2026 •

edited

Loading