-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ResponseOps][Reporting] stop toasting "Could not check Reporting job status!" #245184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… status!" resolves elastic#216181 Removes the toast that popped up, every few seconds, informing us that "Could not check Reporting job status!", when Kibana goes down. Not useful, so removed.
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
|
Pinging @elastic/response-ops (Team:ResponseOps) |
| ); | ||
| window.console.error(err); | ||
| // Seems to only occur when the connection to Kibana fails. | ||
| // We used to toast here, but ... it was very noisy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmuellr I think it’d be better to keep the error toast, just make it behave more user-friendly. I have two suggestions:
-
Use the polling interval to control toast lifetime
We start polling with an interval here.
We could pass thisintervalto thefindChangedStatusJobsmethod and then set{ toastLifeTimeMs: interval }when callingtoasts.addDanger. -
Track and remove the existing toast
- Define
private connectionErrorToast: Toast | undefined; - Assign it when showing the toast:
this.connectionErrorToast = this.core.notifications.toasts.addDanger(...) - In each
findChangedStatusJobscall, check if it exists and remove it:
this.core.notifications.toasts.remove(this.connectionErrorToast);
WDYT?
In addition to those, I think the only reason to keep the toast is if Kibana isn't actually down, but the job polling is generating errors. So that means it needs to be tied into Kibana availability as well. So ... it gets complicated. I'm going to suggest we defer that to a separate issue. My experience is the only time these toasts are ever seen is when Kibana is down / inaccessible, in which case the system provide a standard not-toast message about Kibana not being available. So right now, they add no value, and in fact may obscure the system-generated not-toast message (visually). |
|
Starting backport for target branches: 8.19, 9.1, 9.2 https://github.com/elastic/kibana/actions/runs/20117036141 |
… status!" (elastic#245184) resolves elastic#216181 Removes the toast that popped up, every few seconds, informing us that "Could not check Reporting job status!", when Kibana becomes unavailable. Not useful, so removed. (cherry picked from commit b53f22d)
…ng job status!" (#245184) (#245937) # Backport This will backport the following commits from `main` to `9.2`: - [[ResponseOps][Reporting] stop toasting "Could not check Reporting job status!" (#245184)](#245184) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Patrick Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-12-10T23:50:35Z","message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport:all-open","Feature:Reporting:Framework","Feature:Reporting:Screenshot","v9.3.0"],"title":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\"","number":245184,"url":"https://github.com/elastic/kibana/pull/245184","mergeCommit":{"message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245184","number":245184,"mergeCommit":{"message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821"}}]}] BACKPORT--> Co-authored-by: Patrick Mueller <patrick.mueller@elastic.co>
… status!" (elastic#245184) resolves elastic#216181 Removes the toast that popped up, every few seconds, informing us that "Could not check Reporting job status!", when Kibana becomes unavailable. Not useful, so removed. (cherry picked from commit b53f22d) # Conflicts: # x-pack/platform/plugins/private/translations/translations/de-DE.json
… status!" (elastic#245184) resolves elastic#216181 Removes the toast that popped up, every few seconds, informing us that "Could not check Reporting job status!", when Kibana becomes unavailable. Not useful, so removed. (cherry picked from commit b53f22d) # Conflicts: # x-pack/platform/plugins/private/translations/translations/de-DE.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ng job status!" (#245184) (#245945) # Backport This will backport the following commits from `main` to `9.1`: - [[ResponseOps][Reporting] stop toasting "Could not check Reporting job status!" (#245184)](#245184) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Patrick Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-12-10T23:50:35Z","message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport:all-open","Feature:Reporting:Framework","Feature:Reporting:Screenshot","v9.3.0"],"title":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\"","number":245184,"url":"https://github.com/elastic/kibana/pull/245184","mergeCommit":{"message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245184","number":245184,"mergeCommit":{"message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821"}},{"url":"https://github.com/elastic/kibana/pull/245937","number":245937,"branch":"9.2","state":"OPEN"}]}] BACKPORT-->
…ing job status!" (#245184) (#245946) # Backport This will backport the following commits from `main` to `8.19`: - [[ResponseOps][Reporting] stop toasting "Could not check Reporting job status!" (#245184)](#245184) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Patrick Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-12-10T23:50:35Z","message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport:all-open","Feature:Reporting:Framework","Feature:Reporting:Screenshot","v9.3.0"],"title":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\"","number":245184,"url":"https://github.com/elastic/kibana/pull/245184","mergeCommit":{"message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245184","number":245184,"mergeCommit":{"message":"[ResponseOps][Reporting] stop toasting \"Could not check Reporting job status!\" (#245184)\n\nresolves https://github.com/elastic/kibana/issues/216181\n\nRemoves the toast that popped up, every few seconds, informing us that\n\"Could not check Reporting job status!\", when Kibana becomes\nunavailable. Not useful, so removed.","sha":"b53f22d6c324a7e2362197731d17562d01dd5821"}},{"url":"https://github.com/elastic/kibana/pull/245937","number":245937,"branch":"9.2","state":"OPEN"}]}] BACKPORT-->
… status!" (elastic#245184) resolves elastic#216181 Removes the toast that popped up, every few seconds, informing us that "Could not check Reporting job status!", when Kibana becomes unavailable. Not useful, so removed.
resolves #216181
Summary
Removes the toast that popped up, every few seconds, informing us that "Could not check Reporting job status!", when Kibana becomes unavailable. Not useful, so removed.
To validate
Reproduce the old behaviour on
main:With this PR, the infinite toasts don't occur, but there is a
Failed to fetchthat is not a toast like other one, just a message that's updated with a recurring count.Not sure where this is coming from, guessing it may be an ES client thing, where we're still making the ES requests to check the status. I think this is survivable - the infinite toasts was maddening! We can open an issue later if this becomes problematic. We'd probably need to hook into some ES available observer, and start/stop the status checks around that, which could get complicated ...
a little later ...
While investigating and repro-ing a separate DOS issue in Kibana, I happened to notice the
Failed to fetchmessage appear in a completely unrelated UX. This seems right to me, that somehow the platform is generating these. Makes sense, and I think that means the lingering "not nearly as annoying as the infinite toast" messageFailed to fetchis fine ...