Address @elastic/eui/require-table-caption lint violations across @elastic/kibana-presentation files
#245661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@elastic/kibana-presentation` files
alexwizp
added
Project:Accessibility
release_note:skip
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
nreese
approved these changes
Dec 9, 2025
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
Contributor
|
Starting backport for target branches: 9.1, 9.2 https://github.com/elastic/kibana/actions/runs/20100956654 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Dec 12, 2025
…@elastic/kibana-presentation` files (elastic#245661) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/require-table-caption`. This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a `tableCaption` prop for accessibility. ## Changes 1. 🎯 Added missing `tableCaption` attributes to elements flagged by `@elastic/eui/require-table-caption` — accessibility leveled up! ## Related - elastic/eui#9168 This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team! (cherry picked from commit b9aa07a) # Conflicts: # x-pack/platform/plugins/private/canvas/public/components/home/my_workpads/workpad_table.component.tsx
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Dec 12, 2025
…@elastic/kibana-presentation` files (elastic#245661) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/require-table-caption`. This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a `tableCaption` prop for accessibility. ## Changes 1. 🎯 Added missing `tableCaption` attributes to elements flagged by `@elastic/eui/require-table-caption` — accessibility leveled up! ## Related - elastic/eui#9168 This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team! (cherry picked from commit b9aa07a) # Conflicts: # x-pack/platform/plugins/private/canvas/public/components/home/my_workpads/workpad_table.component.tsx
alexwizp
added a commit
that referenced
this pull request
Dec 12, 2025
…ross `@elastic/kibana-presentation` files (#245661) (#246259) # Backport This will backport the following commits from `main` to `9.2`: - [Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files (#245661)](#245661) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-12-10T13:52:49Z","message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files (#245661)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!","sha":"b9aa07afbd0d060c3c4dcc45d158ddb20140b857","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport missing","backport:version","v9.3.0","v9.2.3","v9.1.9"],"title":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files","number":245661,"url":"https://github.com/elastic/kibana/pull/245661","mergeCommit":{"message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files (#245661)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!","sha":"b9aa07afbd0d060c3c4dcc45d158ddb20140b857"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245661","number":245661,"mergeCommit":{"message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files (#245661)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!","sha":"b9aa07afbd0d060c3c4dcc45d158ddb20140b857"}},{"branch":"9.2","label":"v9.2.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
alexwizp
added a commit
that referenced
this pull request
Dec 12, 2025
…ross `@elastic/kibana-presentation` files (#245661) (#246260) # Backport This will backport the following commits from `main` to `9.1`: - [Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files (#245661)](#245661) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-12-10T13:52:49Z","message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files (#245661)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!","sha":"b9aa07afbd0d060c3c4dcc45d158ddb20140b857","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport missing","backport:version","v9.3.0","v9.2.3","v9.1.9"],"title":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files","number":245661,"url":"https://github.com/elastic/kibana/pull/245661","mergeCommit":{"message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files (#245661)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!","sha":"b9aa07afbd0d060c3c4dcc45d158ddb20140b857"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245661","number":245661,"mergeCommit":{"message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/kibana-presentation` files (#245661)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!","sha":"b9aa07afbd0d060c3c4dcc45d158ddb20140b857"}},{"branch":"9.2","label":"v9.2.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/246259","number":246259,"state":"OPEN"},{"branch":"9.1","label":"v9.1.9","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/require-table-caption.This rule ensure
EuiInMemoryTable,EuiBasicTablehave atableCaptionprop for accessibility.Changes
tableCaptionattributes to elements flagged by@elastic/eui/require-table-caption— accessibility leveled up!Related
@elastic/eslint-plugin-eui] added newrequire-table-captionrule. eui#9168This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team!