-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Quick checks single push #244605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick checks single push #244605
Conversation
695f183 to
fb3bafb
Compare
jloleysens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core's 🌔 and TS config files LGTM
|
Thanks @jloleysens! I should have picked something within our own domain to not involve you as reviewers, it was just testing if the correction works :) but thanks! 👍 |
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Starting backport for target branches: 8.19, 9.1, 9.2 https://github.com/elastic/kibana/actions/runs/20307905801 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
## Summary In elastic#237905, we've sequentialized the quick checks earlier in order not to get the changed files checker to mix up which check had modified the files during checking. This however, caused an issue, where quick-checks would only fix one batch of errors per run. This PR would try to commit multiple change batches throughout the quick-check's fixing phase, and push only once to trigger a single, fixed run. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit df58d59) # Conflicts: # src/core/test-helpers/kbn-server/moon.yml # x-pack/solutions/observability/plugins/apm/test/scout/.meta/ui/parallel.json
## Summary In elastic#237905, we've sequentialized the quick checks earlier in order not to get the changed files checker to mix up which check had modified the files during checking. This however, caused an issue, where quick-checks would only fix one batch of errors per run. This PR would try to commit multiple change batches throughout the quick-check's fixing phase, and push only once to trigger a single, fixed run. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit df58d59) # Conflicts: # .buildkite/scripts/steps/security/dependencies_diff.ts # src/core/test-helpers/kbn-server/moon.yml # x-pack/solutions/observability/plugins/apm/test/scout/.meta/ui/parallel.json
## Summary In elastic#237905, we've sequentialized the quick checks earlier in order not to get the changed files checker to mix up which check had modified the files during checking. This however, caused an issue, where quick-checks would only fix one batch of errors per run. This PR would try to commit multiple change batches throughout the quick-check's fixing phase, and push only once to trigger a single, fixed run. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit df58d59) # Conflicts: # .buildkite/scripts/steps/security/dependencies_diff.ts # src/core/test-helpers/kbn-server/moon.yml
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
12 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
# Backport This will backport the following commits from `main` to `9.2`: - [Quick checks single push (#244605)](#244605) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-12-11T12:49:28Z","message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport missing","backport:all-open","v9.3.0"],"title":"Quick checks single push","number":244605,"url":"https://github.com/elastic/kibana/pull/244605","mergeCommit":{"message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244605","number":244605,"mergeCommit":{"message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
# Backport This will backport the following commits from `main` to `9.1`: - [Quick checks single push (#244605)](#244605) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-12-11T12:49:28Z","message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport missing","backport:all-open","v9.3.0"],"title":"Quick checks single push","number":244605,"url":"https://github.com/elastic/kibana/pull/244605","mergeCommit":{"message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244605","number":244605,"mergeCommit":{"message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
# Backport This will backport the following commits from `main` to `8.19`: - [Quick checks single push (#244605)](#244605) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-12-11T12:49:28Z","message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport missing","backport:all-open","v9.3.0"],"title":"Quick checks single push","number":244605,"url":"https://github.com/elastic/kibana/pull/244605","mergeCommit":{"message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244605","number":244605,"mergeCommit":{"message":"Quick checks single push (#244605)\n\n## Summary\nIn #237905, we've sequentialized the quick checks earlier in order not\nto get the changed files checker to mix up which check had modified the\nfiles during checking.\n\nThis however, caused an issue, where quick-checks would only fix one\nbatch of errors per run.\n\nThis PR would try to commit multiple change batches throughout the\nquick-check's fixing phase, and push only once to trigger a single,\nfixed run.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
In #237905, we've sequentialized the quick checks earlier in order not to get the changed files checker to mix up which check had modified the files during checking.
This however, caused an issue, where quick-checks would only fix one batch of errors per run.
This PR would try to commit multiple change batches throughout the quick-check's fixing phase, and push only once to trigger a single, fixed run.