Skip to content

Conversation

@delanni
Copy link
Contributor

@delanni delanni commented Nov 28, 2025

Summary

In #237905, we've sequentialized the quick checks earlier in order not to get the changed files checker to mix up which check had modified the files during checking.

This however, caused an issue, where quick-checks would only fix one batch of errors per run.

This PR would try to commit multiple change batches throughout the quick-check's fixing phase, and push only once to trigger a single, fixed run.

@delanni delanni force-pushed the quick-checks-single-push branch from 695f183 to fb3bafb Compare November 28, 2025 12:30
@delanni delanni marked this pull request as ready for review November 28, 2025 12:30
@delanni delanni requested review from a team as code owners November 28, 2025 12:30
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core's 🌔 and TS config files LGTM

@delanni
Copy link
Contributor Author

delanni commented Nov 28, 2025

Thanks @jloleysens! I should have picked something within our own domain to not involve you as reviewers, it was just testing if the correction works :) but thanks! 👍

@delanni delanni added the Team:Operations Kibana-Operations Team label Nov 28, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Nov 28, 2025
@elastic elastic deleted a comment from elasticmachine Nov 28, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/20307905801

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts
9.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 244605

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts
9.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 244605

Questions ?

Please refer to the Backport tool documentation

delanni added a commit to delanni/kibana that referenced this pull request Dec 17, 2025
## Summary
In elastic#237905, we've sequentialized the quick checks earlier in order not
to get the changed files checker to mix up which check had modified the
files during checking.

This however, caused an issue, where quick-checks would only fix one
batch of errors per run.

This PR would try to commit multiple change batches throughout the
quick-check's fixing phase, and push only once to trigger a single,
fixed run.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit df58d59)

# Conflicts:
#	src/core/test-helpers/kbn-server/moon.yml
#	x-pack/solutions/observability/plugins/apm/test/scout/.meta/ui/parallel.json
delanni added a commit to delanni/kibana that referenced this pull request Dec 17, 2025
## Summary
In elastic#237905, we've sequentialized the quick checks earlier in order not
to get the changed files checker to mix up which check had modified the
files during checking.

This however, caused an issue, where quick-checks would only fix one
batch of errors per run.

This PR would try to commit multiple change batches throughout the
quick-check's fixing phase, and push only once to trigger a single,
fixed run.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit df58d59)

# Conflicts:
#	.buildkite/scripts/steps/security/dependencies_diff.ts
#	src/core/test-helpers/kbn-server/moon.yml
#	x-pack/solutions/observability/plugins/apm/test/scout/.meta/ui/parallel.json
delanni added a commit to delanni/kibana that referenced this pull request Dec 17, 2025
## Summary
In elastic#237905, we've sequentialized the quick checks earlier in order not
to get the changed files checker to mix up which check had modified the
files during checking.

This however, caused an issue, where quick-checks would only fix one
batch of errors per run.

This PR would try to commit multiple change batches throughout the
quick-check's fixing phase, and push only once to trigger a single,
fixed run.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit df58d59)

# Conflicts:
#	.buildkite/scripts/steps/security/dependencies_diff.ts
#	src/core/test-helpers/kbn-server/moon.yml
@delanni
Copy link
Contributor Author

delanni commented Dec 17, 2025

💚 All backports created successfully

Status Branch Result
9.2
9.1
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

12 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

delanni added a commit that referenced this pull request Jan 6, 2026
# Backport

This will backport the following commits from `main` to `9.2`:
- [Quick checks single push
(#244605)](#244605)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-12-11T12:49:28Z","message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport
missing","backport:all-open","v9.3.0"],"title":"Quick checks single
push","number":244605,"url":"https://github.com/elastic/kibana/pull/244605","mergeCommit":{"message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244605","number":244605,"mergeCommit":{"message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
delanni added a commit that referenced this pull request Jan 6, 2026
# Backport

This will backport the following commits from `main` to `9.1`:
- [Quick checks single push
(#244605)](#244605)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-12-11T12:49:28Z","message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport
missing","backport:all-open","v9.3.0"],"title":"Quick checks single
push","number":244605,"url":"https://github.com/elastic/kibana/pull/244605","mergeCommit":{"message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244605","number":244605,"mergeCommit":{"message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
delanni added a commit that referenced this pull request Jan 6, 2026
# Backport

This will backport the following commits from `main` to `8.19`:
- [Quick checks single push
(#244605)](#244605)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-12-11T12:49:28Z","message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport
missing","backport:all-open","v9.3.0"],"title":"Quick checks single
push","number":244605,"url":"https://github.com/elastic/kibana/pull/244605","mergeCommit":{"message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244605","number":244605,"mergeCommit":{"message":"Quick
checks single push (#244605)\n\n## Summary\nIn #237905, we've
sequentialized the quick checks earlier in order not\nto get the changed
files checker to mix up which check had modified the\nfiles during
checking.\n\nThis however, caused an issue, where quick-checks would
only fix one\nbatch of errors per run.\n\nThis PR would try to commit
multiple change batches throughout the\nquick-check's fixing phase, and
push only once to trigger a single,\nfixed
run.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"df58d593dc58cd3730c359248cff2902d9c39b9f"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added v9.2.4 v9.1.10 v8.19.10 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.19.10 v9.1.10 v9.2.4 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants