Update EUI to v108.0.0 by mgadewoll · Pull Request #240888 · elastic/kibana

mgadewoll · 2025-10-27T19:00:06Z

@elastic/eui: v107.0.1 ⏩ v108.0.0
@elastic/eui-theme-borealis: v3.6.0 ⏩ v4.0.0

Changes

Important

This PR removes code related to the legacy Amsterdam theme. But it purposefully keeps Amsterdam palettes in kbn-palettes as those are standalone.

removed code related to the legacy theme Amsterdam [#9090]
updated custom types to align with changes to the event type of onClose on EuiModal [#9137]

Package updates

`v108.0.0`

Updated EuiModal to support closing on outside click, via the new outsideClickCloses prop (#9137)

Breaking changes

Removed all "Amsterdam" theme related code in src/themes/amsterdam - EUI now only supports the "Borealis" theme in eui-theme-borealis (#9090)
Removed euiTheme.flags.hasGlobalFocusColor (#9090)
Removed euiTheme.flags.hasVisColorAdjustment (#9090)
Removed hasVisColorAdjustment argument from color palettes (used in euiPaletteColorBlindBehindText, euiPaletteForTemperature, euiPaletteComplementary, euiPaletteCool) (#9090)
Removed euiTheme.flags.buttonVariant and euiTheme.flags.formVariant (#9090)
Removed euiTheme.components.keyPadMenuItemBackgroundDisabledSelect (#9090)
Removed legacy SCSS files from src/global_styling/variables, src/global_styling/mixins and src/global_styling/functions - if needed, use them from eui-theme-common instead (#9090)

`v4.0.0`

Breaking changes

Removed euiTheme.flags.hasGlobalFocusColor (#9090)
Removed euiTheme.flags.hasVisColorAdjustment (#9090)
Removed euiTheme.flags.buttonVariant and euiTheme.flags.formVariant (#9090)
Removed euiTheme.components.keyPadMenuItemBackgroundDisabledSelect (#9090)

- addresses TS2742 inferred type error

- due to removed euiTheme.flags

- due to changes from amsterdam to borealis

- rebase cleanup

rbrtj

LGTM!
Just a small note: Questions? Please see our Kibana upgrade FAQ. -> this link mentioned in the PR description doesn't work for me

mgadewoll · 2025-10-28T14:44:24Z

LGTM! Just a small note: Questions? Please see our Kibana upgrade FAQ. -> this link mentioned in the PR description doesn't work for me

@rbrtj Thanks for the catch! We moved the wiki (here) but I'm not sure all elasticians have access by default. I'll remove the link instead.

PhilippeOberti

Desk tested and code LGTM for the @elastic/security-threat-hunting-investigations team. I left a small comment for unused constants, but I can tackle that in a follow up PR.

x-pack/solutions/security/plugins/security_solution/public/common/utils/risk_color_palette.tsx

paulinashakirova

SharexUX code owner review - lgtm 🚀

azasypkin

LGTM, I haven't noticed anything suspicious after a brief check of Platform Security server- and client-side rendered apps.

mariairiartef

Visualizations code changes LGTM

spong

Security GenAI changed LGTM! 👍 Thanks for the theme updates @mgadewoll, appreciate it!

justinkambic

Synthetics/Uptime changes LGTM

ThomThomson

Presentation team Amsterdam removals LGTM

mgadewoll · 2025-10-31T08:22:09Z

@elasticmachine merge upstream

elasticmachine · 2025-10-31T09:13:58Z

💛 Build succeeded, but was flaky

Failed CI Steps

Defend Workflows Cypress Tests on Serverless #1

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dashboard`	703	702	-1
`maps`	1285	1284	-1
total			-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`alerting`	88.3KB	88.2KB	-31.0B
`apm`	2.8MB	2.8MB	-286.0B
`canvas`	1.0MB	1.0MB	-106.0B
`cases`	1.4MB	1.4MB	-144.0B
`cloudSecurityPosture`	638.2KB	638.1KB	-139.0B
`controls`	489.2KB	486.4KB	-2.8KB
`dashboard`	661.5KB	659.4KB	-2.1KB
`datasetQuality`	423.0KB	422.9KB	-106.0B
`dataVisualizer`	598.9KB	598.7KB	-219.0B
`discover`	1.2MB	1.2MB	-378.0B
`esql`	578.8KB	578.7KB	-138.0B
`esqlDataGrid`	148.8KB	148.6KB	-138.0B
`fleet`	2.1MB	2.1MB	-158.0B
`indexLifecycleManagement`	147.4KB	147.0KB	-431.0B
`lens`	1.5MB	1.5MB	-106.0B
`maps`	3.1MB	3.1MB	-2.1KB
`ml`	5.4MB	5.4MB	-2.8KB
`presentationUtil`	67.4KB	67.0KB	-318.0B
`securitySolution`	11.0MB	11.0MB	-986.0B
`sessionView`	357.0KB	356.9KB	-116.0B
`slo`	982.9KB	982.7KB	-245.0B
`stackConnectors`	725.1KB	724.9KB	-144.0B
`streamsApp`	907.6KB	907.5KB	-121.0B
`synthetics`	1.0MB	1.0MB	-1.0KB
`uptime`	490.4KB	490.2KB	-188.0B
`visTypeVega`	2.0MB	2.0MB	-2.5KB
total			-17.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`aiops`	13.7KB	13.6KB	-71.0B
`core`	510.8KB	510.8KB	-36.0B
`indexLifecycleManagement`	26.6KB	26.5KB	-121.0B
`kbnUiSharedDeps-npmDll`	6.5MB	6.4MB	-122.5KB
`kbnUiSharedDeps-srcJs`	4.0MB	4.0MB	-28.8KB
`kibanaReact`	20.0KB	20.0KB	-18.0B
`mapsEms`	6.0KB	6.0KB	-30.0B
total			-151.6KB

History

💛 Build #356038 was flaky ffbbe39
💛 Build #355435 was flaky ec82a43

cc @mgadewoll

- `@elastic/eui`: `v107.0.1` ⏩ `v108.0.0` - `@elastic/eui-theme-borealis`: `v3.6.0` ⏩ `v4.0.0` --- ## Changes >[!IMPORTANT] This PR removes code related to the legacy Amsterdam theme. But it purposefully keeps Amsterdam palettes in `kbn-palettes` as those are standalone. - removed code related to the legacy theme Amsterdam [[elastic#9090](elastic/eui#9090)] - updated custom types to align with changes to the event type of `onClose` on `EuiModal` [[elastic#9137](elastic/eui#9137)] ## Package updates ### [`v108.0.0`](https://github.com/elastic/eui/releases/v108.0.0) - Updated `EuiModal` to support closing on outside click, via the new `outsideClickCloses` prop ([elastic#9137](elastic/eui#9137)) **Breaking changes** - Removed all "Amsterdam" theme related code in `src/themes/amsterdam` - EUI now only supports the "Borealis" theme in `eui-theme-borealis` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasGlobalFocusColor` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasVisColorAdjustment` ([elastic#9090](elastic/eui#9090)) - Removed `hasVisColorAdjustment` argument from color palettes (used in `euiPaletteColorBlindBehindText`, `euiPaletteForTemperature`, `euiPaletteComplementary`, `euiPaletteCool`) ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.buttonVariant` and `euiTheme.flags.formVariant` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect` ([elastic#9090](elastic/eui#9090)) - Removed legacy SCSS files from `src/global_styling/variables`, `src/global_styling/mixins` and `src/global_styling/functions` - if needed, use them from `eui-theme-common` instead ([elastic#9090](elastic/eui#9090)) ### [`v4.0.0`](https://github.com/elastic/eui/releases/v4.0.0) **Breaking changes** - Removed `euiTheme.flags.hasGlobalFocusColor` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.hasVisColorAdjustment` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.flags.buttonVariant` and `euiTheme.flags.formVariant` ([elastic#9090](elastic/eui#9090)) - Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect` ([elastic#9090](elastic/eui#9090)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

@jovana-andjelkovic

Reviewing #240888 I realized that there was some regression in the ILM policy icons with some previous EUI update. The `checkInCircleFilled` icon now works like the `check`. This PR updates the policy phase bullets so they look like before that change. Also, as agreed with @jovana-andjelkovic, it removes the gray border from the bullets. I also took the chance of creating a shared util with the colors and unify the delete phase color that was different depending on the component. ### Before the regression <img width="854" height="1038" alt="Screenshot 2025-10-28 at 10 27 18" src="https://github.com/user-attachments/assets/a4a86c29-6d25-4474-b08b-7a767fc2be85" /> ### Before this change <img width="781" height="1118" alt="before_icons" src="https://github.com/user-attachments/assets/39490db4-037b-4f00-9b22-b9b1ed3e86d4" /> <img width="489" height="1069" alt="before_flyout" src="https://github.com/user-attachments/assets/fed31bc0-8ae9-4fd8-a5b4-af75bb4ccb5b" /> ### After <img width="953" height="1290" alt="after_flyout" src="https://github.com/user-attachments/assets/78fb1a3a-88af-4e9b-b197-c074b8790050" /> <img width="818" height="1188" alt="after_icons" src="https://github.com/user-attachments/assets/7b74333a-174f-45ed-908a-2347f4b4f056" />

@jovana-andjelkovic

Reviewing elastic#240888 I realized that there was some regression in the ILM policy icons with some previous EUI update. The `checkInCircleFilled` icon now works like the `check`. This PR updates the policy phase bullets so they look like before that change. Also, as agreed with @jovana-andjelkovic, it removes the gray border from the bullets. I also took the chance of creating a shared util with the colors and unify the delete phase color that was different depending on the component. ### Before the regression <img width="854" height="1038" alt="Screenshot 2025-10-28 at 10 27 18" src="https://github.com/user-attachments/assets/a4a86c29-6d25-4474-b08b-7a767fc2be85" /> ### Before this change <img width="781" height="1118" alt="before_icons" src="https://github.com/user-attachments/assets/39490db4-037b-4f00-9b22-b9b1ed3e86d4" /> <img width="489" height="1069" alt="before_flyout" src="https://github.com/user-attachments/assets/fed31bc0-8ae9-4fd8-a5b4-af75bb4ccb5b" /> ### After <img width="953" height="1290" alt="after_flyout" src="https://github.com/user-attachments/assets/78fb1a3a-88af-4e9b-b197-c074b8790050" /> <img width="818" height="1188" alt="after_icons" src="https://github.com/user-attachments/assets/7b74333a-174f-45ed-908a-2347f4b4f056" />

mgadewoll added 13 commits October 27, 2025 19:54

chore: update eui packages

a29a005

refactor: update Amsterdam related imports

89f3f2a

refactor: remove v8/amsterdam theme switching support

421ba87

refactor: udpate storybook theme usages

2c77e7b

refactor: remove theme conditions based on themeName

ca20513

refactor: remove theme conditions based on flags.hasVisColorAdjustment

90e3571

refactor: add type

8e1d853

- addresses TS2742 inferred type error

refactor: update types

f3d4c1b

test: update snapshots

1b7faa3

- due to removed euiTheme.flags

test: update snapshots

05e5138

- due to changes from amsterdam to borealis

chore: update i18n files

07e587a

test: update snapshots

f03b215

- rebase cleanup

test: update snapshot

ec82a43

mgadewoll self-assigned this Oct 27, 2025

mgadewoll added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting ci:cloud-deploy Create or update a Cloud deployment labels Oct 27, 2025

mgadewoll marked this pull request as ready for review October 28, 2025 07:38

mgadewoll requested review from a team as code owners October 28, 2025 07:38

mgadewoll requested a review from a team October 28, 2025 07:38

mgadewoll requested review from a team as code owners October 28, 2025 07:38

rbrtj approved these changes Oct 28, 2025

View reviewed changes

SoniaSanzV mentioned this pull request Oct 28, 2025

[ILM] Fix ilm icons and unify colors #240978

Merged

adcoelho approved these changes Oct 28, 2025

View reviewed changes

jbudz approved these changes Oct 28, 2025

View reviewed changes

PhilippeOberti approved these changes Oct 28, 2025

View reviewed changes

x-pack/solutions/security/plugins/security_solution/public/common/utils/risk_color_palette.tsx Show resolved Hide resolved

mgadewoll added 2 commits October 29, 2025 08:33

refactor: remove obsolete constants

207b126

Merge branch 'main' into eui/v108.0.0

ffbbe39

mohamedhamed-ahmed approved these changes Oct 29, 2025

View reviewed changes

tkajtoch mentioned this pull request Oct 29, 2025

[DO NOT MERGE] Test feat/flyout-system build of EUI #241126

Closed

paulinashakirova reviewed Oct 29, 2025

View reviewed changes

paulinashakirova approved these changes Oct 29, 2025

View reviewed changes

azasypkin approved these changes Oct 29, 2025

View reviewed changes

jesuswr approved these changes Oct 30, 2025

View reviewed changes

mariairiartef approved these changes Oct 30, 2025

View reviewed changes

spong approved these changes Oct 30, 2025

View reviewed changes

justinkambic approved these changes Oct 30, 2025

View reviewed changes

ryankeairns approved these changes Oct 30, 2025

View reviewed changes

ThomThomson approved these changes Oct 30, 2025

View reviewed changes

seanrathier approved these changes Oct 30, 2025

View reviewed changes

Merge branch 'main' into eui/v108.0.0

149e3c7

mgadewoll enabled auto-merge (squash) October 31, 2025 08:22

mgadewoll merged commit 487036e into elastic:main Oct 31, 2025
14 checks passed

kibanamachine added the v9.3.0 label Oct 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update EUI to v108.0.0#240888

Update EUI to v108.0.0#240888
mgadewoll merged 16 commits intoelastic:mainfrom
mgadewoll:eui/v108.0.0

mgadewoll commented Oct 27, 2025 •

edited

Loading

Uh oh!

rbrtj left a comment •

edited

Loading

Uh oh!

mgadewoll commented Oct 28, 2025

Uh oh!

PhilippeOberti left a comment

Uh oh!

Uh oh!

paulinashakirova left a comment

Uh oh!

azasypkin left a comment

Uh oh!

mariairiartef left a comment

Uh oh!

spong left a comment

Uh oh!

justinkambic left a comment

Uh oh!

ThomThomson left a comment

Uh oh!

mgadewoll commented Oct 31, 2025

Uh oh!

elasticmachine commented Oct 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

mgadewoll commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Package updates

v108.0.0

v4.0.0

Uh oh!

rbrtj left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgadewoll commented Oct 28, 2025

Uh oh!

PhilippeOberti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paulinashakirova left a comment

Choose a reason for hiding this comment

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

mariairiartef left a comment

Choose a reason for hiding this comment

Uh oh!

spong left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

mgadewoll commented Oct 31, 2025

Uh oh!

elasticmachine commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

mgadewoll commented Oct 27, 2025 •

edited

Loading

`v108.0.0`

`v4.0.0`

rbrtj left a comment •

edited

Loading

elasticmachine commented Oct 31, 2025 •

edited

Loading