[ILM] Fix ilm icons and unify colors#240978
Merged
SoniaSanzV merged 7 commits intoelastic:mainfrom Nov 11, 2025
Merged
Conversation
SoniaSanzV
added
Feature:ILM
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
ElenaStoeva
reviewed
Nov 3, 2025
Contributor
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Thanks for working on this fix @SoniaSanzV! Left a few comments.
...k/platform/plugins/private/index_lifecycle_management/public/application/lib/phase_colors.ts
Outdated
Show resolved
Hide resolved
...k/platform/plugins/private/index_lifecycle_management/public/application/lib/phase_colors.ts
Outdated
Show resolved
Hide resolved
ElenaStoeva
reviewed
Nov 11, 2025
Contributor
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Thanks for addressing my feedback @SoniaSanzV! I tested again but it looks like the icons got back to how they were before?
Contributor
Author
|
Thank you for taking another look @ElenaStoeva! It's odd that you see the old look, I just tested and I can see the changes |
ElenaStoeva
approved these changes
Nov 11, 2025
Contributor
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Hmm I tested again and it's working now! Weird... Anyway, latest lgtm!
Contributor
Author
Added the |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @SoniaSanzV |
Contributor
Author
|
tested in cloud-deployment 
|
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
Reviewing elastic#240888 I realized that there was some regression in the ILM policy icons with some previous EUI update. The `checkInCircleFilled` icon now works like the `check`. This PR updates the policy phase bullets so they look like before that change. Also, as agreed with @jovana-andjelkovic, it removes the gray border from the bullets. I also took the chance of creating a shared util with the colors and unify the delete phase color that was different depending on the component. ### Before the regression <img width="854" height="1038" alt="Screenshot 2025-10-28 at 10 27 18" src="https://github.com/user-attachments/assets/a4a86c29-6d25-4474-b08b-7a767fc2be85" /> ### Before this change <img width="781" height="1118" alt="before_icons" src="https://github.com/user-attachments/assets/39490db4-037b-4f00-9b22-b9b1ed3e86d4" /> <img width="489" height="1069" alt="before_flyout" src="https://github.com/user-attachments/assets/fed31bc0-8ae9-4fd8-a5b4-af75bb4ccb5b" /> ### After <img width="953" height="1290" alt="after_flyout" src="https://github.com/user-attachments/assets/78fb1a3a-88af-4e9b-b197-c074b8790050" /> <img width="818" height="1188" alt="after_icons" src="https://github.com/user-attachments/assets/7b74333a-174f-45ed-908a-2347f4b4f056" />
8 tasks
damian-polewski
added a commit
that referenced
this pull request
Dec 18, 2025
## Summary Closes #246573 This PR fixes an issue where the IndexLifecycleSummary component was passed directly to renderTabContent instead of being wrapped in an arrow function. When PR #240978 introduced the `usePhaseColors()` hook, this broke the Index Lifecycle tab because `renderTabContent` is called as a plain function in `details_page_tab.tsx`: ``` selectedTab.renderTabContent({ index, getUrlForApp, euiTheme })> ``` Because of this hook wasn't getting called during proper React rendering causing "Invalid hook call" errors.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2025
…246606) ## Summary Closes elastic#246573 This PR fixes an issue where the IndexLifecycleSummary component was passed directly to renderTabContent instead of being wrapped in an arrow function. When PR elastic#240978 introduced the `usePhaseColors()` hook, this broke the Index Lifecycle tab because `renderTabContent` is called as a plain function in `details_page_tab.tsx`: ``` selectedTab.renderTabContent({ index, getUrlForApp, euiTheme })> ``` Because of this hook wasn't getting called during proper React rendering causing "Invalid hook call" errors. (cherry picked from commit df6ae8b)
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2025
…46606) (#246869) # Backport This will backport the following commits from `main` to `9.3`: - [[Index Management] Fix error on index lifecycle summary tab (#246606)](#246606) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Damian Polewski","email":"125268832+damian-polewski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-18T12:19:51Z","message":"[Index Management] Fix error on index lifecycle summary tab (#246606)\n\n## Summary\n\nCloses #246573\n\nThis PR fixes an issue where the IndexLifecycleSummary component was\npassed directly to renderTabContent instead of being wrapped in an arrow\nfunction.\n\nWhen PR #240978 introduced the `usePhaseColors()` hook, this broke the\nIndex Lifecycle tab because `renderTabContent` is called as a plain\nfunction in `details_page_tab.tsx`:\n\n```\nselectedTab.renderTabContent({ index, getUrlForApp, euiTheme })>\n```\n\nBecause of this hook wasn't getting called during proper React rendering\ncausing \"Invalid hook call\" errors.","sha":"df6ae8bdb176a8d3529f7437820edd4d0f50a07a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","backport:all-open","ci:cloud-deploy","v9.4.0"],"title":"[Index Management] Fix error on index lifecycle summary tab","number":246606,"url":"https://github.com/elastic/kibana/pull/246606","mergeCommit":{"message":"[Index Management] Fix error on index lifecycle summary tab (#246606)\n\n## Summary\n\nCloses #246573\n\nThis PR fixes an issue where the IndexLifecycleSummary component was\npassed directly to renderTabContent instead of being wrapped in an arrow\nfunction.\n\nWhen PR #240978 introduced the `usePhaseColors()` hook, this broke the\nIndex Lifecycle tab because `renderTabContent` is called as a plain\nfunction in `details_page_tab.tsx`:\n\n```\nselectedTab.renderTabContent({ index, getUrlForApp, euiTheme })>\n```\n\nBecause of this hook wasn't getting called during proper React rendering\ncausing \"Invalid hook call\" errors.","sha":"df6ae8bdb176a8d3529f7437820edd4d0f50a07a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246606","number":246606,"mergeCommit":{"message":"[Index Management] Fix error on index lifecycle summary tab (#246606)\n\n## Summary\n\nCloses #246573\n\nThis PR fixes an issue where the IndexLifecycleSummary component was\npassed directly to renderTabContent instead of being wrapped in an arrow\nfunction.\n\nWhen PR #240978 introduced the `usePhaseColors()` hook, this broke the\nIndex Lifecycle tab because `renderTabContent` is called as a plain\nfunction in `details_page_tab.tsx`:\n\n```\nselectedTab.renderTabContent({ index, getUrlForApp, euiTheme })>\n```\n\nBecause of this hook wasn't getting called during proper React rendering\ncausing \"Invalid hook call\" errors.","sha":"df6ae8bdb176a8d3529f7437820edd4d0f50a07a"}}]}] BACKPORT--> Co-authored-by: Damian Polewski <125268832+damian-polewski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewing #240888 I realized that there was some regression in the ILM policy icons with some previous EUI update. The
checkInCircleFilledicon now works like thecheck. This PR updates the policy phase bullets so they look like before that change. Also, as agreed with @jovana-andjelkovic, it removes the gray border from the bullets.I also took the chance of creating a shared util with the colors and unify the delete phase color that was different depending on the component.
Before the regression
Before this change
After