Skip to content

Add a note on multi-statement scripted field limitation #9090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epixa merged 1 commit into from
Nov 17, 2016
Merged

Add a note on multi-statement scripted field limitation #9090

epixa merged 1 commit into from
Nov 17, 2016

Conversation

@Bargs
Copy link
Contributor

@Bargs Bargs commented Nov 15, 2016

Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.

See #9024
Related elastic/elasticsearch#21479

@Bargs
Add a note on multi-statement scripted field limitation
b4aaed8 
Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.

See elastic#9024
Related elastic/elasticsearch#21479
@Bargs
Copy link
Contributor Author

Bargs commented Nov 15, 2016

To avoid having info/warning boxes stacked three high I tried to incorporate the warning into the existing help text. I also didn't implement any logic to show/hide it based on the selected lang since we're already showing Painless and lucene info side by side there.

@epixa
Copy link
Contributor

epixa commented Nov 15, 2016

LGTM

@tbragin tbragin added the Feature:Scripted Fields Scripted fields features label Nov 16, 2016
@epixa epixa assigned Bargs and unassigned epixa Nov 16, 2016
@epixa epixa merged commit 5032b91 into elastic:master Nov 17, 2016
@elastic-jasper elastic-jasper mentioned this pull request Nov 17, 2016
Merged
elastic-jasper added a commit that referenced this pull request Nov 17, 2016
@elastic-jasper
Add a note on multi-statement scripted field limitation
38f2d70 
Backports PR #9090

**Commit 1:**
Add a note on multi-statement scripted field limitation

Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.

See #9024
Related elastic/elasticsearch#21479

* Original sha: b4aaed8
* Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z
elastic-jasper added a commit that referenced this pull request Nov 17, 2016
@elastic-jasper
Add a note on multi-statement scripted field limitation
2424835 
Backports PR #9090

**Commit 1:**
Add a note on multi-statement scripted field limitation

Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.

See #9024
Related elastic/elasticsearch#21479

* Original sha: b4aaed8
* Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z
@elastic-jasper elastic-jasper mentioned this pull request Nov 17, 2016
Merged
@epixa epixa mentioned this pull request Nov 17, 2016
Closed
epixa pushed a commit that referenced this pull request Nov 17, 2016
@elastic-jasper @epixa
Add a note on multi-statement scripted field limitation (#9121)
24840a9 
Backports PR #9090

**Commit 1:**
Add a note on multi-statement scripted field limitation

Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.

See #9024
Related elastic/elasticsearch#21479

* Original sha: b4aaed8
* Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z
epixa pushed a commit that referenced this pull request Nov 17, 2016
@elastic-jasper @epixa
Add a note on multi-statement scripted field limitation (#9122)
28c433f 
Backports PR #9090

**Commit 1:**
Add a note on multi-statement scripted field limitation

Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.

See #9024
Related elastic/elasticsearch#21479

* Original sha: b4aaed8
* Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z
@Bargs
Copy link
Contributor Author

Bargs commented Nov 17, 2016

@epixa I thought we were waiting to merge this until we were sure we didn't have a better fix? Were you just wanting to make sure it got in 5.0.2?

@epixa
Copy link
Contributor

epixa commented Nov 17, 2016

@Bargs I'd rather err on the side of getting it in so it goes out with 5.0.2. We can always revert it if we can fix the core issue before 5.0.2.

@tbragin tbragin mentioned this pull request Nov 22, 2016
Closed
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
@elastic-jasper @epixa
Add a note on multi-statement scripted field limitation (elastic#9121)
efb4ee1 
Backports PR elastic#9090

**Commit 1:**
Add a note on multi-statement scripted field limitation

Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.

See elastic#9024
Related elastic/elasticsearch#21479

* Original sha: b4aaed8
* Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z

Former-commit-id: 24840a9
mgadewoll added a commit that referenced this pull request Oct 31, 2025
@mgadewoll @elasticmachine
Update EUI to v108.0.0 (#240888)
487036e 
- `@elastic/eui`: `v107.0.1` ⏩ `v108.0.0`
- `@elastic/eui-theme-borealis`: `v3.6.0` ⏩ `v4.0.0`

---

## Changes

>[!IMPORTANT]
This PR removes code related to the legacy Amsterdam theme. But it
purposefully keeps Amsterdam palettes in `kbn-palettes` as those are
standalone.

- removed code related to the legacy theme Amsterdam
[[#9090](elastic/eui#9090)]
- updated custom types to align with changes to the event type of
`onClose` on `EuiModal`
[[#9137](elastic/eui#9137)]

## Package updates

### [`v108.0.0`](https://github.com/elastic/eui/releases/v108.0.0)

- Updated `EuiModal` to support closing on outside click, via the new
`outsideClickCloses` prop
([#9137](elastic/eui#9137))

**Breaking changes**

- Removed all "Amsterdam" theme related code in `src/themes/amsterdam` -
EUI now only supports the "Borealis" theme in `eui-theme-borealis`
([#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasGlobalFocusColor`
([#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasVisColorAdjustment`
([#9090](elastic/eui#9090))
- Removed `hasVisColorAdjustment` argument from color palettes (used in
`euiPaletteColorBlindBehindText`, `euiPaletteForTemperature`,
`euiPaletteComplementary`, `euiPaletteCool`)
([#9090](elastic/eui#9090))
- Removed `euiTheme.flags.buttonVariant` and
`euiTheme.flags.formVariant`
([#9090](elastic/eui#9090))
- Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect`
([#9090](elastic/eui#9090))
- Removed legacy SCSS files from `src/global_styling/variables`,
`src/global_styling/mixins` and `src/global_styling/functions` - if
needed, use them from `eui-theme-common` instead
([#9090](elastic/eui#9090))

### [`v4.0.0`](https://github.com/elastic/eui/releases/v4.0.0)

**Breaking changes**

- Removed `euiTheme.flags.hasGlobalFocusColor`
([#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasVisColorAdjustment`
([#9090](elastic/eui#9090))
- Removed `euiTheme.flags.buttonVariant` and
`euiTheme.flags.formVariant`
([#9090](elastic/eui#9090))
- Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect`
([#9090](elastic/eui#9090))

---------

Co-authored-by: Elastic Machine <[email protected]>
ana-davydova pushed a commit to ana-davydova/kibana that referenced this pull request Nov 3, 2025
@mgadewoll @elasticmachine @ana-davydova
Update EUI to v108.0.0 (elastic#240888)
514d361 
- `@elastic/eui`: `v107.0.1` ⏩ `v108.0.0`
- `@elastic/eui-theme-borealis`: `v3.6.0` ⏩ `v4.0.0`

---

## Changes

>[!IMPORTANT]
This PR removes code related to the legacy Amsterdam theme. But it
purposefully keeps Amsterdam palettes in `kbn-palettes` as those are
standalone.

- removed code related to the legacy theme Amsterdam
[[elastic#9090](elastic/eui#9090)]
- updated custom types to align with changes to the event type of
`onClose` on `EuiModal`
[[elastic#9137](elastic/eui#9137)]

## Package updates

### [`v108.0.0`](https://github.com/elastic/eui/releases/v108.0.0)

- Updated `EuiModal` to support closing on outside click, via the new
`outsideClickCloses` prop
([elastic#9137](elastic/eui#9137))

**Breaking changes**

- Removed all "Amsterdam" theme related code in `src/themes/amsterdam` -
EUI now only supports the "Borealis" theme in `eui-theme-borealis`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasGlobalFocusColor`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasVisColorAdjustment`
([elastic#9090](elastic/eui#9090))
- Removed `hasVisColorAdjustment` argument from color palettes (used in
`euiPaletteColorBlindBehindText`, `euiPaletteForTemperature`,
`euiPaletteComplementary`, `euiPaletteCool`)
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.buttonVariant` and
`euiTheme.flags.formVariant`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect`
([elastic#9090](elastic/eui#9090))
- Removed legacy SCSS files from `src/global_styling/variables`,
`src/global_styling/mixins` and `src/global_styling/functions` - if
needed, use them from `eui-theme-common` instead
([elastic#9090](elastic/eui#9090))

### [`v4.0.0`](https://github.com/elastic/eui/releases/v4.0.0)

**Breaking changes**

- Removed `euiTheme.flags.hasGlobalFocusColor`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasVisColorAdjustment`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.buttonVariant` and
`euiTheme.flags.formVariant`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect`
([elastic#9090](elastic/eui#9090))

---------

Co-authored-by: Elastic Machine <[email protected]>
albertoblaz pushed a commit to albertoblaz/kibana that referenced this pull request Nov 4, 2025
@mgadewoll @elasticmachine @albertoblaz
Update EUI to v108.0.0 (elastic#240888)
2027058 
- `@elastic/eui`: `v107.0.1` ⏩ `v108.0.0`
- `@elastic/eui-theme-borealis`: `v3.6.0` ⏩ `v4.0.0`

---

## Changes

>[!IMPORTANT]
This PR removes code related to the legacy Amsterdam theme. But it
purposefully keeps Amsterdam palettes in `kbn-palettes` as those are
standalone.

- removed code related to the legacy theme Amsterdam
[[elastic#9090](elastic/eui#9090)]
- updated custom types to align with changes to the event type of
`onClose` on `EuiModal`
[[elastic#9137](elastic/eui#9137)]

## Package updates

### [`v108.0.0`](https://github.com/elastic/eui/releases/v108.0.0)

- Updated `EuiModal` to support closing on outside click, via the new
`outsideClickCloses` prop
([elastic#9137](elastic/eui#9137))

**Breaking changes**

- Removed all "Amsterdam" theme related code in `src/themes/amsterdam` -
EUI now only supports the "Borealis" theme in `eui-theme-borealis`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasGlobalFocusColor`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasVisColorAdjustment`
([elastic#9090](elastic/eui#9090))
- Removed `hasVisColorAdjustment` argument from color palettes (used in
`euiPaletteColorBlindBehindText`, `euiPaletteForTemperature`,
`euiPaletteComplementary`, `euiPaletteCool`)
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.buttonVariant` and
`euiTheme.flags.formVariant`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect`
([elastic#9090](elastic/eui#9090))
- Removed legacy SCSS files from `src/global_styling/variables`,
`src/global_styling/mixins` and `src/global_styling/functions` - if
needed, use them from `eui-theme-common` instead
([elastic#9090](elastic/eui#9090))

### [`v4.0.0`](https://github.com/elastic/eui/releases/v4.0.0)

**Breaking changes**

- Removed `euiTheme.flags.hasGlobalFocusColor`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.hasVisColorAdjustment`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.flags.buttonVariant` and
`euiTheme.flags.formVariant`
([elastic#9090](elastic/eui#9090))
- Removed `euiTheme.components.keyPadMenuItemBackgroundDisabledSelect`
([elastic#9090](elastic/eui#9090))

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Bargs Bargs

Labels

Feature:Scripted Fields Scripted fields features review v5.0.2 v5.1.1 v6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bargs @epixa @tbragin