Skip to content

[9.2] [Cypress] Stop using checkA11y({ skipFailures: true }) and enforce strict accessibility validation (#237627)#240774

Closed
kibanamachine wants to merge 1 commit intoelastic:9.2from
kibanamachine:backport/9.2/pr-237627
Closed

[9.2] [Cypress] Stop using checkA11y({ skipFailures: true }) and enforce strict accessibility validation (#237627)#240774
kibanamachine wants to merge 1 commit intoelastic:9.2from
kibanamachine:backport/9.2/pr-237627

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.2:

Questions ?

Please refer to the Backport tool documentation

…strict accessibility validation (elastic#237627)

## Summary

- Remove use of `checkA11y({ skipFailures: true })` across `Cypress`
tests and enforce strict accessibility validation so that accessibility
violations cause test failures.
- This change ensures accessibility regressions are caught by CI rather
than silently skipped.

## Why
- Using `skipFailures: true` masked accessibility problems and allowed
regressions to slip into main branch.
- Enforcing strict accessibility checks improves product quality and
aligns tests with accessibility-first goals.

## What was changed
- Replaced occurrences of `checkA11y({ skipFailures: true })` (and
equivalent patterns) so that accessibility checks run without the
`skipFailures` flag.
- Fixed or adjusted places where necessary to make test suites pass with
strict a11y checks (small target adjustments to code to fix violations)

## Depends on
- elastic/eui#9100

(cherry picked from commit 00b3e4a)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 27, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) October 27, 2025 11:11
@botelastic botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Oct 27, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 27, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] APM Cypress Tests #1 / Dependencies dependency overview page has no detectable a11y violations on load has no detectable a11y violations on load
  • [job] [logs] APM Cypress Tests #2 / Service inventory When navigating to the service inventory has no detectable a11y violations on load has no detectable a11y violations on load
  • [job] [logs] APM Cypress Tests #2 / Service inventory When navigating to the service inventory has no detectable a11y violations on load has no detectable a11y violations on load
  • [job] [logs] Fleet Cypress Tests #2 / View agents list Agent status filter should filter on healthy and unhealthy
  • [job] [logs] Fleet Cypress Tests #2 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +765.0B
unifiedDocViewer 273.3KB 273.5KB +156.0B
total +921.0B

History

cc @alexwizp

@alexwizp alexwizp closed this Oct 27, 2025
auto-merge was automatically disabled October 27, 2025 13:04

Pull request was closed

@alexwizp
Copy link
Contributor

EUI not updated for 9.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants