[Cypress] Stop using checkA11y({ skipFailures: true }) and enforce strict accessibility validation#237627
[Cypress] Stop using checkA11y({ skipFailures: true }) and enforce strict accessibility validation#237627alexwizp merged 13 commits intoelastic:mainfrom
checkA11y({ skipFailures: true }) and enforce strict accessibility validation#237627Conversation
…strict accessibility validation
# Conflicts: # x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/e2e/storage_explorer/storage_explorer.cy.ts
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
left a comment
There was a problem hiding this comment.
Thank you for enabling the a11y tests in APM. The code change LGTM?
We already moved some tests to playwright/scout here, and we plan to do that with the rest of the Cypress tests.
@dmlemeshko do we have a similar method to checkA11y in scout, and what do you recommend using there? I see that playwright is also using axe for a11y testing, so maybe we can have something similar?
x-pack/solutions/observability/plugins/apm/public/components/routing/app_root/index.tsx
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
@jennypavlova As a first step in the |
@jennypavlova we don't have any wrapper for a11y in Scout yet, but we definitely plan to use Playwright in-built accessibility testing functionality. I can have a look and add it asap |
|
Starting backport for target branches: 9.2 https://github.com/elastic/kibana/actions/runs/18838635990 |
…strict accessibility validation (elastic#237627) ## Summary - Remove use of `checkA11y({ skipFailures: true })` across `Cypress` tests and enforce strict accessibility validation so that accessibility violations cause test failures. - This change ensures accessibility regressions are caught by CI rather than silently skipped. ## Why - Using `skipFailures: true` masked accessibility problems and allowed regressions to slip into main branch. - Enforcing strict accessibility checks improves product quality and aligns tests with accessibility-first goals. ## What was changed - Replaced occurrences of `checkA11y({ skipFailures: true })` (and equivalent patterns) so that accessibility checks run without the `skipFailures` flag. - Fixed or adjusted places where necessary to make test suites pass with strict a11y checks (small target adjustments to code to fix violations) ## Depends on - elastic/eui#9100 (cherry picked from commit 00b3e4a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
checkA11y({ skipFailures: true })acrossCypresstests and enforce strict accessibility validation so that accessibility violations cause test failures.Why
skipFailures: truemasked accessibility problems and allowed regressions to slip into main branch.What was changed
checkA11y({ skipFailures: true })(and equivalent patterns) so that accessibility checks run without theskipFailuresflag.Depends on