[Shared] Add @kbn/dashboards-selector package#233445
Merged
cesco-f merged 3 commits intoelastic:mainfrom Sep 1, 2025
Merged
Conversation
cesco-f
added
release_note:skip
github-actions
bot
added
the
author:obs-ux-management
cesco-f
changed the title
cesco-f
force-pushed
the
dashboards-combobox
branch
from
b38c330 to
19e996c
Compare
cesco-f
force-pushed
the
dashboards-combobox
branch
2 times, most recently
from
35ebc88 to
620942c
Compare
cesco-f
changed the title
nickpeihl
reviewed
Aug 29, 2025
| @@ -0,0 +1,48 @@ | |||
| # `@kbn/dashboards` | |||
Contributor
There was a problem hiding this comment.
Can we rename this to something more specific? Maybe something like @kbn/dashboards-selector?
Contributor
Author
There was a problem hiding this comment.
Thanks, I had a hard time finding a good name 😂
package.json
Outdated
| "@kbn/dashboard-enhanced-plugin": "link:x-pack/platform/plugins/shared/dashboard_enhanced", | ||
| "@kbn/dashboard-markdown": "link:src/platform/plugins/shared/dashboard_markdown", | ||
| "@kbn/dashboard-plugin": "link:src/platform/plugins/shared/dashboard", | ||
| "@kbn/dashboards": "link:src/platform/packages/shared/dashboards", |
Contributor
There was a problem hiding this comment.
Ideally, the new package lives under the dashboards folder, something like link:src/platform/packages/shared/dashboards/dashboard-selector or something like that. Then we have room for other dashboard packages in the same folder.
Contributor
Author
There was a problem hiding this comment.
Sorry, I didn't fully get what you said in that Slack thread, it should be good now.
cesco-f
force-pushed
the
dashboards-combobox
branch
from
620942c to
905b332
Compare
cesco-f
changed the title
cesco-f
force-pushed
the
dashboards-combobox
branch
from
905b332 to
1a845cf
Compare
cesco-f
force-pushed
the
dashboards-combobox
branch
from
1a845cf to
f26d53b
Compare
nickpeihl
approved these changes
Aug 29, 2025
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! just a nit about package type.
src/platform/packages/shared/dashboards/dashboards-selector/kibana.jsonc
Outdated
Show resolved
Hide resolved
…bana.jsonc Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
jcger
approved these changes
Sep 1, 2025
ymao1
pushed a commit
to ymao1/kibana
that referenced
this pull request
Sep 2, 2025
This pull request introduces a new shared package, `@kbn/dashboards-selector`, to enable reuse of the combobox component. This component is currently used to link dashboards to rules, and it will now also be used to link dashboards to SLOs. The component I want to reuse in SLO: <img width="1166" height="283" alt="Screenshot 2025-08-29 at 12 07 18" src="https://github.com/user-attachments/assets/c6aff5cc-1a7a-4371-9b13-46025dd38904" /> This update is necessary for the implementation of elastic#233265. --------- Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
MichelLosier
pushed a commit
to MichelLosier/kibana
that referenced
this pull request
Sep 2, 2025
This pull request introduces a new shared package, `@kbn/dashboards-selector`, to enable reuse of the combobox component. This component is currently used to link dashboards to rules, and it will now also be used to link dashboards to SLOs. The component I want to reuse in SLO: <img width="1166" height="283" alt="Screenshot 2025-08-29 at 12 07 18" src="https://github.com/user-attachments/assets/c6aff5cc-1a7a-4371-9b13-46025dd38904" /> This update is necessary for the implementation of elastic#233265. --------- Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Sep 3, 2025
This pull request introduces a new shared package, `@kbn/dashboards-selector`, to enable reuse of the combobox component. This component is currently used to link dashboards to rules, and it will now also be used to link dashboards to SLOs. The component I want to reuse in SLO: <img width="1166" height="283" alt="Screenshot 2025-08-29 at 12 07 18" src="https://github.com/user-attachments/assets/c6aff5cc-1a7a-4371-9b13-46025dd38904" /> This update is necessary for the implementation of elastic#233265. --------- Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new shared package,
@kbn/dashboards-selector, to enable reuse of the combobox component. This component is currently used to link dashboards to rules, and it will now also be used to link dashboards to SLOs.The component I want to reuse in SLO:
This update is necessary for the implementation of #233265.