[SLO] Link dashboards to SLO by cesco-f · Pull Request #233265 · elastic/kibana

cesco-f · 2025-08-28T08:37:57Z

This PR is a follow-up of #232583 and it closes #228509.

Dashboards can be linked to SLOs.

Screen.Recording.2025-08-28.at.10.36.26.mov

src/platform/packages/shared/response-ops/rule_form/src/rule_details/rule_dashboards.tsx

elasticmachine · 2025-08-28T08:58:57Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

This pull request introduces a new shared package, `@kbn/dashboards-selector`, to enable reuse of the combobox component. This component is currently used to link dashboards to rules, and it will now also be used to link dashboards to SLOs. The component I want to reuse in SLO: <img width="1166" height="283" alt="Screenshot 2025-08-29 at 12 07 18" src="https://github.com/user-attachments/assets/c6aff5cc-1a7a-4371-9b13-46025dd38904" /> This update is necessary for the implementation of #233265. --------- Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

…dit slo form

mgiota · 2025-09-01T11:16:56Z

x-pack/solutions/observability/plugins/slo/public/types.ts

  security?: SecurityPluginStart;
  fieldsMetadata: FieldsMetadataPublicStart;
  apmSourcesAccess: ApmSourceAccessPluginStart;
+  contentManagement: ContentManagementPublicStart;


Linking with this issue, where we can remove the dependency to the contentManagement plugin

Just to clarify, this comment of mine regarding removing dependency to the contentManagement plugin, is something that does NOT need to be addressed in current PR. I put it here as a reminder for when addressing this issue.

I also just read Dominique's here, so it might be that we don't need to replace anything (I need to refresh what it is about). @cesco-f Can you weigh in here if we can replace the use of dashboardServiceProvider with the api in the rules form?

I left a comment there!

Thanks, we discussed about it! With the new abstract dashboards selector component you introduce in this PR, there is no need to use the linked dashboards api in the rule form.

elasticmachine · 2025-09-01T11:28:04Z

💚 Build Succeeded

Buildkite Build
Commit: cea5603

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`slo`	1244	1247	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`slo`	56	57	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`slo`	970.2KB	974.2KB	+4.0KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id	before	after	diff
`_data_stream_timestamp`	1	-	-1
`_doc_count`	1	-	-1
`_ignored_source`	1	-	-1
`_index_mode`	1	-	-1
`_inference_fields`	1	-	-1
`_tier`	1	-	-1
`apm-custom-dashboards`	5	-	-5
`apm-server-schema`	2	-	-2
`apm-service-group`	5	-	-5
`application_usage_daily`	2	-	-2
`config`	2	-	-2
`config-global`	2	-	-2
`coreMigrationVersion`	1	-	-1
`created_at`	1	-	-1
`created_by`	1	-	-1
`entity-definition`	9	-	-9
`entity-discovery-api-key`	2	-	-2
`event_loop_delays_daily`	2	-	-2
`favorites`	4	-	-4
`file`	11	-	-11
`file-upload-usage-collection-telemetry`	3	-	-3
`fileShare`	5	-	-5
`infra-custom-dashboards`	4	-	-4
`infrastructure-monitoring-log-view`	2	-	-2
`intercept_trigger_record`	5	-	-5
`legacy-url-alias`	7	-	-7
`managed`	1	-	-1
`ml-job`	6	-	-6
`ml-module`	13	-	-13
`ml-trained-model`	7	-	-7
`monitoring-telemetry`	2	-	-2
`namespace`	1	-	-1
`namespaces`	1	-	-1
`observability-onboarding-state`	2	-	-2
`originId`	1	-	-1
`product-doc-install-status`	7	-	-7
`references`	4	-	-4
`sample-data-telemetry`	3	-	-3
`security-ai-prompt`	8	-	-8
`slo`	11	-	-11
`space`	5	-	-5
`synthetics-monitor`	34	-	-34
`synthetics-monitor-multi-space`	34	-	-34
`tag`	4	-	-4
`type`	1	-	-1
`typeMigrationVersion`	1	-	-1
`ui-metric`	2	-	-2
`updated_at`	1	-	-1
`updated_by`	1	-	-1
`upgrade-assistant-ml-upgrade-operation`	3	-	-3
`upgrade-assistant-reindex-operation`	3	-	-3
`uptime-synthetics-api-key`	2	-	-2
`url`	5	-	-5
`usage-counters`	2	-	-2
total			-246

Unknown metric groups

API count

id	before	after	diff
`slo`	56	57	+1

History

💚 Build #333524 succeeded 5e327c6

mgiota · 2025-09-01T11:43:21Z

...rvability/plugins/slo/public/pages/slo_edit/components/slo_edit_form_description_section.tsx

 import { i18n } from '@kbn/i18n';
 import React from 'react';
 import { Controller, useFormContext } from 'react-hook-form';
+import { DashboardsSelector } from '@kbn/dashboards-selector';


Great for creating this reusable component!

mgiota

@cesco-f I tested it and it works fine. Great for reusing the shareable dashboards-selector component and driving all the discussions with the core/platform team!

I am pasting here @kdelemme's text, which is something I would like to test, but haven't done so yet. Did you try this? I want us to be sure we won't have issues with SLOs that have been created before the introduction of new dashboards artifacts.

One thing I would like to test is the upgrade path (should be fine since everything is optional): creating an SLO on main, and then running this branch and trying to read/edit this SLO. Could you confirm everything is fine on this side?

cesco-f · 2025-09-01T11:53:07Z

@cesco-f I tested it and it works fine. Great for reusing the shareable dashboards-selector component and driving all the discussions with the core/platform team!

I am pasting here @kdelemme's text, which is something I would like to test, but haven't done so yet. Did you try this? I want us to be sure we won't have issues with SLOs that have been created before the introduction of new dashboards artifacts.
One thing I would like to test is the upgrade path (should be fine since everything is optional): creating an SLO on main, and then running this branch and trying to read/edit this SLO. Could you confirm everything is fine on this side?

I did when testing the backend part, but please double check before approving, thanks 😊

mgiota

I did when testing the backend part, but please double check before approving, thanks 😊

I verify that everything works fine!

This pull request introduces a new shared package, `@kbn/dashboards-selector`, to enable reuse of the combobox component. This component is currently used to link dashboards to rules, and it will now also be used to link dashboards to SLOs. The component I want to reuse in SLO: <img width="1166" height="283" alt="Screenshot 2025-08-29 at 12 07 18" src="https://github.com/user-attachments/assets/c6aff5cc-1a7a-4371-9b13-46025dd38904" /> This update is necessary for the implementation of elastic#233265. --------- Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

This PR is a follow-up of elastic#232583 and it closes elastic#228509. Dashboards can be linked to SLOs. https://github.com/user-attachments/assets/a9593926-ad01-4c40-be1b-27b44eef81ae --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

This pull request introduces a new shared package, `@kbn/dashboards-selector`, to enable reuse of the combobox component. This component is currently used to link dashboards to rules, and it will now also be used to link dashboards to SLOs. The component I want to reuse in SLO: <img width="1166" height="283" alt="Screenshot 2025-08-29 at 12 07 18" src="https://github.com/user-attachments/assets/c6aff5cc-1a7a-4371-9b13-46025dd38904" /> This update is necessary for the implementation of elastic#233265. --------- Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

This PR is a follow-up of elastic#232583 and it closes elastic#228509. Dashboards can be linked to SLOs. https://github.com/user-attachments/assets/a9593926-ad01-4c40-be1b-27b44eef81ae --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

This pull request introduces a new shared package, `@kbn/dashboards-selector`, to enable reuse of the combobox component. This component is currently used to link dashboards to rules, and it will now also be used to link dashboards to SLOs. The component I want to reuse in SLO: <img width="1166" height="283" alt="Screenshot 2025-08-29 at 12 07 18" src="https://github.com/user-attachments/assets/c6aff5cc-1a7a-4371-9b13-46025dd38904" /> This update is necessary for the implementation of elastic#233265. --------- Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

This PR is a follow-up of elastic#232583 and it closes elastic#228509. Dashboards can be linked to SLOs. https://github.com/user-attachments/assets/a9593926-ad01-4c40-be1b-27b44eef81ae --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

cesco-f added release_note:enhancement backport:skip This PR does not require backporting labels Aug 28, 2025

github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Aug 28, 2025

cesco-f commented Aug 28, 2025

View reviewed changes

src/platform/packages/shared/response-ops/rule_form/src/rule_details/rule_dashboards.tsx Outdated Show resolved Hide resolved

cesco-f marked this pull request as ready for review August 28, 2025 08:47

cesco-f requested review from a team as code owners August 28, 2025 08:47

botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Aug 28, 2025

cesco-f mentioned this pull request Aug 29, 2025

[Shared] Add @kbn/dashboards-selector package #233445

Merged

cesco-f marked this pull request as draft August 29, 2025 09:53

cesco-f and others added 3 commits September 1, 2025 11:45

feat(linked dashboards): added linked dashboards combobox to create/e…

310721a

…dit slo form

fix(fix): minor fix

9f06d37

[CI] Auto-commit changed files from 'node scripts/notice'

aa2c98b

cesco-f force-pushed the slo-dashboards-combobox-2 branch from 5e327c6 to aa2c98b Compare September 1, 2025 09:45

cesco-f removed the request for review from a team September 1, 2025 09:46

cesco-f marked this pull request as ready for review September 1, 2025 09:47

[CI] Auto-commit changed files from 'security: 3rd-party dependencies'

cea5603

mgiota self-requested a review September 1, 2025 10:43

mgiota reviewed Sep 1, 2025

View reviewed changes

mgiota approved these changes Sep 2, 2025

View reviewed changes

cesco-f merged commit 041aa56 into elastic:main Sep 2, 2025
12 checks passed

cesco-f deleted the slo-dashboards-combobox-2 branch September 2, 2025 09:10

kibanamachine added the v9.2.0 label Sep 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SLO] Link dashboards to SLO#233265

[SLO] Link dashboards to SLO#233265
cesco-f merged 4 commits intoelastic:mainfrom
cesco-f:slo-dashboards-combobox-2

cesco-f commented Aug 28, 2025

Uh oh!

Uh oh!

elasticmachine commented Aug 28, 2025

Uh oh!

mgiota Sep 1, 2025

Uh oh!

mgiota Sep 1, 2025

Uh oh!

cesco-f Sep 1, 2025

Uh oh!

mgiota Sep 2, 2025

Uh oh!

elasticmachine commented Sep 1, 2025

API count

Uh oh!

mgiota Sep 1, 2025

Uh oh!

mgiota left a comment

Uh oh!

cesco-f commented Sep 1, 2025

Uh oh!

mgiota left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cesco-f commented Aug 28, 2025

Uh oh!

Uh oh!

elasticmachine commented Aug 28, 2025

Uh oh!

mgiota Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

mgiota Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

cesco-f Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

mgiota Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 1, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Saved Objects .kibana field count

API count

History

Uh oh!

mgiota Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

mgiota left a comment

Choose a reason for hiding this comment

Uh oh!

cesco-f commented Sep 1, 2025

Uh oh!

mgiota left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mgiota left a comment •

edited

Loading