Fix empty Dashboard selector by mgiota · Pull Request #243496 · elastic/kibana

mgiota · 2025-11-19T12:21:18Z

This PR fixes the issue where, no dashboards come up in the list when trying to link dashboards to a rule.

Before

After

nreese · 2025-11-19T14:22:19Z

src/platform/plugins/shared/dashboard/server/plugin.ts

    plugins.contentManagement.favorites.registerFavoriteType('dashboard');

+    // Register dashboard in content management for search functionality
+    plugins.contentManagement.register({


This is not the correct path. We removed content management because we want all interfacing with dashboards to go through the "dashboards as code" REST API. If your plugin depends on dashboard plugin, use findDashboardService search method exposed from the dashboard public start contract. If your plugin can not depend on dashboard plugin (because of circular dependencies), then use UI action searchDashboardAction. Here is an example of using the search action https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/presentation_util/public/components/dashboard_picker/dashboard_picker.tsx#L48

I replaced contentManagement service with UiActions. I tested it locally and works. Let me know what you think

nreese

Would it be possible to remove entire src/platform/packages/shared/dashboards/dashboards-selector package and just use https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/presentation_util/public/index.ts#L22? This package is very duplicative of what already exists.

cesco-f · 2025-11-20T09:06:58Z

Would it be possible to remove entire src/platform/packages/shared/dashboards/dashboards-selector package and just use https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/presentation_util/public/index.ts#L22? This package is very duplicative of what already exists.

Is it possible to select multiple dashboards with the DashboardPicker?

That was the main reason why the dashboards-selector was created.

src/platform/packages/shared/dashboards/dashboards-selector/services/dashboard_service.ts

...tform/packages/shared/dashboards/dashboards-selector/components/dashboards_selector.test.tsx

src/platform/packages/shared/dashboards/dashboards-selector/components/dashboards_selector.tsx

src/platform/plugins/shared/content_management/public/content_client/content_client.tsx

nreese · 2025-11-20T14:37:34Z

Is it possible to select multiple dashboards with the DashboardPicker?

That was the main reason why the dashboards-selector was created.

It was a mistake to put this component into its own package. Instead, this component should be a part of presentation-util-plugin. I have opened #243668 to track the issue

mgiota · 2025-11-20T14:48:41Z

@cesco-f Thanks for the review. I think I applied all your feedback. I'll do one more scan and then I will open it up for review.

cesco-f

LGTM!

nreese

kibana-presentation changes LGTM
code review only

nreese · 2025-11-21T15:55:17Z

src/platform/plugins/shared/dashboard/public/dashboard_client/get_dashboard_by_id_action.ts

@@ -0,0 +1,41 @@
+/*


Can you rename file to get_dashboards_by_ids_action to match export getDashboardsByIdsAction

nreese · 2025-11-21T15:57:57Z

src/platform/packages/shared/dashboards/dashboards-selector/components/dashboards_selector.tsx

-      });
-
-      const results = await Promise.all(dashboardPromises);
+      // Fetch dashboards by their IDs directly instead of fetching all dashboards


not sure comment is needed since it describes a change that no longer exists in the code base. This comment should be removed.

js-jankisalvi

~~Am I missing something, couldn't see any dashboards even though they are available~~
Edit: fixed

js-jankisalvi

Verified locally.

dashboards are visible in the dropdown
- while creating rule from dashboards or o11y > rules page
- while editing rules from o11y > rules page
not visible
- while creating/editing rule from stack management > rules or security solution > rules page

mgiota · 2025-11-26T09:42:15Z

@cesco-f I am trying to run the failing Synthetics tests locally, I get this error:

On CI the add test monitor step works fine. It is the next one should create status rule that fails. Do you have any idea why I get the following error? Can you share the commands you use to run e2e Synthetic tests locally?

mgiota · 2025-11-26T11:09:38Z

@js-jankisalvi Thanks for testing it out.

not visible
while creating/editing rule from stack management > rules

We actually want the related dashboards dropdown to be visible in the Stack Managamanet > Rules page as well. This was a bug, that I fixed in this commit

js-jankisalvi · 2025-11-26T11:24:29Z

@js-jankisalvi Thanks for testing it out.

not visible
while creating/editing rule from stack management > rules

We actually want the related dashboards dropdown to be visible in the Stack Managamanet > Rules page as well. This was a bug, that I fixed in this commit

Able to see and select dashboards while creating/editing rule from stack management > rules 👍

elasticmachine · 2025-11-26T16:08:22Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: d2d51e0
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-243496-d2d51e0e6453

Failed CI Steps

Build Project Image

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	2045	2044	-1
`dashboard`	946	947	+1
`datasetQuality`	894	893	-1
`discover`	1845	1844	-1
`infra`	1728	1727	-1
`ml`	2811	2810	-1
`monitoring`	750	749	-1
`observability`	1600	1599	-1
`slo`	1314	1313	-1
`synthetics`	1371	1370	-1
`transform`	811	810	-1
`triggersActionsUi`	1091	1090	-1
`uptime`	895	894	-1
total			-11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/response-ops-rule-form`	188	189	+1
`triggersActionsUi`	501	502	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.8MB	2.8MB	-478.0B
`dashboard`	673.7KB	674.0KB	+346.0B
`datasetQuality`	428.4KB	427.9KB	-478.0B
`discover`	1.2MB	1.2MB	-475.0B
`infra`	1.1MB	1.1MB	-478.0B
`ml`	5.6MB	5.6MB	-478.0B
`monitoring`	631.9KB	631.5KB	-478.0B
`observability`	1.7MB	1.7MB	-478.0B
`slo`	988.3KB	987.4KB	-962.0B
`synthetics`	1.0MB	1.0MB	-456.0B
`transform`	624.9KB	624.5KB	-478.0B
`triggersActionsUi`	1.5MB	1.5MB	-457.0B
`uptime`	490.7KB	490.2KB	-478.0B
total			-5.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dashboard`	17.6KB	17.7KB	+155.0B
`triggersActionsUi`	106.7KB	106.7KB	+66.0B
total			+221.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/response-ops-rule-form`	189	190	+1
`triggersActionsUi`	505	506	+1
total			+2

History

💛 Build #365745 was flaky ca2a811
💔 Build #365687 failed fe8dd3e
💔 Build #365556 failed fada513
💔 Build #364101 failed 0e7ea01
💔 Build #364042 failed c6f1c5d

Fixes elastic#243350 This PR fixes the issue where, no dashboards come up in the list when trying to link dashboards to a rule. Before <img width="1068" height="237" alt="515720113-9e346ea0-d5f6-4ef8-be8e-07db7d65743f (1)" src="https://github.com/user-attachments/assets/97cf3e1f-a8bb-46e5-a99a-2b74e2689015" /> **After** <img width="839" height="237" alt="Screenshot 2025-11-19 at 13 44 08" src="https://github.com/user-attachments/assets/86af5081-c71b-4b29-96ea-dae630681bba" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

temp, cursor assisted code

f358173

github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Nov 19, 2025

mgiota changed the title ~~temp, cursor assisted code~~ Fix empty Dashboard selector Nov 19, 2025

nreese reviewed Nov 19, 2025

View reviewed changes

mgiota added 3 commits November 19, 2025 19:35

PR feedback: use uiActions instead of contentManegement service

3a112f6

remove unneeded initializerContext

fa77772

revert addVersion to its original format

37b22ec

nreese reviewed Nov 19, 2025

View reviewed changes

cesco-f reviewed Nov 20, 2025

View reviewed changes

src/platform/packages/shared/dashboards/dashboards-selector/services/dashboard_service.ts Outdated Show resolved Hide resolved

mgiota and others added 2 commits November 20, 2025 14:30

remove dashboard service

14fde4a

Merge branch 'main' into fix_empty_related_dashboards

66c0223

cesco-f reviewed Nov 20, 2025

View reviewed changes

add unit tests

4434c0c

mgiota force-pushed the fix_empty_related_dashboards branch from 92ad275 to 4434c0c Compare November 20, 2025 13:30

mgiota added 2 commits November 20, 2025 15:38

remove redundant tests

6fc4bb5

FTR tests for related dashboards

c371e46

mgiota force-pushed the fix_empty_related_dashboards branch from 5455bc5 to 7a0d454 Compare November 20, 2025 14:38

PR feedback

9409d9c

mgiota force-pushed the fix_empty_related_dashboards branch from 7a0d454 to 9409d9c Compare November 20, 2025 14:43

mgiota and others added 4 commits November 20, 2025 16:48

Merge branch 'main' into fix_empty_related_dashboards

d0265fd

remove tests

90ea22c

remove duplicated comment

965ea23

no need to check for details tab, edit rule opens in a page

6c135d7

mgiota marked this pull request as ready for review November 20, 2025 20:10

mgiota requested review from a team as code owners November 20, 2025 20:10

Merge branch 'main' into fix_empty_related_dashboards

014a7d8

rename to getDashboardsByIds

6de775c

mgiota requested a review from cesco-f November 21, 2025 13:51

cesco-f approved these changes Nov 21, 2025

View reviewed changes

mgiota requested a review from nreese November 21, 2025 15:02

nreese approved these changes Nov 21, 2025

View reviewed changes

js-jankisalvi reviewed Nov 21, 2025

View reviewed changes

mgiota and others added 3 commits November 22, 2025 00:25

fix failing ftr tests

1d0898d

Merge branch 'main' into fix_empty_related_dashboards

c6f1c5d

Merge branch 'main' into fix_empty_related_dashboards

0e7ea01

js-jankisalvi approved these changes Nov 24, 2025

View reviewed changes

Merge branch 'main' into fix_empty_related_dashboards

e0fa3d0

botelastic bot added the Team:obs-ux-management label Nov 26, 2025

Changes from node scripts/regenerate_moon_projects.js --update

fada513

mgiota added 2 commits November 26, 2025 13:02

pass uiActions to the synthetics context

8eab8c6

add uiActions to the triggers_actions_ui plugin

fe8dd3e

fix type issues

ca2a811

mgiota enabled auto-merge (squash) November 26, 2025 12:34

mgiota disabled auto-merge November 26, 2025 14:18

mgiota and others added 2 commits November 26, 2025 16:21

fix redundant comment

fd37547

Merge branch 'main' into fix_empty_related_dashboards

d2d51e0

mgiota enabled auto-merge (squash) November 26, 2025 16:14

mgiota merged commit 2759b77 into elastic:main Nov 26, 2025
12 checks passed

kibanamachine added the v9.3.0 label Nov 26, 2025

mgiota self-assigned this Dec 3, 2025

Conversation

mgiota commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgiota Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

cesco-f commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese commented Nov 20, 2025

Uh oh!

mgiota commented Nov 20, 2025

Uh oh!

cesco-f left a comment

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

nreese Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

nreese Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

js-jankisalvi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

js-jankisalvi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgiota commented Nov 26, 2025

Uh oh!

mgiota commented Nov 26, 2025

Uh oh!

js-jankisalvi commented Nov 26, 2025

Uh oh!

elasticmachine commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mgiota commented Nov 19, 2025 •

edited

Loading

nreese Nov 19, 2025 •

edited

Loading

cesco-f commented Nov 20, 2025 •

edited

Loading

js-jankisalvi left a comment •

edited

Loading

js-jankisalvi left a comment •

edited

Loading

elasticmachine commented Nov 26, 2025 •

edited

Loading