[Dataset Quality] Failure store privilege fixes#232003
Merged
mohamedhamed-ahmed merged 13 commits intoelastic:mainfrom Aug 18, 2025
Merged
Conversation
mohamedhamed-ahmed
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
mohamedhamed-ahmed
changed the title
| </EuiFlexItem> | ||
| <EuiFlexItem grow={true}> | ||
| {!dataStreamSettingsLoading && !hasFailureStore && canUserReadFailureStore ? ( | ||
| {!dataStreamSettingsLoading && !(hasFailureStore && canUserReadFailureStore) ? ( |
| sortable: true, | ||
| render: (_: any, dataStreamStat: DataStreamStat) => { | ||
| if (!dataStreamStat.hasFailureStore) { | ||
| if ( |
|
|
||
| const canUserReadFailureStore = Boolean( | ||
| dataStreamStats?.some((ds) => ds.userPrivileges.canReadFailureStore) | ||
| Object.values(datasetUserPrivileges?.datasetsPrivilages ?? {})?.some( |
rStelmach
reviewed
Aug 18, 2025
Comment on lines
+105
to
+115
| canUserReadFailureStore && ( | ||
| <EuiLink | ||
| href={locator?.getRedirectUrl(locatorParams)} | ||
| target="_blank" | ||
| external={false} | ||
| > | ||
| {i18n.translate('xpack.datasetQuality.enableFailureStore', { | ||
| defaultMessage: 'Enable failure store', | ||
| })} | ||
| </EuiLink> | ||
| ) |
Contributor
There was a problem hiding this comment.
This code executes only when !(hasFailureStore && canUserReadFailureStore) is true, but then inside that statement, you're checking if canUserReadFailureStore is true. I think it that part might never execute.
Contributor
Author
There was a problem hiding this comment.
so the logic is if one of them or both are false we display the card.
then the link is only displayed if the user really has access to failure store and can enable it.
Contributor
There was a problem hiding this comment.
You are right, I got confused a bit
mohamedhamed-ahmed
added
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/17047140615 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
mohamedhamed-ahmed
added a commit
to mohamedhamed-ahmed/kibana
that referenced
this pull request
Aug 18, 2025
closes elastic#231836 closes elastic#231576 closes elastic#231564 (cherry picked from commit 371b1ff) # Conflicts: # x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/overview/quality_summary_cards/index.tsx
This was referenced Aug 18, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mohamedhamed-ahmed
added a commit
to mohamedhamed-ahmed/kibana
that referenced
this pull request
Aug 18, 2025
closes elastic#231836 closes elastic#231576 closes elastic#231564 (cherry picked from commit 371b1ff) # Conflicts: # x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/overview/quality_summary_cards/index.tsx
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Aug 18, 2025
10 tasks
mohamedhamed-ahmed
added a commit
that referenced
this pull request
Aug 19, 2025
…2142) # Backport This will backport the following commits from `main` to `8.19`: - [[Dataset Quality] Failure store privilege fixes (#232003)](#232003) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"mohamedhamed-ahmed","email":"mohamed.ahmed@elastic.co"},"sourceCommit":{"committedDate":"2025-08-18T16:59:23Z","message":"[Dataset Quality] Failure store privilege fixes (#232003)\n\ncloses https://github.com/elastic/kibana/issues/231836\ncloses https://github.com/elastic/kibana/issues/231576\ncloses https://github.com/elastic/kibana/issues/231564","sha":"371b1ff1b95a9747b01b27e110dd72f0794b6250","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Dataset Quality] Failure store privilege fixes","number":232003,"url":"https://github.com/elastic/kibana/pull/232003","mergeCommit":{"message":"[Dataset Quality] Failure store privilege fixes (#232003)\n\ncloses https://github.com/elastic/kibana/issues/231836\ncloses https://github.com/elastic/kibana/issues/231576\ncloses https://github.com/elastic/kibana/issues/231564","sha":"371b1ff1b95a9747b01b27e110dd72f0794b6250"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/232003","number":232003,"mergeCommit":{"message":"[Dataset Quality] Failure store privilege fixes (#232003)\n\ncloses https://github.com/elastic/kibana/issues/231836\ncloses https://github.com/elastic/kibana/issues/231576\ncloses https://github.com/elastic/kibana/issues/231564","sha":"371b1ff1b95a9747b01b27e110dd72f0794b6250"}}]}] BACKPORT-->
mohamedhamed-ahmed
added a commit
that referenced
this pull request
Aug 19, 2025
) # Backport This will backport the following commits from `main` to `9.1`: - [[Dataset Quality] Failure store privilege fixes (#232003)](#232003) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"mohamedhamed-ahmed","email":"mohamed.ahmed@elastic.co"},"sourceCommit":{"committedDate":"2025-08-18T16:59:23Z","message":"[Dataset Quality] Failure store privilege fixes (#232003)\n\ncloses https://github.com/elastic/kibana/issues/231836\ncloses https://github.com/elastic/kibana/issues/231576\ncloses https://github.com/elastic/kibana/issues/231564","sha":"371b1ff1b95a9747b01b27e110dd72f0794b6250","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Dataset Quality] Failure store privilege fixes","number":232003,"url":"https://github.com/elastic/kibana/pull/232003","mergeCommit":{"message":"[Dataset Quality] Failure store privilege fixes (#232003)\n\ncloses https://github.com/elastic/kibana/issues/231836\ncloses https://github.com/elastic/kibana/issues/231576\ncloses https://github.com/elastic/kibana/issues/231564","sha":"371b1ff1b95a9747b01b27e110dd72f0794b6250"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/232003","number":232003,"mergeCommit":{"message":"[Dataset Quality] Failure store privilege fixes (#232003)\n\ncloses https://github.com/elastic/kibana/issues/231836\ncloses https://github.com/elastic/kibana/issues/231576\ncloses https://github.com/elastic/kibana/issues/231564","sha":"371b1ff1b95a9747b01b27e110dd72f0794b6250"}}]}] BACKPORT-->
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #231836
closes #231576
closes #231564