Skip to content

[Dataset Quality] Failure store privilege fixes #232003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohamedhamed-ahmed merged 13 commits into from
Aug 18, 2025
Merged

[Dataset Quality] Failure store privilege fixes #232003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f0dcbf1
[Dataset Quality] Fix Flaky Test
mohamedhamed-ahmed Aug 12, 2025
a13924e
Fix Serverless Tests
mohamedhamed-ahmed Aug 12, 2025
2c1578f
Merge branch 'main' of https://github.com/mohamedhamed-ahmed/kibana
mohamedhamed-ahmed Aug 13, 2025
53f76fd
Merge branch 'main' of https://github.com/mohamedhamed-ahmed/kibana
mohamedhamed-ahmed Aug 13, 2025
bae92b0
Merge branch 'main' of https://github.com/mohamedhamed-ahmed/kibana
mohamedhamed-ahmed Aug 14, 2025
fc29269
mohamedhamed-ahmed Aug 15, 2025
5fea582
Merge branch 'main' of https://github.com/mohamedhamed-ahmed/kibana
mohamedhamed-ahmed Aug 15, 2025
43a2212
Merge branch 'main' of https://github.com/mohamedhamed-ahmed/kibana
mohamedhamed-ahmed Aug 16, 2025
63fa39b
[Dataset Quality] Fix failure store card privilege check
mohamedhamed-ahmed Aug 16, 2025
e2571cd
Fix Logic
mohamedhamed-ahmed Aug 16, 2025
32284af
Bug Fix
mohamedhamed-ahmed Aug 16, 2025
98ef295
Bug Fix
mohamedhamed-ahmed Aug 16, 2025
d9667cb
Merge branch 'main' into 231836-dataset-quality-details-failure-store…
mohamedhamed-ahmed Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...atform/plugins/shared/dataset_quality/public/components/dataset_quality/table/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,10 @@ export const getDatasetQualityTableColumns = ({
field: 'failedDocs.percentage',
sortable: true,
render: (_: any, dataStreamStat: DataStreamStat) => {
if (!dataStreamStat.hasFailureStore) {
if (
Copy link
Copy Markdown
Contributor Author

@mohamedhamed-ahmed mohamedhamed-ahmed Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for #231576

!dataStreamStat.hasFailureStore &&
dataStreamStat.userPrivileges?.canReadFailureStore
) {
const FailureStoreHoverLink = () => {
const [hovered, setHovered] = React.useState(false);
const locator = urlService.locators.get('INDEX_MANAGEMENT_LOCATOR_ID');
Expand Down
22 changes: 12 additions & 10 deletions ...uality/public/components/dataset_quality_details/overview/quality_summary_cards/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,23 +94,25 @@ export default function QualitySummaryCards({
/>
</EuiFlexItem>
<EuiFlexItem grow={true}>
{!dataStreamSettingsLoading && !hasFailureStore && canUserReadFailureStore ? (
{!dataStreamSettingsLoading && !(hasFailureStore && canUserReadFailureStore) ? (
Copy link
Copy Markdown
Contributor Author

@mohamedhamed-ahmed mohamedhamed-ahmed Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for #231836

<Card
isDisabled={true}
title={overviewPanelDatasetQualityIndicatorFailedDocs}
kpiValue={i18n.translate('xpack.datasetQuality.noFailureStoreTitle', {
defaultMessage: 'No failure store',
})}
footer={
<EuiLink
href={locator?.getRedirectUrl(locatorParams)}
target="_blank"
external={false}
>
{i18n.translate('xpack.datasetQuality.enableFailureStore', {
defaultMessage: 'Enable failure store',
})}
</EuiLink>
canUserReadFailureStore && (
<EuiLink
href={locator?.getRedirectUrl(locatorParams)}
target="_blank"
external={false}
>
{i18n.translate('xpack.datasetQuality.enableFailureStore', {
defaultMessage: 'Enable failure store',
})}
</EuiLink>
)
Comment on lines +105 to +115
Copy link
Copy Markdown
Contributor

@rStelmach rStelmach Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code executes only when !(hasFailureStore && canUserReadFailureStore) is true, but then inside that statement, you're checking if canUserReadFailureStore is true. I think it that part might never execute.

Copy link
Copy Markdown
Contributor Author

@mohamedhamed-ahmed mohamedhamed-ahmed Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the logic is if one of them or both are false we display the card.

then the link is only displayed if the user really has access to failure store and can enable it.

Copy link
Copy Markdown
Contributor

@rStelmach rStelmach Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I got confused a bit

}
/>
) : (
Expand Down
7 changes: 4 additions & 3 deletions x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_dataset_quality_state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,17 @@ import { useDatasetQualityContext } from '../components/dataset_quality/context'
export const useDatasetQualityState = () => {
const { service } = useDatasetQualityContext();

const { datasetUserPrivileges, dataStreamStats } =
useSelector(service, (state) => state.context) ?? {};
const { datasetUserPrivileges } = useSelector(service, (state) => state.context) ?? {};

const statsLoading = useSelector(
service,
(state) => state.matches('initializing') || state.matches('main.stats.datasets.fetching')
);

const canUserReadFailureStore = Boolean(
dataStreamStats?.some((ds) => ds.userPrivileges.canReadFailureStore)
Object.values(datasetUserPrivileges?.datasetsPrivilages ?? {})?.some(
Copy link
Copy Markdown
Contributor Author

@mohamedhamed-ahmed mohamedhamed-ahmed Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for #231564

(privilege) => privilege.canReadFailureStore
)
);

const canUserMonitorAnyDataset = Boolean(
Expand Down