Skip to content

[Synthetics] Return legacy monitor filters#231562

Merged
cesco-f merged 4 commits intoelastic:mainfrom
cesco-f:fix-synthetics
Aug 18, 2025
Merged

[Synthetics] Return legacy monitor filters#231562
cesco-f merged 4 commits intoelastic:mainfrom
cesco-f:fix-synthetics

Conversation

@cesco-f
Copy link
Copy Markdown
Contributor

@cesco-f cesco-f commented Aug 13, 2025 •
edited by kibanamachine
Loading

It closes #231556

@cesco-f cesco-f requested a review from a team as a code owner August 13, 2025 07:15
@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Aug 13, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 13, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Aug 13, 2025
@dominiqueclarke dominiqueclarke self-requested a review August 15, 2025 13:32
@dominiqueclarke
Copy link
Copy Markdown
Contributor

dominiqueclarke commented Aug 15, 2025

Hi @cesco-f Did you see Shahzad's comment here? My initial thought is that think implementation would have been thoroughly tested when originally implemented.

What's your thoughts on the differences between your implementation and Shahzad's?

@cesco-f
Copy link
Copy Markdown
Contributor Author

cesco-f commented Aug 18, 2025

Hey @dominiqueclarke,

The main difference is that I'm not making 2 requests with the saved object client, but the implementations are basically the same.

shahzad31
shahzad31 approved these changes Aug 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 18, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #19 / Dataset Quality Dataset quality handles user privileges User has access to dataset quality with limited privileges User has access to a multipl data streams "before all" hook for "types filter should be rendered"

Metrics [docs]

✅ unchanged

History

@cesco-f cesco-f merged commit 9046fd4 into elastic:main Aug 18, 2025
12 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 18, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/17041797170

@cesco-f cesco-f deleted the fix-synthetics branch August 18, 2025 13:26
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 18, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
❌ 9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 231562

Questions ?

Please refer to the Backport tool documentation

This was referenced Aug 18, 2025
Merged
Merged
@cesco-f
Copy link
Copy Markdown
Contributor Author

cesco-f commented Aug 18, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cesco-f added a commit to cesco-f/kibana that referenced this pull request Aug 18, 2025
@cesco-f
[Synthetics] Return legacy monitor filters (elastic#231562)
4d10a28 
(cherry picked from commit 9046fd4)

# Conflicts:
#	x-pack/solutions/observability/test/api_integration_deployment_agnostic/apis/synthetics/get_filters.ts
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
@cesco-f @NicholasPeretti
[Synthetics] Return legacy monitor filters (elastic#231562)
0a12210
@kibanamachine kibanamachine mentioned this pull request Aug 18, 2025
Merged
cesco-f added a commit that referenced this pull request Aug 18, 2025
@cesco-f @kibanamachine
[8.19] [Synthetics] Return legacy monitor filters (#231562) (#232107)
1bcab40 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Synthetics] Return legacy monitor filters
(#231562)](#231562)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-08-18T13:19:28Z","message":"[Synthetics]
Return legacy monitor filters
(#231562)","sha":"9046fd4d1e566ddffc7f6dc39cada9332d46117f","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.2.0","v9.1.3","v8.19.3"],"title":"[Synthetics]
Return legacy monitor
filters","number":231562,"url":"https://github.com/elastic/kibana/pull/231562","mergeCommit":{"message":"[Synthetics]
Return legacy monitor filters
(#231562)","sha":"9046fd4d1e566ddffc7f6dc39cada9332d46117f"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231562","number":231562,"mergeCommit":{"message":"[Synthetics]
Return legacy monitor filters
(#231562)","sha":"9046fd4d1e566ddffc7f6dc39cada9332d46117f"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
cesco-f added a commit that referenced this pull request Aug 18, 2025
@cesco-f
[9.1] [Synthetics] Return legacy monitor filters (#231562) (#232106)
04077ba 
# Backport

This will backport the following commits from `main` to `9.1`:
- [[Synthetics] Return legacy monitor filters
(#231562)](#231562)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-08-18T13:19:28Z","message":"[Synthetics]
Return legacy monitor filters
(#231562)","sha":"9046fd4d1e566ddffc7f6dc39cada9332d46117f","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.2.0","v9.1.3","v8.19.3"],"title":"[Synthetics]
Return legacy monitor
filters","number":231562,"url":"https://github.com/elastic/kibana/pull/231562","mergeCommit":{"message":"[Synthetics]
Return legacy monitor filters
(#231562)","sha":"9046fd4d1e566ddffc7f6dc39cada9332d46117f"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231562","number":231562,"mergeCommit":{"message":"[Synthetics]
Return legacy monitor filters
(#231562)","sha":"9046fd4d1e566ddffc7f6dc39cada9332d46117f"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
qn895 pushed a commit to qn895/kibana that referenced this pull request Aug 26, 2025
@cesco-f @qn895
[Synthetics] Return legacy monitor filters (elastic#231562)
a113927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@dominiqueclarke dominiqueclarke Awaiting requested review from dominiqueclarke

Assignees

No one assigned

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels release_note:fix Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.3 v9.1.3 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [Synthetics] Overview filters are inaccurate

5 participants

@cesco-f @elasticmachine @dominiqueclarke @kibanamachine @shahzad31