Fix violations of the @elastic/eui/no-unnamed-radio-group ESLint rule #230068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
Project:Accessibility
release_note:skip
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
…agement/pages/policy/view/policy_settings_form/components/detect_prevent_protection_level.tsx Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
Bamieh
approved these changes
Aug 12, 2025
Contributor
Bamieh
left a comment
Bamieh
left a comment
There was a problem hiding this comment.
core changes lgtm (1 file change adding name property to EuiRadioGroup)
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
Contributor
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16920178642 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Aug 14, 2025
…elastic#230068) Closes: elastic#212887 ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-radio-group` elastic/eui#8929 rule. This rule ensures that all radio input components have a name attribute. The name attribute is required for radio inputs to be grouped correctly, allowing users to select only one option from a set. Without it, radios may not behave as expected and can cause accessibility issues for assistive technologies. ## Changes Made 1. Set the `name` attribute for all radio components. Similar changes have been applied across the entire `Kibana` codebase. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Aug 18, 2025
…elastic#230068) Closes: elastic#212887 ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-radio-group` elastic/eui#8929 rule. This rule ensures that all radio input components have a name attribute. The name attribute is required for radio inputs to be grouped correctly, allowing users to select only one option from a set. Without it, radios may not behave as expected and can cause accessibility issues for assistive technologies. ## Changes Made 1. Set the `name` attribute for all radio components. Similar changes have been applied across the entire `Kibana` codebase. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com> (cherry picked from commit 3b1354f) # Conflicts: # x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/aws_credentials_form/aws_account_type_selector.tsx # x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/azure_credentials_form/azure_account_type_selector.tsx # x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/csp_boxed_radio_group.tsx # x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/gcp_credentials_form/gcp_account_type_selector.tsx # x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/gcp_credentials_form/gcp_credential_form.tsx # x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/policy_template_selectors.tsx # x-pack/solutions/security/plugins/cloud_security_posture/public/components/fleet_extensions/cnvm_kspm/kspm_eks_input_selector.tsx
alexwizp
added a commit
that referenced
this pull request
Aug 18, 2025
…t rule (#230068) (#232094) # Backport This will backport the following commits from `main` to `9.1`: - [Fix violations of the @elastic/eui/no-unnamed-radio-group ESLint rule (#230068)](#230068) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-12T20:31:35Z","message":"Fix violations of the @elastic/eui/no-unnamed-radio-group ESLint rule (#230068)\n\nCloses: https://github.com/elastic/kibana/issues/212887\n\n## Summary\n\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/no-unnamed-radio-group`\nhttps://github.com/elastic/eui/pull/8929 rule. This rule ensures that\nall radio input components have a name attribute. The name attribute is\nrequired for radio inputs to be grouped correctly, allowing users to\nselect only one option from a set. Without it, radios may not behave as\nexpected and can cause accessibility issues for assistive technologies.\n\n## Changes Made\n\n1. Set the `name` attribute for all radio components. Similar changes\nhave been applied across the entire `Kibana` codebase.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>","sha":"3b1354fc8b4e2cb9e274e813773bb705d026c24c","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport missing","Team:Fleet","backport:prev-minor","Team:obs-ux-management","v9.2.0"],"title":"Fix violations of the @elastic/eui/no-unnamed-radio-group ESLint rule","number":230068,"url":"https://github.com/elastic/kibana/pull/230068","mergeCommit":{"message":"Fix violations of the @elastic/eui/no-unnamed-radio-group ESLint rule (#230068)\n\nCloses: https://github.com/elastic/kibana/issues/212887\n\n## Summary\n\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/no-unnamed-radio-group`\nhttps://github.com/elastic/eui/pull/8929 rule. This rule ensures that\nall radio input components have a name attribute. The name attribute is\nrequired for radio inputs to be grouped correctly, allowing users to\nselect only one option from a set. Without it, radios may not behave as\nexpected and can cause accessibility issues for assistive technologies.\n\n## Changes Made\n\n1. Set the `name` attribute for all radio components. Similar changes\nhave been applied across the entire `Kibana` codebase.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>","sha":"3b1354fc8b4e2cb9e274e813773bb705d026c24c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230068","number":230068,"mergeCommit":{"message":"Fix violations of the @elastic/eui/no-unnamed-radio-group ESLint rule (#230068)\n\nCloses: https://github.com/elastic/kibana/issues/212887\n\n## Summary\n\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/no-unnamed-radio-group`\nhttps://github.com/elastic/eui/pull/8929 rule. This rule ensures that\nall radio input components have a name attribute. The name attribute is\nrequired for radio inputs to be grouped correctly, allowing users to\nselect only one option from a set. Without it, radios may not behave as\nexpected and can cause accessibility issues for assistive technologies.\n\n## Changes Made\n\n1. Set the `name` attribute for all radio components. Similar changes\nhave been applied across the entire `Kibana` codebase.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>","sha":"3b1354fc8b4e2cb9e274e813773bb705d026c24c"}}]}] BACKPORT-->
kibanamachine
added
v9.1.3
and removed
backport missing
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…elastic#230068) Closes: elastic#212887 ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-radio-group` elastic/eui#8929 rule. This rule ensures that all radio input components have a name attribute. The name attribute is required for radio inputs to be grouped correctly, allowing users to select only one option from a set. Without it, radios may not behave as expected and can cause accessibility issues for assistive technologies. ## Changes Made 1. Set the `name` attribute for all radio components. Similar changes have been applied across the entire `Kibana` codebase. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
…elastic#230068) Closes: elastic#212887 ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-radio-group` elastic/eui#8929 rule. This rule ensures that all radio input components have a name attribute. The name attribute is required for radio inputs to be grouped correctly, allowing users to select only one option from a set. Without it, radios may not behave as expected and can cause accessibility issues for assistive technologies. ## Changes Made 1. Set the `name` attribute for all radio components. Similar changes have been applied across the entire `Kibana` codebase. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed. (cherry picked from commit 25b903b)
VladimirFilonov
pushed a commit
to VladimirFilonov/kibana
that referenced
this pull request
Sep 30, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed.
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2025
…s` eslint rule (#236763) (#236901) # Backport This will backport the following commits from `main` to `9.1`: - [fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)](#236763) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-09-30T09:07:58Z","message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:version","v9.2.0","v9.1.5"],"title":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule","number":236763,"url":"https://github.com/elastic/kibana/pull/236763","mergeCommit":{"message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236763","number":236763,"mergeCommit":{"message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466"}},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #212887
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/no-unnamed-radio-groupelastic/eui#8929 rule. This rule ensures that all radio input components have a name attribute. The name attribute is required for radio inputs to be grouped correctly, allowing users to select only one option from a set. Without it, radios may not behave as expected and can cause accessibility issues for assistive technologies.Changes Made
nameattribute for all radio components. Similar changes have been applied across the entireKibanacodebase.