Skip to content

[9.1] Fix violations of the @elastic/eui/no-unnamed-radio-group ESLint rule (#230068)#232094

Merged
alexwizp merged 2 commits intoelastic:9.1from
alexwizp:backport/9.1/pr-230068
Aug 18, 2025
Merged

[9.1] Fix violations of the @elastic/eui/no-unnamed-radio-group ESLint rule (#230068)#232094
alexwizp merged 2 commits intoelastic:9.1from
alexwizp:backport/9.1/pr-230068

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…elastic#230068)

Closes: elastic#212887

## Summary

This PR applies the auto-fix for the newly introduced
`@elastic/eui/no-unnamed-radio-group`
elastic/eui#8929 rule. This rule ensures that
all radio input components have a name attribute. The name attribute is
required for radio inputs to be grouped correctly, allowing users to
select only one option from a set. Without it, radios may not behave as
expected and can cause accessibility issues for assistive technologies.

## Changes Made

1. Set the `name` attribute for all radio components. Similar changes
have been applied across the entire `Kibana` codebase.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
(cherry picked from commit 3b1354f)

# Conflicts:
#	x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/aws_credentials_form/aws_account_type_selector.tsx
#	x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/azure_credentials_form/azure_account_type_selector.tsx
#	x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/csp_boxed_radio_group.tsx
#	x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/gcp_credentials_form/gcp_account_type_selector.tsx
#	x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/gcp_credentials_form/gcp_credential_form.tsx
#	x-pack/solutions/security/packages/kbn-cloud-security-posture/public/src/components/fleet_extensions/policy_template_selectors.tsx
#	x-pack/solutions/security/plugins/cloud_security_posture/public/components/fleet_extensions/cnvm_kspm/kspm_eks_input_selector.tsx
@alexwizp alexwizp added the backport This PR is a backport of another PR label Aug 18, 2025
@alexwizp alexwizp enabled auto-merge (squash) August 18, 2025 13:59
@botelastic botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Aug 18, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@bhavyarm bhavyarm self-requested a review August 18, 2025 14:10
Copy link
Copy Markdown
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp merged commit 5892fdc into elastic:9.1 Aug 18, 2025
12 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 709 727 +18
esUiShared 192 210 +18
securitySolution 7771 7789 +18
total +54

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 509.1KB 509.1KB +28.0B
automaticImport 1.1MB 1.1MB +54.0B
cloudSecurityPosture 556.3KB 561.4KB +5.1KB
controls 478.7KB 478.8KB +44.0B
dataVisualizer 681.4KB 681.4KB +28.0B
fleet 2.1MB 2.1MB +177.0B
indexLifecycleManagement 162.2KB 162.2KB +24.0B
infra 1.0MB 1.0MB +37.0B
ingestPipelines 359.7KB 359.7KB +21.0B
links 114.3KB 114.3KB +16.0B
maps 3.1MB 3.1MB +131.0B
ml 5.4MB 5.4MB +152.0B
osquery 1.0MB 1.0MB +32.0B
savedObjectsManagement 82.9KB 83.0KB +27.0B
securitySolution 9.8MB 9.8MB +5.2KB
slo 989.6KB 989.6KB +14.0B
spaces 209.3KB 209.4KB +23.0B
stackAlerts 64.9KB 64.9KB +18.0B
transform 625.2KB 625.2KB +28.0B
total +11.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 89.2KB 94.1KB +4.9KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants