Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule#226787
Merged
alexwizp merged 24 commits intoelastic:mainfrom Jul 18, 2025
Merged
Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule#226787alexwizp merged 24 commits intoelastic:mainfrom
alexwizp merged 24 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
alexwizp
commented
Jul 7, 2025
| describedByIds={idAria ? [idAria] : undefined} | ||
| {...rest} | ||
| > | ||
| <EuiComboBox<PackOption> |
Contributor
Author
There was a problem hiding this comment.
@elastic/security-defend-workflows please review
Contributor
Author
|
@elastic/obs-ux-management-team, @elastic/stack-monitoring please review |
…alid-props # Conflicts: # x-pack/solutions/observability/packages/kbn-custom-integrations/src/components/create/form.tsx
parkiino
approved these changes
Jul 16, 2025
Contributor
parkiino
left a comment
parkiino
left a comment
There was a problem hiding this comment.
defend workflow changes 👍
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
Contributor
Author
|
@elastic/obs-ux-management-team please review |
Contributor
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16365801395 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 18, 2025
…SLint rule (elastic#226787) ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/consistent-is-invalid-props` ESLint rule across the codebase. The rule ensures consistent validation state handling between `EuiFormRow` components and their child form controls. ## Changes - Auto-fixed instances where `isInvalid` prop values were inconsistent between parent `EuiFormRow` components and their form control children ## Related - elastic/eui#8843 --------- Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 00082ef)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 18, 2025
…rops ESLint rule (#226787) (#228557) # Backport This will backport the following commits from `main` to `9.1`: - [Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule (#226787)](#226787) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-07-18T08:20:03Z","message":"Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule (#226787)\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/consistent-is-invalid-props` ESLint rule across the\ncodebase. The rule ensures consistent validation state handling between\n`EuiFormRow` components and their child form controls.\n\n## Changes\n- Auto-fixed instances where `isInvalid` prop values were inconsistent\nbetween parent `EuiFormRow` components and their form control children\n\n## Related\n- elastic/eui#8843\n\n---------\n\nCo-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"00082ef4b2ad0fa144c3bc1f648da0b9dc15ca02","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:Fleet","backport:prev-minor","Team:obs-ux-infra_services","Team:obs-ux-management","v9.2.0"],"title":"Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule","number":226787,"url":"https://github.com/elastic/kibana/pull/226787","mergeCommit":{"message":"Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule (#226787)\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/consistent-is-invalid-props` ESLint rule across the\ncodebase. The rule ensures consistent validation state handling between\n`EuiFormRow` components and their child form controls.\n\n## Changes\n- Auto-fixed instances where `isInvalid` prop values were inconsistent\nbetween parent `EuiFormRow` components and their form control children\n\n## Related\n- elastic/eui#8843\n\n---------\n\nCo-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"00082ef4b2ad0fa144c3bc1f648da0b9dc15ca02"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226787","number":226787,"mergeCommit":{"message":"Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule (#226787)\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/consistent-is-invalid-props` ESLint rule across the\ncodebase. The rule ensures consistent validation state handling between\n`EuiFormRow` components and their child form controls.\n\n## Changes\n- Auto-fixed instances where `isInvalid` prop values were inconsistent\nbetween parent `EuiFormRow` components and their form control children\n\n## Related\n- elastic/eui#8843\n\n---------\n\nCo-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"00082ef4b2ad0fa144c3bc1f648da0b9dc15ca02"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
…SLint rule (elastic#226787) ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/consistent-is-invalid-props` ESLint rule across the codebase. The rule ensures consistent validation state handling between `EuiFormRow` components and their child form controls. ## Changes - Auto-fixed instances where `isInvalid` prop values were inconsistent between parent `EuiFormRow` components and their form control children ## Related - elastic/eui#8843 --------- Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…SLint rule (elastic#226787) ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/consistent-is-invalid-props` ESLint rule across the codebase. The rule ensures consistent validation state handling between `EuiFormRow` components and their child form controls. ## Changes - Auto-fixed instances where `isInvalid` prop values were inconsistent between parent `EuiFormRow` components and their form control children ## Related - elastic/eui#8843 --------- Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed. (cherry picked from commit 25b903b)
VladimirFilonov
pushed a commit
to VladimirFilonov/kibana
that referenced
this pull request
Sep 30, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed.
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2025
…s` eslint rule (#236763) (#236901) # Backport This will backport the following commits from `main` to `9.1`: - [fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)](#236763) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-09-30T09:07:58Z","message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:version","v9.2.0","v9.1.5"],"title":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule","number":236763,"url":"https://github.com/elastic/kibana/pull/236763","mergeCommit":{"message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236763","number":236763,"mergeCommit":{"message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466"}},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/consistent-is-invalid-propsESLint rule across the codebase. The rule ensures consistent validation state handling betweenEuiFormRowcomponents and their child form controls.Changes
isInvalidprop values were inconsistent between parentEuiFormRowcomponents and their form control childrenRelated