Skip to content

Conversation

@tkajtoch
Copy link
Member

106.1.0106.2.0

Questions? Please see our Kibana upgrade FAQ.

Package updates

@elastic/eui

v106.2.0

  • Enhanced EuiCheckableCard to make non-interactive children clickable for card selection (#8907)
  • Added showFooter and toolbarProps.right props to EuiMarkdownEditor for more flexible layout control. (#8889) (#8889)

Bug fixes

  • Fixed EuiPopover not closing on outside click after multiple fast clicks on the trigger element (#8882)

Accessibility

  • Added accessible labels to virtualized EuiCodeBlock (#8887)

@tkajtoch tkajtoch self-assigned this Jul 28, 2025
@tkajtoch tkajtoch added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting v9.2.0 labels Jul 28, 2025
@tkajtoch
Copy link
Member Author

@elasticmachine merge upstream

elasticmachine and others added 2 commits July 30, 2025 23:16
…e aware of the `overwrite` copy mode being available only when `createNewCopies` is false
@tkajtoch
Copy link
Member Author

tkajtoch commented Aug 1, 2025

@elasticmachine merge upstream

const label = await form.findByCssSelector('label[for="createNewCopiesDisabled"]');
await label.click();

if (!overwrite) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is needed since the original test logic was executing clicks on disabled overwrite inputs.

Historically, this was a no-op, and executing the click had no adverse effects. With the recent change to EuiCheckableCard when there are no child interactive elements, clicking on the card results in selection of its radio button. A disabled input is considered non-interactive, which is the reason why this started failing.

@tkajtoch tkajtoch marked this pull request as ready for review August 1, 2025 22:34
@tkajtoch tkajtoch requested review from a team as code owners August 1, 2025 22:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #16 / Air-gapped environment with pre-bundled packages @ess @serverless @skipInServerlessMKI Install bundled package should install prebuilt rules from the package that comes bundled with Kibana

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 506.9KB 507.0KB +56.0B
kbnUiSharedDeps-npmDll 6.5MB 6.5MB +1.5KB
total +1.5KB

History

cc @tkajtoch

@tkajtoch tkajtoch merged commit 837d16d into elastic:main Aug 5, 2025
14 checks passed
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
`106.1.0` ⏩ `106.2.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0)

- Enhanced `EuiCheckableCard` to make non-interactive children clickable
for card selection ([elastic#8907](elastic/eui#8907))
- Added `showFooter` and `toolbarProps.right` props to
`EuiMarkdownEditor` for more flexible layout control.
([elastic#8889](elastic/eui#8889))
([elastic#8889](elastic/eui#8889))

**Bug fixes**

- Fixed `EuiPopover` not closing on outside click after multiple fast
clicks on the trigger element
([elastic#8882](elastic/eui#8882))

**Accessibility**

- Added accessible labels to virtualized `EuiCodeBlock`
([elastic#8887](elastic/eui#8887))

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
`106.1.0` ⏩ `106.2.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0)

- Enhanced `EuiCheckableCard` to make non-interactive children clickable
for card selection ([elastic#8907](elastic/eui#8907))
- Added `showFooter` and `toolbarProps.right` props to
`EuiMarkdownEditor` for more flexible layout control.
([elastic#8889](elastic/eui#8889))
([elastic#8889](elastic/eui#8889))

**Bug fixes**

- Fixed `EuiPopover` not closing on outside click after multiple fast
clicks on the trigger element
([elastic#8882](elastic/eui#8882))

**Accessibility**

- Added accessible labels to virtualized `EuiCodeBlock`
([elastic#8887](elastic/eui#8887))

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants