-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Upgrade EUI to v106.2.0 #229725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v106.2.0 #229725
Conversation
|
@elasticmachine merge upstream |
…e aware of the `overwrite` copy mode being available only when `createNewCopies` is false
|
@elasticmachine merge upstream |
| const label = await form.findByCssSelector('label[for="createNewCopiesDisabled"]'); | ||
| await label.click(); | ||
|
|
||
| if (!overwrite) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is needed since the original test logic was executing clicks on disabled overwrite inputs.
Historically, this was a no-op, and executing the click had no adverse effects. With the recent change to EuiCheckableCard when there are no child interactive elements, clicking on the card results in selection of its radio button. A disabled input is considered non-interactive, which is the reason why this started failing.
|
Pinging @elastic/eui-team (EUI) |
jbudz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
cc @tkajtoch |
`106.1.0` ⏩ `106.2.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0) - Enhanced `EuiCheckableCard` to make non-interactive children clickable for card selection ([elastic#8907](elastic/eui#8907)) - Added `showFooter` and `toolbarProps.right` props to `EuiMarkdownEditor` for more flexible layout control. ([elastic#8889](elastic/eui#8889)) ([elastic#8889](elastic/eui#8889)) **Bug fixes** - Fixed `EuiPopover` not closing on outside click after multiple fast clicks on the trigger element ([elastic#8882](elastic/eui#8882)) **Accessibility** - Added accessible labels to virtualized `EuiCodeBlock` ([elastic#8887](elastic/eui#8887)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Marta Bondyra <[email protected]>
`106.1.0` ⏩ `106.2.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0) - Enhanced `EuiCheckableCard` to make non-interactive children clickable for card selection ([elastic#8907](elastic/eui#8907)) - Added `showFooter` and `toolbarProps.right` props to `EuiMarkdownEditor` for more flexible layout control. ([elastic#8889](elastic/eui#8889)) ([elastic#8889](elastic/eui#8889)) **Bug fixes** - Fixed `EuiPopover` not closing on outside click after multiple fast clicks on the trigger element ([elastic#8882](elastic/eui#8882)) **Accessibility** - Added accessible labels to virtualized `EuiCodeBlock` ([elastic#8887](elastic/eui#8887)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Marta Bondyra <[email protected]>
106.1.0⏩106.2.0Questions? Please see our Kibana upgrade FAQ.
Package updates
@elastic/euiv106.2.0EuiCheckableCardto make non-interactive children clickable for card selection (#8907)showFooterandtoolbarProps.rightprops toEuiMarkdownEditorfor more flexible layout control. (#8889) (#8889)Bug fixes
EuiPopovernot closing on outside click after multiple fast clicks on the trigger element (#8882)Accessibility
EuiCodeBlock(#8887)