-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Dashboard] Add Inline Markdown Visualization #229191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e8e6567 to
f2e43c4
Compare
🔍 Preview links for changed docs |
csr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review only, src/platform/test/functional/page_objects/index.ts codeowner change LGTM. I'm very excited about this feature! 🎉
dokmic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core changes LGTM. Although the kibana.jsonc change is unnecessary.
markov00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review only for owned code
| }: MarkdownEditorProps) => { | ||
| const styles = useMemoCss(componentStyles); | ||
| const isPreview = useStateFromPublishingSubject(isPreview$); | ||
| const [value, onChange] = React.useState(content); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add useState from the React import
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
|
## Summary Fixes elastic#188910 ### Features * Inline editing * Editor focus persists when toggling between edit/preview * Pressing `Escape` while editing moves focus to **Discard**; pressing `Escape` again cancels editing * All user-defined links open in a new tab **Legacy Markdown:** * Editing disabled * Tool added to convert old markdown to the new format --- **View Mode:** <img width="757" height="471" alt="View Mode" src="https://github.com/user-attachments/assets/7e80daf1-4a58-43ff-a8fb-881e14942d49" /> **Empty Editor Mode:** <img width="755" height="466" alt="Empty Editor" src="https://github.com/user-attachments/assets/0add643f-ffad-4a35-9a97-767fc773e185" /> **Editor Mode:** <img width="754" height="462" alt="Editor Mode" src="https://github.com/user-attachments/assets/eb6ec81d-7ade-4c92-a169-64572bad185f" /> **Preview Mode:** <img width="759" height="466" alt="Preview Mode" src="https://github.com/user-attachments/assets/674a4954-fff5-4667-b700-4916822fcb2e" /> https://github.com/user-attachments/assets/71b230e9-b098-4292-a747-232ece5dcd2e --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Fixes elastic#188910 ### Features * Inline editing * Editor focus persists when toggling between edit/preview * Pressing `Escape` while editing moves focus to **Discard**; pressing `Escape` again cancels editing * All user-defined links open in a new tab **Legacy Markdown:** * Editing disabled * Tool added to convert old markdown to the new format --- **View Mode:** <img width="757" height="471" alt="View Mode" src="https://github.com/user-attachments/assets/7e80daf1-4a58-43ff-a8fb-881e14942d49" /> **Empty Editor Mode:** <img width="755" height="466" alt="Empty Editor" src="https://github.com/user-attachments/assets/0add643f-ffad-4a35-9a97-767fc773e185" /> **Editor Mode:** <img width="754" height="462" alt="Editor Mode" src="https://github.com/user-attachments/assets/eb6ec81d-7ade-4c92-a169-64572bad185f" /> **Preview Mode:** <img width="759" height="466" alt="Preview Mode" src="https://github.com/user-attachments/assets/674a4954-fff5-4667-b700-4916822fcb2e" /> https://github.com/user-attachments/assets/71b230e9-b098-4292-a747-232ece5dcd2e --------- Co-authored-by: kibanamachine <[email protected]>
This PR updates the page https://www.elastic.co/docs/explore-analyze/visualize/text-panels to reflect the new Inline markdown editor. Relates to elastic/kibana#229191 Closes #3076 --------- Co-authored-by: florent-leborgne <[email protected]>
This PR updates the page https://www.elastic.co/docs/explore-analyze/visualize/text-panels to reflect the new Inline markdown editor. Relates to elastic/kibana#229191 Closes elastic#3076 --------- Co-authored-by: florent-leborgne <[email protected]>
Summary
Fixes #188910
Features
Escapewhile editing moves focus to Discard; pressingEscapeagain cancels editingLegacy Markdown:
View Mode:
Empty Editor Mode:
Editor Mode:
Preview Mode:
Jul-28-2025.16-18-58.mp4