Skip to content

Conversation

@mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jul 23, 2025

Summary

Fixes #188910

Features

  • Inline editing
  • Editor focus persists when toggling between edit/preview
  • Pressing Escape while editing moves focus to Discard; pressing Escape again cancels editing
  • All user-defined links open in a new tab

Legacy Markdown:

  • Editing disabled
  • Tool added to convert old markdown to the new format

View Mode: View Mode

Empty Editor Mode: Empty Editor

Editor Mode: Editor Mode

Preview Mode: Preview Mode

Jul-28-2025.16-18-58.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025

🔍 Preview links for changed docs

@mbondyra mbondyra changed the title Mk2 [Dashboard] Add Inline Markdown Visualization Jul 28, 2025
@mbondyra mbondyra added Feature:Markdown Markdown visualization feature Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes v9.2.0 labels Jul 28, 2025
@mbondyra mbondyra requested review from a team as code owners August 8, 2025 15:07
Copy link
Contributor

@csr csr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, src/platform/test/functional/page_objects/index.ts codeowner change LGTM. I'm very excited about this feature! 🎉

Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM. Although the kibana.jsonc change is unnecessary.

Copy link
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only for owned code

}: MarkdownEditorProps) => {
const styles = useMemoCss(componentStyles);
const isPreview = useStateFromPublishingSubject(isPreview$);
const [value, onChange] = React.useState(content);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add useState from the React import

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 600 602 +2
apm 1953 1955 +2
canvas 1378 1379 +1
cases 1132 1133 +1
controls 391 393 +2
dashboard 690 692 +2
dashboardEnhanced 121 123 +2
dashboardMarkdown - 101 +101
dataVisualizer 754 756 +2
discover 1383 1385 +2
discoverEnhanced 84 85 +1
embeddable 107 109 +2
embeddableAlertsTable 513 515 +2
embeddableEnhanced 83 84 +1
imageEmbeddable 156 158 +2
inputControlVis 108 109 +1
lens 1399 1401 +2
links 133 135 +2
maps 1279 1281 +2
ml 2499 2501 +2
presentationPanel 150 153 +3
reporting 221 222 +1
securitySolution 7864 7865 +1
slo 1233 1235 +2
synthetics 1339 1341 +2
triggersActionsUi 965 966 +1
urlDrilldown 86 87 +1
visTypeMarkdown 87 12 -75
visTypeVega 566 567 +1
visualizations 536 538 +2
total +73

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/presentation-containers 72 75 +3
@kbn/presentation-publishing 225 230 +5
total +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 620.3KB 620.3KB +46.0B
dashboardMarkdown - 71.2KB +71.2KB
presentationPanel 98.2KB 99.0KB +803.0B
visTypeMarkdown 60.7KB 1.3KB -59.5KB
total +12.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardMarkdown - 4.5KB +4.5KB
visTypeMarkdown 8.6KB 7.8KB -835.0B
total +3.7KB
Unknown metric groups

API count

id before after diff
@kbn/presentation-containers 83 88 +5
@kbn/presentation-publishing 269 276 +7
total +12

async chunk count

id before after diff
dashboardMarkdown - 2 +2
visTypeMarkdown 4 2 -2
total -0

ESLint disabled line counts

id before after diff
dashboardMarkdown - 3 +3

References to deprecated APIs

id before after diff
presentationPanel 4 6 +2

Total ESLint disabled count

id before after diff
dashboardMarkdown - 3 +3

History

@mbondyra mbondyra merged commit 0ebacf3 into elastic:main Aug 11, 2025
13 checks passed
@mbondyra mbondyra deleted the mk2 branch August 11, 2025 16:31
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
## Summary

Fixes elastic#188910

### Features

* Inline editing
* Editor focus persists when toggling between edit/preview
* Pressing `Escape` while editing moves focus to **Discard**; pressing
`Escape` again cancels editing
* All user-defined links open in a new tab

**Legacy Markdown:**

* Editing disabled
* Tool added to convert old markdown to the new format
---


**View Mode:** <img width="757" height="471" alt="View Mode"
src="https://github.com/user-attachments/assets/7e80daf1-4a58-43ff-a8fb-881e14942d49"
/>

**Empty Editor Mode:** <img width="755" height="466" alt="Empty Editor"
src="https://github.com/user-attachments/assets/0add643f-ffad-4a35-9a97-767fc773e185"
/>

**Editor Mode:** <img width="754" height="462" alt="Editor Mode"
src="https://github.com/user-attachments/assets/eb6ec81d-7ade-4c92-a169-64572bad185f"
/>

**Preview Mode:** <img width="759" height="466" alt="Preview Mode"
src="https://github.com/user-attachments/assets/674a4954-fff5-4667-b700-4916822fcb2e"
/>


https://github.com/user-attachments/assets/71b230e9-b098-4292-a747-232ece5dcd2e

---------

Co-authored-by: kibanamachine <[email protected]>
qn895 pushed a commit to qn895/kibana that referenced this pull request Aug 26, 2025
## Summary

Fixes elastic#188910

### Features

* Inline editing
* Editor focus persists when toggling between edit/preview
* Pressing `Escape` while editing moves focus to **Discard**; pressing
`Escape` again cancels editing
* All user-defined links open in a new tab

**Legacy Markdown:**

* Editing disabled
* Tool added to convert old markdown to the new format
---


**View Mode:** <img width="757" height="471" alt="View Mode"
src="https://github.com/user-attachments/assets/7e80daf1-4a58-43ff-a8fb-881e14942d49"
/>

**Empty Editor Mode:** <img width="755" height="466" alt="Empty Editor"
src="https://github.com/user-attachments/assets/0add643f-ffad-4a35-9a97-767fc773e185"
/>

**Editor Mode:** <img width="754" height="462" alt="Editor Mode"
src="https://github.com/user-attachments/assets/eb6ec81d-7ade-4c92-a169-64572bad185f"
/>

**Preview Mode:** <img width="759" height="466" alt="Preview Mode"
src="https://github.com/user-attachments/assets/674a4954-fff5-4667-b700-4916822fcb2e"
/>


https://github.com/user-attachments/assets/71b230e9-b098-4292-a747-232ece5dcd2e

---------

Co-authored-by: kibanamachine <[email protected]>
alaudazzi added a commit to elastic/docs-content that referenced this pull request Oct 9, 2025
This PR updates the page
https://www.elastic.co/docs/explore-analyze/visualize/text-panels to
reflect the new Inline markdown editor.

Relates to elastic/kibana#229191
Closes #3076

---------

Co-authored-by: florent-leborgne <[email protected]>
rhr323 pushed a commit to rhr323/docs-content that referenced this pull request Oct 27, 2025
This PR updates the page
https://www.elastic.co/docs/explore-analyze/visualize/text-panels to
reflect the new Inline markdown editor.

Relates to elastic/kibana#229191
Closes elastic#3076

---------

Co-authored-by: florent-leborgne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Markdown Markdown visualization feature needs_docs release_note:feature Makes this part of the condensed release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dashboard usability] Inline Markdown editor

10 participants