[EuiMarkdownEditor] Add footer visibility toggle and toolbar right slot to MarkdownEditor #8889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
force-pushed
the
support_toolbar_props
branch
from
9697307 to
c6d3221
Compare
mbondyra
force-pushed
the
support_toolbar_props
branch
from
c6d3221 to
b50e21c
Compare
mgadewoll
reviewed
Jul 22, 2025
packages/eui/src/components/markdown_editor/markdown_editor.tsx
Outdated
Show resolved
Hide resolved
packages/eui/src/components/markdown_editor/markdown_editor.tsx
Outdated
Show resolved
Hide resolved
packages/eui/src/components/markdown_editor/markdown_editor_toolbar.tsx
Outdated
Show resolved
Hide resolved
packages/eui/src/components/markdown_editor/markdown_editor_toolbar.tsx
Outdated
Show resolved
Hide resolved
packages/eui/src/components/markdown_editor/markdown_editor.tsx
Outdated
Show resolved
Hide resolved
mgadewoll
reviewed
Jul 22, 2025
packages/eui/src/components/markdown_editor/markdown_editor.tsx
Outdated
Show resolved
Hide resolved
mgadewoll
reviewed
Jul 22, 2025
Contributor
Author
|
@mgadewoll Thanks for a lightspeed review! I think I've addressed all your comments and added the storybook and website example as discussed offline. Not sure about the i18ntokens.json file changes - let me know if that's something I should revert, it was caused by the commit prehooks. |
mgadewoll
reviewed
Jul 22, 2025
packages/website/docs/components/editors-and-syntax/markdown/editor.mdx
Outdated
Show resolved
Hide resolved
mgadewoll
reviewed
Jul 23, 2025
mbondyra
commented
Jul 23, 2025
mgadewoll
approved these changes
Jul 23, 2025
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
🟢 Code changes are looking good to me. The component props updates work as intended. Nice work! Thank you for contributing! 🎉
Collaborator
💚 Build SucceededHistory
cc @mbondyra |
Collaborator
💚 Build Succeeded
History
cc @mbondyra |
Contributor
Author
|
Thank you @mgadewoll! Looks like I have no permission to merge this PR. Could you hit the button? 🙏🏼 |
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Aug 5, 2025
`106.1.0` ⏩ `106.2.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0) - Enhanced `EuiCheckableCard` to make non-interactive children clickable for card selection ([#8907](elastic/eui#8907)) - Added `showFooter` and `toolbarProps.right` props to `EuiMarkdownEditor` for more flexible layout control. ([#8889](elastic/eui#8889)) ([#8889](elastic/eui#8889)) **Bug fixes** - Fixed `EuiPopover` not closing on outside click after multiple fast clicks on the trigger element ([#8882](elastic/eui#8882)) **Accessibility** - Added accessible labels to virtualized `EuiCodeBlock` ([#8887](elastic/eui#8887)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Marta Bondyra <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
`106.1.0` ⏩ `106.2.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0) - Enhanced `EuiCheckableCard` to make non-interactive children clickable for card selection ([elastic#8907](elastic/eui#8907)) - Added `showFooter` and `toolbarProps.right` props to `EuiMarkdownEditor` for more flexible layout control. ([elastic#8889](elastic/eui#8889)) ([elastic#8889](elastic/eui#8889)) **Bug fixes** - Fixed `EuiPopover` not closing on outside click after multiple fast clicks on the trigger element ([elastic#8882](elastic/eui#8882)) **Accessibility** - Added accessible labels to virtualized `EuiCodeBlock` ([elastic#8887](elastic/eui#8887)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Marta Bondyra <[email protected]>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
`106.1.0` ⏩ `106.2.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0) - Enhanced `EuiCheckableCard` to make non-interactive children clickable for card selection ([elastic#8907](elastic/eui#8907)) - Added `showFooter` and `toolbarProps.right` props to `EuiMarkdownEditor` for more flexible layout control. ([elastic#8889](elastic/eui#8889)) ([elastic#8889](elastic/eui#8889)) **Bug fixes** - Fixed `EuiPopover` not closing on outside click after multiple fast clicks on the trigger element ([elastic#8882](elastic/eui#8882)) **Accessibility** - Added accessible labels to virtualized `EuiCodeBlock` ([elastic#8887](elastic/eui#8887)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #8865
Adds two new props to
EuiMarkdownEditorto support the Dashboard Markdown visualization use case:showFooter— allows consumers to show/hide the editor footer entirely.toolbarProps.right— allows replacing the default preview/editor switch with a custom node on the right side of the toolbar.These changes make it easier to control the editor layout in custom contexts while keeping the default behavior intact.
Exposes
EuiMarkdownHelpButton- in Kibana, we want to display it on the right top corner.Checklist
Screenshots
Impact to users
Defaults remain unchanged
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles