[Discover] Add underline to search result highlights and restore missing field formatter styles#228941
Merged
akowalska622 merged 4 commits intoelastic:8.19from Jul 28, 2025
Merged
Conversation
…28086) Closes elastic#214592 This PR adds `text-decoration: dotted underline` to search result highlights due to accessibility reasons. <img width="1427" height="493" alt="Screenshot 2025-07-15 at 21 08 59" src="https://github.com/user-attachments/assets/c9edb19a-7a59-4aef-b8fe-91f424f62abf" /> <img width="542" height="774" alt="Screenshot 2025-07-15 at 21 07 50" src="https://github.com/user-attachments/assets/e7be0fd1-78d0-46a7-abc4-ec6f4652c7ab" /> Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit 24e9dc2)
10 tasks
davismcphee
reviewed
Jul 23, 2025
davismcphee
added
the
Team:DataDiscovery
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
Author
|
Also thanks for updating the branch @davismcphee, I was just about to investigate my failing tests, but updating helped 😁 |
akowalska622
force-pushed
the
backport/8.19/pr-228086
branch
from
a934773 to
0587436
Compare
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
akowalska622
force-pushed
the
backport/8.19/pr-228086
branch
from
0587436 to
c473dcb
Compare
akowalska622
changed the title
davismcphee
approved these changes
Jul 28, 2025
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Tested locally and confirmed all mentioned issues are fixed, thanks! Should be good to merge after we update the release notes to cover all changes 👍
Contributor
|
I didn't realize auto merge was enabled 🤦 I'm gonna go ahead and make the suggested changes now. |
davismcphee
changed the title
Contributor
Author
|
Thank you for all adjustments @davismcphee! 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Additionally it reverts styles, which were accidentally deleted in backport: #224213
Questions ?
Please refer to the Backport tool documentation
Release note
Adds an underline to the search result highlight styles to improve accessibility, and fixes missing field formatter styles that were mistakenly removed in the 8.19 release.