[8.19] [Discover] SCSS to Emotions migration part 3/4 (#222947)#224213
Merged
akowalska622 merged 4 commits intoelastic:8.19from Jun 18, 2025
Merged
[8.19] [Discover] SCSS to Emotions migration part 3/4 (#222947)#224213akowalska622 merged 4 commits intoelastic:8.19from
akowalska622 merged 4 commits intoelastic:8.19from
Conversation
## Summary Parent issue: [[DataDiscovery] Replace SCSS with CSS-in-JS](elastic#209807 (comment)) Followed [Emotion standards guide](https://docs.google.com/document/d/1CPflY8yCc3lZDg2BQkaMTgIkZlqiAEyMcAAvZbsjcTc/edit?pli=1&tab=t.0#heading=h.4zj1jq66y5an) Part 3 of SCSS -> Emotion migration. Files included: ### Part 3 - `src/platform/plugins/shared/field_formats/public/index.scss` - `src/platform/plugins/shared/field_formats/public/lib/content_types/_html_content_type.scss` - `src/platform/plugins/shared/field_formats/public/lib/content_types/_index.scss` - `src/platform/plugins/shared/field_formats/public/lib/converters/_index.scss` - `src/platform/plugins/shared/field_formats/public/lib/converters/_string.scss` - `src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_source/source.scss` - `src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table.scss` - `src/platform/plugins/shared/unified_doc_viewer/public/components/json_code_editor/json_code_editor.scss` (cherry picked from commit adffdde) # Conflicts: # src/core/packages/application/common/src/global_app_style.tsx # src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_source/source.tsx # src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table.scss # src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table.tsx # src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table_cell_value.tsx
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
AlexGPlay
approved these changes
Jun 18, 2025
Contributor
AlexGPlay
left a comment
AlexGPlay
left a comment
There was a problem hiding this comment.
lgtm - just a quick question, is useMemoizedStyles not available in this 8.19?
Contributor
Author
It's not, it was not backported, but also as far as I know, while using |
akowalska622
added a commit
that referenced
this pull request
Jul 28, 2025
… revert formatter styles (#228086) (#228941) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover][A11y] Add underline to search result highlights (#228086)](#228086) Additionally it reverts styles, which were accidentally deleted in backport: #224213 ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ania Kowalska","email":"63072419+akowalska622@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-22T09:54:02Z","message":"[Discover][A11y] Add underline to search result highlights (#228086)\n\n## Summary\n\nCloses #214592 \n\nThis PR adds `text-decoration: dotted underline` to search result\nhighlights due to accessibility reasons.\n\n<img width=\"1427\" height=\"493\" alt=\"Screenshot 2025-07-15 at 21 08 59\"\nsrc=\"https://github.com/user-attachments/assets/c9edb19a-7a59-4aef-b8fe-91f424f62abf\"\n/>\n\n<img width=\"542\" height=\"774\" alt=\"Screenshot 2025-07-15 at 21 07 50\"\nsrc=\"https://github.com/user-attachments/assets/e7be0fd1-78d0-46a7-abc4-ec6f4652c7ab\"\n/>\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"24e9dc251093713f8d5e1a2585b0f0ad18b63a51","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Platform-Design","Project:Accessibility","WCAG A","release_note:skip","impact:medium","Team:DataDiscovery","defect-level-1","backport:version","v9.1.0","v8.19.0","platform-accessibility","v9.2.0"],"title":"[Discover][A11y] Add underline to search result highlights","number":228086,"url":"https://github.com/elastic/kibana/pull/228086","mergeCommit":{"message":"[Discover][A11y] Add underline to search result highlights (#228086)\n\n## Summary\n\nCloses #214592 \n\nThis PR adds `text-decoration: dotted underline` to search result\nhighlights due to accessibility reasons.\n\n<img width=\"1427\" height=\"493\" alt=\"Screenshot 2025-07-15 at 21 08 59\"\nsrc=\"https://github.com/user-attachments/assets/c9edb19a-7a59-4aef-b8fe-91f424f62abf\"\n/>\n\n<img width=\"542\" height=\"774\" alt=\"Screenshot 2025-07-15 at 21 07 50\"\nsrc=\"https://github.com/user-attachments/assets/e7be0fd1-78d0-46a7-abc4-ec6f4652c7ab\"\n/>\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"24e9dc251093713f8d5e1a2585b0f0ad18b63a51"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228086","number":228086,"mergeCommit":{"message":"[Discover][A11y] Add underline to search result highlights (#228086)\n\n## Summary\n\nCloses #214592 \n\nThis PR adds `text-decoration: dotted underline` to search result\nhighlights due to accessibility reasons.\n\n<img width=\"1427\" height=\"493\" alt=\"Screenshot 2025-07-15 at 21 08 59\"\nsrc=\"https://github.com/user-attachments/assets/c9edb19a-7a59-4aef-b8fe-91f424f62abf\"\n/>\n\n<img width=\"542\" height=\"774\" alt=\"Screenshot 2025-07-15 at 21 07 50\"\nsrc=\"https://github.com/user-attachments/assets/e7be0fd1-78d0-46a7-abc4-ec6f4652c7ab\"\n/>\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"24e9dc251093713f8d5e1a2585b0f0ad18b63a51"}}]}] BACKPORT--> --------- Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation